Re: [PATCH v9 58/61] drm/connector: Remove drmm_connector_hdmi_ini2()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete transition and missed cleanup of TODOs for HDMI connector state fields.
--

--- Patch [58]: [PATCH v9 58/61] drm/connector: Remove drmm_connector_hdmi_ini2() ---
commit bc0f9c01790d98f211c2100593457435fcb56011
Author: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>

    drm/connector: Remove drmm_connector_hdmi_ini2()

This commit removes the transitional drmm_connector_hdmi_ini2() function
since all callers have been converted to the new drmm_connector_hdmi_init()
signature.

> All callers have been converted to the new drmm_connector_hdmi_init()
> signature.  Remove the transitional drmm_connector_hdmi_ini2() function,
> its declaration, its EXPORT_SYMBOL() and its kernel-doc.

[Severity: Medium]
If the transition is now complete, were the TODO cleanups in
drmm_connector_hdmi_init() missed?

There are still assignments left with explicit TODO comments in
drivers/gpu/drm/drm_connector.c:

	/* TODO: remove after conversion to new drmm_connector_hdmi_init() */
	connector->hdmi.supported_formats = hdmi_funcs->supported_formats;
	...
	/* TODO: remove after conversion to new drmm_connector_hdmi_init() */
	strtomem_pad(connector->hdmi.vendor, hdmi_funcs->vendor, 0);
	strtomem_pad(connector->hdmi.product, hdmi_funcs->product, 0);
	...
	/* TODO: remove after conversion to new drmm_connector_hdmi_init() */
	connector->max_bpc = hdmi_funcs->max_bpc;

Additionally, external consumers still appear to rely on the duplicated
state fields rather than using the funcs structure. For instance, in
drivers/gpu/drm/display/drm_hdmi_state_helper.c:

	if (!(connector->hdmi.supported_formats & BIT(format))) {

Since this patch marks the end of the transition, should these duplicated
fields be removed and their users updated to use
connector->hdmi.funcs->supported_formats instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723-dw-hdmi-qp-scramb-v9-0-4fb12ea22ac9@collabora.com?part=58