From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f50.google.com (mail-yx1-f50.google.com [74.125.224.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AF300379C28 for ; Thu, 23 Jul 2026 04:50:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782214; cv=none; b=FVeNKq6sy+J4e/ZRn9jb+RCosHI1tkFFLXRLfeKkCv/qoWP+jkbmCJirh6+6NUfXmxFh2WhXJWMtd/X27EuXqeBRXCFXNkLGlZeM3lZ6oxHwQl6KM5PPXMC/1zzdWcme7eeSwYI+ClncQHeq0CjPDNZ5Jo8CE47oxxtkv6EOm8I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784782214; c=relaxed/simple; bh=TZ7U/AHthuLUnoGERTF8l5T/F7F9mFbgJL5SpGEqH5A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=eGsiyq+uNyfCOh5GyrX5uQN2+R9WCe+Fb+V4GoKEWpzkwESzb8LB1qtovPDsV0gwroSzXJCTSwXid3p2QQ3SXGfWtbYcjkwyxas0+WnPatFsK1B2WYIT2tp0fzu6bKzle4bQk9FMTt+o9paN/bNqRDtxdCXiVL40CMTCVc0PdpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H8LBxF/x; arc=none smtp.client-ip=74.125.224.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H8LBxF/x" Received: by mail-yx1-f50.google.com with SMTP id 956f58d0204a3-668005ba03cso155439d50.2 for ; Wed, 22 Jul 2026 21:50:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784782197; x=1785386997; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=oX1J+3MeCS3KsoZ2FoZ1r+rWkZZmYHTG9sCtmKtp15c=; b=H8LBxF/xtpoUgX9O4J7in9pZ3xqtM9eRrSAn60Eev8Rh3um/3vOrKflO0LFGJXlXjV HodDOay7c7wjY9pEumXzRcbbJt+Gl2Ju17VcWgt7ryS8QNpeeFeE5diKsxumGPibkAI2 Bs6+x+UkIrCV6db7e1yGVGkZaQUSAQYubnOXsCFEozUfRcZHbO1XvX8mn2EvhgVkKBoQ vWCR+Mzv1+rP8UOrqbkSWDt3yc7K1Iqo/I27JhV7cx/85c7R7ARtBo6Y/+m+hjdtDLoI 48s7ghJnWgPKJ5R8dJPbadYeiUQBzSlGoYLMhdRCRKbhwhvMV/E9KxYTmfKleGauRB1i 7kSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784782197; x=1785386997; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=oX1J+3MeCS3KsoZ2FoZ1r+rWkZZmYHTG9sCtmKtp15c=; b=NUjN+ovT5NQyOIFmwV3NlV8dvA+OjsxCpQCZ3CmfurJY3a0LllGwYm1++IDIvf9QdA gOXuxjYsuFzn3z0Cf/oWu995/Z7+LBGQ2fu+KoVJT9hg9xBU6s9u8posZYD5YZWcnZck NP15Yn3/j2OUUaDj8II2eknVb/c99ULSxyCKtxHggYcM0McalFmVX6mFElzh7NAZLvso 0BoTN+GSLU154b8fT51GJzplpnLBk90WG7BnHf7vCYGndduDQBMWRkeArc9sGSagFFus zqtx4NYlX+k1P5f0cfliyFBP4x2sifds/qa09wnay31QMUMkH3ggeQVoKQDzn2lUKXl9 ODkw== X-Forwarded-Encrypted: i=1; AHgh+Ro+UyH5tcym2vIHpliR+eyedzeLm9l+XDXSuEM+ZPpoP9qj+LYAw05yv/zISYXv+5XIEfytFWZ6W9eNWd8=@vger.kernel.org X-Gm-Message-State: AOJu0YxD1RpQTrwAan/vFhW0LQst1zAPqCRY5+Io9hqvCn4O1g6HRaGa VqZZVxGDoLNZPnTdDvjO6sZBOmujuPamrNw1V9drEpNuTeR9BZTQknMy X-Gm-Gg: AR+sD13PR8xkZt9J7dOagKIlMG/pz7LfOleHSvr/+k4CZxC2CSSYm//ts0ReoGmFpE/ xqjbSjh8897+unmI57Vb2rlxjIuzcUO7dxZOmc/hyTX3B+WPBHep9fHtak88pQtrjTHdInlVUSd Nkj76Jia9yRqJ2eMYS7THVnecDf9PgX+385s6hgZq3bZYaynRUl+HrkeQ/mtl60zblwglZdWpqs LV7M+J5WvDuB9yGCPNaged1TRHB3/kEMCK3EKCzjJCy8LPmJP5bDYE+nc/8fIXJgVWNNm+PuAXT dzBh8g4F2h5GJ8mV2iYMBeoRRB+xhqAkJtJGL7wNSBc6jdO7kYK2WuDr5y2/iD+dD0Tydvy3/oV 8JP0eWkjS06jsUhDzMNV4r8Fl1sdCNoOeGN9KLjh/KmxVI8dLGWHRiHEst/DtsqKiItiJ+0tSkN HhVt9Ipt7EajIEZMWs2K7oFlK14b0RXBduiM0nCNlw3/VwXvh7WVfHwbKlZMG2+jvPSYwnhKGLa zZf30MunNGllQ== X-Received: by 2002:a05:690e:43d9:b0:668:91a8:d44e with SMTP id 956f58d0204a3-668a5001e98mr270017d50.80.1784782197160; Wed, 22 Jul 2026 21:49:57 -0700 (PDT) Received: from LAPTOP-83ECOPAB.f7a5e5c3-cab1-4810-bdbb-207cdd06de9e.globalsecureaccess.local ([136.55.173.105]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6689052164esm2502133d50.4.2026.07.22.21.49.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Jul 2026 21:49:56 -0700 (PDT) From: "Cen Zhang (Microsoft)" To: jhs@mojatatu.com, jiri@resnulli.us, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: horms@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, AutonomousCodeSecurity@microsoft.com, tgopinath@linux.microsoft.com, kys@microsoft.com, blbllhy@gmail.com, Victor Nogueira Subject: [PATCH net v2] net/sched: cls_u32: validate offshift to prevent shift-out-of-bounds Date: Thu, 23 Jul 2026 00:49:55 -0400 Message-ID: <20260723044955.89471-1-blbllhy@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit u32_change() copies the user-provided tc_u32_sel.offshift (unsigned char, 0-255) into the kernel knode object without bounds validation. When a packet later hits u32_classify() with TC_U32_VAROFFSET set, it evaluates `ntohs(offmask & *data) >> offshift` where the left operand is a 16-bit value promoted to a 32-bit int. Any offshift >= 32 is undefined behavior per C11 6.5.7p3, triggerable by an unprivileged user via user/network namespaces. UBSAN: shift-out-of-bounds in net/sched/cls_u32.c:236:43 shift exponent 32 is too large for 32-bit type int Fix this by rejecting offshift >= 16 during filter creation in u32_change(). Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Reported-by: AutonomousCodeSecurity@microsoft.com Link: https://lore.kernel.org/all/20260720034514.23053-1-blbllhy@gmail.com Signed-off-by: Cen Zhang (Microsoft) Acked-by: Jamal Hadi Salim Tested-by: Jamal Hadi Salim Tested-by: Victor Nogueira --- v2: - Drop TC_U32_VAROFFSET condition as suggested by Jamal. net/sched/cls_u32.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/sched/cls_u32.c b/net/sched/cls_u32.c index 8f30cc82181d..ac98b1c2144a 100644 --- a/net/sched/cls_u32.c +++ b/net/sched/cls_u32.c @@ -1107,6 +1107,13 @@ static int u32_change(struct net *net, struct sk_buff *in_skb, goto erridr; } + if (s->offshift >= 16) { + NL_SET_ERR_MSG_MOD(extack, + "offshift must be less than 16"); + err = -EINVAL; + goto erridr; + } + n = kzalloc_flex(*n, sel.keys, s->nkeys); if (n == NULL) { err = -ENOBUFS; -- 2.53.0