From: Ian Rogers <irogers@google.com>
To: irogers@google.com, acme@kernel.org, namhyung@kernel.org
Cc: adrian.hunter@intel.com, dapeng1.mi@linux.intel.com,
james.clark@linaro.org, jistone@redhat.com, jolsa@kernel.org,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, tianyou.li@intel.com
Subject: [PATCH v7 0/6] perf ui hists / annotate: Remaining fixes for reference counting and annotation
Date: Wed, 22 Jul 2026 21:59:43 -0700 [thread overview]
Message-ID: <20260723045949.988740-1-irogers@google.com> (raw)
In-Reply-To: <20260716072351.560311-1-irogers@google.com>
This series contains the remaining 6 unmerged patches from our UI, hists,
and annotate fix series. Upstream maintainer Namhyung Kim applied patches
1-6 (except patch 4) from the v6 series into perf-tools-next.
This v7 series includes:
- Fix stack use-after-return for symbol_filter_str by duplicating with
strdup() and freeing during evsel destruction in hists_evsel__exit().
- Guard against NULL hist_entry in add_script_opt() when trace is empty.
- Populate map_symbol thread in report UI with proper reference counting
(map_symbol__copy, thread__get) and memset zeroing in
free_popup_actions().
- Fix dso_filter reference leak and exit zoom cleanup.
- Robust cross-platform disassembly fallback when annotating without a
thread.
- Remove duplicated thread member from struct popup_action (placed at the
end of the series per reviewer feedback).
v7 Changes:
- Rebased onto latest perf-tools-next (after patches 1-3, 5-6 were
merged).
- Move symbol_filter_str teardown to hists_evsel__exit() to allow filter
persistence across TUI navigation while preventing memory leaks.
- Add memset zeroing to free_popup_actions() to prevent cross-iteration
stale action leakage.
- Placed "Remove duplicated thread in popup_action" as the final patch
in the series as requested.
Ian Rogers (6):
perf ui hists: Fix stack use-after-return in symbol_filter_str
perf ui hists: Guard against NULL hist_entry in add_script_opt()
perf ui hists: In report UI ensure thread is set with reference
counting
perf ui hists: Fix dso_filter reference leak and exit zoom cleanup
perf annotate: Be robust to annotating without a thread
perf ui hists: Remove duplicated thread in popup_action
tools/perf/builtin-report.c | 7 +-
tools/perf/ui/browsers/annotate.c | 2 +-
tools/perf/ui/browsers/hists.c | 153 ++++++++++++++++++++----------
tools/perf/util/annotate.c | 51 +++++++---
tools/perf/util/annotate.h | 3 +-
tools/perf/util/capstone.c | 42 ++++++--
tools/perf/util/hist.c | 1 +
7 files changed, 182 insertions(+), 77 deletions(-)
--
2.55.0.229.g6434b31f56-goog
next prev parent reply other threads:[~2026-07-23 4:59 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 23:46 [PATCH v1 1/3] perf ui hists: In report UI ensure thread is set Ian Rogers
2026-07-08 23:46 ` [PATCH v1 2/3] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-08 23:58 ` sashiko-bot
2026-07-08 23:46 ` [PATCH v1 3/3] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-08 23:58 ` sashiko-bot
2026-07-09 3:36 ` [PATCH v2 1/4] perf ui hists: In report UI ensure thread is set Ian Rogers
2026-07-09 3:36 ` [PATCH v2 2/4] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-09 3:52 ` sashiko-bot
2026-07-09 3:37 ` [PATCH v2 3/4] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-09 3:57 ` sashiko-bot
2026-07-09 3:37 ` [PATCH v2 4/4] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow Ian Rogers
2026-07-09 3:52 ` sashiko-bot
2026-07-09 3:54 ` [PATCH v2 1/4] perf ui hists: In report UI ensure thread is set sashiko-bot
2026-07-09 16:52 ` [PATCH v3 " Ian Rogers
2026-07-09 16:52 ` [PATCH v3 2/4] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-09 17:10 ` sashiko-bot
2026-07-09 16:52 ` [PATCH v3 3/4] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-09 17:04 ` sashiko-bot
2026-07-09 16:52 ` [PATCH v3 4/4] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow Ian Rogers
2026-07-09 17:08 ` sashiko-bot
2026-07-09 17:08 ` [PATCH v3 1/4] perf ui hists: In report UI ensure thread is set sashiko-bot
2026-07-10 2:49 ` [PATCH v4 1/9] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow Ian Rogers
2026-07-10 2:49 ` [PATCH v4 2/9] perf ui hists: In report UI ensure thread is set Ian Rogers
2026-07-10 3:05 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 3/9] perf disasm: Fix potential NULL pointer dereference in arch__find() Ian Rogers
2026-07-10 2:59 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 4/9] perf ui hists: Fix uninitialized stack memory free on pstack allocation failure Ian Rogers
2026-07-10 3:09 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 5/9] perf ui hists: Fix memory leak in evsel__hists_browse() interactive loop Ian Rogers
2026-07-10 3:05 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 6/9] perf ui hists: Fix dso_filter reference leak and exit cleanup Ian Rogers
2026-07-10 3:07 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 7/9] perf ui hists: Fix NULL pointer array gap in add_script_opt() Ian Rogers
2026-07-10 2:49 ` [PATCH v4 8/9] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-10 3:09 ` sashiko-bot
2026-07-10 2:49 ` [PATCH v4 9/9] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-10 3:17 ` sashiko-bot
2026-07-10 3:06 ` [PATCH v4 1/9] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow sashiko-bot
2026-07-10 5:36 ` [PATCH v5 01/10] " Ian Rogers
2026-07-10 5:36 ` [PATCH v5 02/10] perf ui hists: Fix uninitialized stack memory free on pstack allocation failure Ian Rogers
2026-07-10 5:55 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 03/10] perf ui hists: Include limits.h for PATH_MAX definition Ian Rogers
2026-07-10 5:36 ` [PATCH v5 04/10] perf ui hists: Fix stack use-after-return in symbol_filter_str Ian Rogers
2026-07-10 5:59 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 05/10] perf disasm: Fix potential NULL pointer dereference and use-after-free in arch__find() Ian Rogers
2026-07-10 5:36 ` [PATCH v5 06/10] perf ui hists: Fix NULL pointer array gap in add_script_opt() Ian Rogers
2026-07-10 5:56 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 07/10] perf ui hists: In report UI ensure thread is set with reference counting Ian Rogers
2026-07-10 5:54 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 08/10] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-10 5:54 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 09/10] perf ui hists: Fix dso_filter reference leak and exit zoom cleanup Ian Rogers
2026-07-10 5:58 ` sashiko-bot
2026-07-10 5:36 ` [PATCH v5 10/10] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-10 6:08 ` sashiko-bot
2026-07-10 5:54 ` [PATCH v5 01/10] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow sashiko-bot
2026-07-16 7:23 ` [PATCH v6 " Ian Rogers
2026-07-16 7:23 ` [PATCH v6 02/10] perf ui hists: Fix uninitialized stack memory free on pstack allocation failure Ian Rogers
2026-07-16 7:40 ` sashiko-bot
2026-07-16 7:23 ` [PATCH v6 03/10] perf ui hists: Include limits.h for PATH_MAX definition Ian Rogers
2026-07-16 7:23 ` [PATCH v6 04/10] perf ui hists: Fix stack use-after-return in symbol_filter_str Ian Rogers
2026-07-16 7:48 ` sashiko-bot
2026-07-18 5:38 ` Namhyung Kim
2026-07-16 7:23 ` [PATCH v6 05/10] perf disasm: Fix potential NULL pointer dereference and use-after-free in arch__find() Ian Rogers
2026-07-16 7:40 ` sashiko-bot
2026-07-16 7:23 ` [PATCH v6 06/10] perf ui hists: Fix NULL pointer array gap in add_script_opt() Ian Rogers
2026-07-16 7:39 ` sashiko-bot
2026-07-16 7:23 ` [PATCH v6 07/10] perf ui hists: In report UI ensure thread is set with reference counting Ian Rogers
2026-07-16 7:35 ` sashiko-bot
2026-07-16 7:23 ` [PATCH v6 08/10] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-16 7:37 ` sashiko-bot
2026-07-18 5:38 ` Namhyung Kim
2026-07-16 7:23 ` [PATCH v6 09/10] perf ui hists: Fix dso_filter reference leak and exit zoom cleanup Ian Rogers
2026-07-16 7:49 ` sashiko-bot
2026-07-16 7:23 ` [PATCH v6 10/10] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-16 7:51 ` sashiko-bot
2026-07-20 4:45 ` [PATCH v6 01/10] perf hists browser: Increase MAX_OPTIONS to prevent stack buffer overflow Namhyung Kim
2026-07-22 16:37 ` Ian Rogers
2026-07-23 4:59 ` Ian Rogers [this message]
2026-07-23 4:59 ` [PATCH v7 1/6] perf ui hists: Fix stack use-after-return in symbol_filter_str Ian Rogers
2026-07-23 5:17 ` sashiko-bot
2026-07-23 4:59 ` [PATCH v7 2/6] perf ui hists: Guard against NULL hist_entry in add_script_opt() Ian Rogers
2026-07-23 5:19 ` sashiko-bot
2026-07-23 4:59 ` [PATCH v7 3/6] perf ui hists: In report UI ensure thread is set with reference counting Ian Rogers
2026-07-23 4:59 ` [PATCH v7 4/6] perf ui hists: Fix dso_filter reference leak and exit zoom cleanup Ian Rogers
2026-07-23 4:59 ` [PATCH v7 5/6] perf annotate: Be robust to annotating without a thread Ian Rogers
2026-07-23 5:34 ` sashiko-bot
2026-07-23 4:59 ` [PATCH v7 6/6] perf ui hists: Remove duplicated thread in popup_action Ian Rogers
2026-07-23 5:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723045949.988740-1-irogers@google.com \
--to=irogers@google.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=dapeng1.mi@linux.intel.com \
--cc=james.clark@linaro.org \
--cc=jistone@redhat.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=tianyou.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.