From: Ashmit Kumar <work.ashmitkumar@gmail.com>
To: bgolaszewski@baylibre.com
Cc: kuba@kernel.org, alexander.deucher@amd.com,
linux-kernel@vger.kernel.org,
Ashmit Kumar <work.ashmitkumar@gmail.com>
Subject: [PATCH] bus: da8xx-mstpri: remove redundant dev_err()
Date: Thu, 23 Jul 2026 07:22:22 +0000 [thread overview]
Message-ID: <20260723072222.517-1-work.ashmitkumar@gmail.com> (raw)
The devm_ioremap_resource() function already prints a detailed error message if it fails to map the resource. Thus, calling dev_err() immediately after it fails is redundant.
Remove the duplicate dev_err() call and its surrounding curly braces to conform to kernel coding style.
Signed-off-by: Ashmit Kumar <work.ashmitkumar@gmail.com>
---
drivers/bus/da8xx-mstpri.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/bus/da8xx-mstpri.c b/drivers/bus/da8xx-mstpri.c
index ee4c0233513..96c117922db 100644
--- a/drivers/bus/da8xx-mstpri.c
+++ b/drivers/bus/da8xx-mstpri.c
@@ -215,10 +215,8 @@ static int da8xx_mstpri_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
mstpri = devm_ioremap_resource(dev, res);
- if (IS_ERR(mstpri)) {
- dev_err(dev, "unable to map MSTPRI registers\n");
+ if (IS_ERR(mstpri))
return PTR_ERR(mstpri);
- }
prio_list = da8xx_mstpri_get_board_prio();
if (!prio_list) {
--
2.43.0
reply other threads:[~2026-07-23 7:23 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723072222.517-1-work.ashmitkumar@gmail.com \
--to=work.ashmitkumar@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=bgolaszewski@baylibre.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.