All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wenjia Zhang" <wenjia@linux.ibm.com>
Cc: "Vasily Gorbik" <gor@linux.ibm.com>,
	"Heiko Carstens" <hca@linux.ibm.com>,
	"Alexander Gordeev" <agordeev@linux.ibm.com>,
	linux-s390@vger.kernel.org
Subject: Re: [PATCH net-next] MAINTAINERS: Update SHARED MEMORY COMMUNICATIONS (SMC) maintainer entries
Date: Thu, 23 Jul 2026 08:57:29 +0000	[thread overview]
Message-ID: <20260723085730.833CC1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260722085705.56755-1-wenjia@linux.ibm.com>

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The patch accidentally adds extraneous files `Kernels.code-workspace` and `file` to the repository root.
--

--- Patch [1]: [PATCH net-next] MAINTAINERS: Update SHARED MEMORY COMMUNICATIONS (SMC) maintainer entries ---
commit 8171ff1f0436e110b4e20aa711ab8004cc5cf6d0
Author: Wenjia Zhang <wenjia@linux.ibm.com>

MAINTAINERS: Update SHARED MEMORY COMMUNICATIONS (SMC) maintainer entries

This commit updates the MAINTAINERS file for the SHARED MEMORY COMMUNICATIONS
subsystem. It removes Wenjia Zhang as a maintainer and promotes Mahanta Jambigi
from reviewer to maintainer.

> diff --git a/Kernels.code-workspace b/Kernels.code-workspace
> new file mode 100644
> index 0000000000000..9e26dfeeb6e64
> --- /dev/null
> +++ b/Kernels.code-workspace
> @@ -0,0 +1 @@
> +{}

[Severity: Low]
Were these files accidentally included in the patch? It looks like a VS Code
workspace configuration file that slipped into the commit.

[ ... ]

> diff --git a/file b/file
> new file mode 100644
> index 0000000000000..e69de29bb2d1d

[Severity: Low]
Does this empty file serve a purpose, or was it also mistakenly staged and
committed alongside the workspace file?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260722085705.56755-1-wenjia@linux.ibm.com?part=1

      parent reply	other threads:[~2026-07-23  8:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-22  8:57 [PATCH net-next] MAINTAINERS: Update SHARED MEMORY COMMUNICATIONS (SMC) maintainer entries Wenjia Zhang
2026-07-22 11:01 ` Mahanta Jambigi
2026-07-22 11:06 ` Vadim Fedorenko
2026-07-22 12:11   ` Wenjia Zhang
2026-07-23  8:57 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260723085730.833CC1F000E9@smtp.kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=agordeev@linux.ibm.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-s390@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wenjia@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.