From: Thomas Huth <thuth@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] get_maintainer: Don't spam others in fallback mode if there is a maintainer
Date: Thu, 23 Jul 2026 12:55:45 +0200 [thread overview]
Message-ID: <20260723105545.294045-1-thuth@redhat.com> (raw)
From: Thomas Huth <thuth@redhat.com>
The get_maintainer.pl script currently suggests to CC: people who
contributed to a subfolder of a maintained subsystem, e.g.:
$ scripts/get_maintainer.pl -f arch/arm64/include/asm/smp.h
Catalin Marinas <catalin.marinas@arm.com> (maintainer:ARM64 PORT (AARCH64 ARCHITECTURE),commit_signer:1/1=100%)
Will Deacon <will@kernel.org> (maintainer:ARM64 PORT (AARCH64 ARCHITECTURE))
Thomas Huth <thuth@redhat.com> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:2/2=100%,removed_lines:2/2=100%)
linux-arm-kernel@lists.infradead.org (moderated list:ARM64 PORT (AARCH64 ARCHITECTURE))
linux-kernel@vger.kernel.org (open list)
So if you contributed a single line to a subfolder of a maintained
and active subsystem, you get regularly CC:-ed for all other changes
to the corresponding file during the next year. That's quite excessive.
Limit the fallback mode to files that are not maintained at all by
removing the check for subfolders in the corresponding part of the code.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
scripts/get_maintainer.pl | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 16b80a700d4ac..ded73b9673eb9 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -938,8 +938,7 @@ sub get_maintainers {
my $file_pd = ($file =~ tr@/@@);
$value_pd++ if (substr($value,-1,1) ne "/");
$value_pd = -1 if ($value =~ /^(\.\*|\(\?:\.\*\))/);
- if ($value_pd >= $file_pd &&
- range_is_maintained($start, $end) &&
+ if (range_is_maintained($start, $end) &&
range_has_maintainer($start, $end)) {
$exact_pattern_match_hash{$file} = 1;
}
--
2.55.0
reply other threads:[~2026-07-23 10:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723105545.294045-1-thuth@redhat.com \
--to=thuth@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.