From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4A765C531CB for ; Thu, 23 Jul 2026 11:31:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OgdMt4F10VPb3UlnYqBpUZ0pvTdL1IZxy8YHJtn2+ao=; b=Sju7EaIVz4s3RE gk1aFERct94ncZHX5XEUjbE2IcuQDvTbCX04mJ0iwpdfuUPDft+7iejMSdVyLpR/TlrZflyS/GJKD CHIdF+MwDe98xD3G+OY+IcHF73SsogY0qgikAGzGVn1njssNowblJgIm7xCSfMkfXKwTKybKHHacP FQK51UAM7Q+YBrzuYa7Xac2AbVB7xmR4wCue9cRRMUPn5LUF3677xnuUGsuQru7bjCi1fvCQSRPIZ 2F6ZlrskX08wFjZpR+vb2CdZrhcju+VW/XS6PDBcHfY1UdS/IMc3hMQrU4eB+97QvrDaMuPtXboy9 PzCVWdSc6M64Z/9dzuOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmreR-0000000E9vt-3OuI; Thu, 23 Jul 2026 11:31:43 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wmreP-0000000E9vf-32Hs for linux-phy@lists.infradead.org; Thu, 23 Jul 2026 11:31:41 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id AD07A40334; Thu, 23 Jul 2026 11:31:40 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1152C1F000E9; Thu, 23 Jul 2026 11:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784806300; bh=zTHmzbpmqcAkcVzqNFSrhGQW6IhnCGf+SrtuCSFJ24w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NhCTzTbIdxxXsQpPQuPUVm80tZmjDffm3qFZLd5uAt9RfWfTt5tEQxdk+M1+hS+RL C6Yr0IkKpYXBy2ZYutGT6/Fxr1JKEft7nCJULIMvASwCsYPe8v+/WK97XcsPOhAn0r unCrdtRgLT6RQGNaFtv0BqW3CdOxavmSWme2qkzTydhwaUvirlAC2WhOHOMhRdR5Sc Lt4BcEWp7h/rXw5i7T9hJlYzGcsHwk7mq7W/qq8/M4yL9G17Xf7IImQyIwZ7Y/cdNc QVBDT9cO0Vy60PSLV4ggM5kFBYvnfdaOW58Skj2NVDISB8iU1BWgaKmNKTsbjv8eDU HKJi4pLPYpsig== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 5/5] usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets To: "Krishna Kurapati" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260723-eusb2-int-handling-v5-v5-5-f32ea6c1a318@oss.qualcomm.com> References: <20260723-eusb2-int-handling-v5-v5-0-f32ea6c1a318@oss.qualcomm.com> <20260723-eusb2-int-handling-v5-v5-5-f32ea6c1a318@oss.qualcomm.com> Date: Thu, 23 Jul 2026 11:31:39 +0000 Message-Id: <20260723113140.1152C1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MyBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFJlc291cmNlIGxlYWsg b24gZGV2bV9waHlfZ2V0KCkgZXJyb3IgcGF0aCBpbiBkd2MzX3Fjb21fcHJvYmUoKS4KLSBbSGln aF0gUHJvYmUgZmFpbHMgZHVlIHRvIHVuaGFuZGxlZCAtRU5PU1lTIHdoZW4gQ09ORklHX0dFTkVS SUNfUEhZIGlzIGRpc2FibGVkLgotIFtMb3ddIENvbW1lbnQgZGVzY3JpYmluZyBEUC9ETSBpbnRl cnJ1cHQgcG9sYXJpdHkgY29udHJhZGljdHMgbmV3IGVVU0IyIGxvZ2ljLgotLQoKLS0tIFBhdGNo IFs1XTogW1BBVENIIHY1IDUvNV0gdXNiOiBkd2MzOiBxY29tOiBNb2RpZnkgaW50ZXJydXB0IGhh bmRsaW5nIGZvciBlVVNCMiBQaHkgdGFyZ2V0cyAtLS0KY29tbWl0IGU3YWFjOGI2NTVkZTAzYjhl ODFiZmE3Mjc5MjI5NjA1MDBjYjlhZTMKQXV0aG9yOiBLcmlzaG5hIEt1cmFwYXRpIDxrcmlzaG5h Lmt1cmFwYXRpQG9zcy5xdWFsY29tbS5jb20+Cgp1c2I6IGR3YzM6IHFjb206IE1vZGlmeSBpbnRl cnJ1cHQgaGFuZGxpbmcgZm9yIGVVU0IyIFBoeSB0YXJnZXRzCgpUaGlzIGNvbW1pdCBtb2RpZmll cyB0aGUgaW50ZXJydXB0IGhhbmRsaW5nIGxvZ2ljIGluIHRoZSBEV0MzIFF1YWxjb21tCmRyaXZl ciB0byBzdXBwb3J0IGVVU0IyIFBIWSB0YXJnZXRzLiBJdCBxdWVyaWVzIHRoZSBQSFkgdHlwZSBk dXJpbmcKcHJvYmUgYW5kIGNvbmZpZ3VyZXMgcmVtb3RlIHdha2V1cCBpbnRlcnJ1cHQgcG9sYXJp dGllcyBiYXNlZCBvbiB0aGUKZVVTQjIgc3BlY2lmaWNhdGlvbiBmb3IgZGlmZmVyZW50IGRldmlj ZSBzcGVlZHMuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3VzYi9kd2MzL2R3YzMtcWNvbS5jIGIv ZHJpdmVycy91c2IvZHdjMy9kd2MzLXFjb20uYwo+IGluZGV4IGY0M2Y3M2FjMzZmZjEuLjRjNTU5 Yjk3YzYyNzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy91c2IvZHdjMy9kd2MzLXFjb20uYwo+ICsr KyBiL2RyaXZlcnMvdXNiL2R3YzMvZHdjMy1xY29tLmMKWyAuLi4gXQo+IEBAIC0yODksOCArMjk4 LDEwIEBAIHN0YXRpYyB2b2lkIGR3YzNfcWNvbV9kaXNhYmxlX3BvcnRfaW50ZXJydXB0cyhzdHJ1 Y3QgZHdjM19xY29tX3BvcnQgKnBvcnQpCj4gIAlkd2MzX3Fjb21fZGlzYWJsZV93YWtldXBfaXJx KHBvcnQtPnNzX3BoeV9pcnEpOwo+ICB9Cj4gIAo+IC1zdGF0aWMgdm9pZCBkd2MzX3Fjb21fZW5h YmxlX3BvcnRfaW50ZXJydXB0cyhzdHJ1Y3QgZHdjM19xY29tX3BvcnQgKnBvcnQpCj4gK3N0YXRp YyB2b2lkIGR3YzNfcWNvbV9lbmFibGVfcG9ydF9pbnRlcnJ1cHRzKHN0cnVjdCBkd2MzX3Fjb20g KnFjb20sIGludCBwb3J0X2luZGV4KQo+ICB7Cj4gKwlzdHJ1Y3QgZHdjM19xY29tX3BvcnQgKnBv cnQgPSAmcWNvbS0+cG9ydHNbcG9ydF9pbmRleF07Cj4gKwo+ICAJZHdjM19xY29tX2VuYWJsZV93 YWtldXBfaXJxKHBvcnQtPnF1c2IyX3BoeV9pcnEsIDApOwo+ICAKPiAgCS8qCj4gQEAgLTMwMywx MiArMzE0LDIwIEBAIHN0YXRpYyB2b2lkIGR3YzNfcWNvbV9lbmFibGVfcG9ydF9pbnRlcnJ1cHRz KHN0cnVjdCBkd2MzX3Fjb21fcG9ydCAqcG9ydCkKPiAgCSAqLwoKW1NldmVyaXR5OiBMb3ddClRo aXMgaXNuJ3QgYSBidWcsIGJ1dCBkb2VzIHRoaXMgY29tbWVudCBibG9jayBuZWVkIHRvIGJlIHVw ZGF0ZWQ/ICBUaGUgbmV3bHkKYWRkZWQgZVVTQjIgbG9naWMgYmVsb3cgY29uZmlndXJlcyB0aGVz ZSBsaW5lcyBhcyByaXNpbmcgZWRnZSwgd2hpY2gKY29udHJhZGljdHMgdGhlIGJlaGF2aW9yIGRl c2NyaWJlZCBpbiB0aGlzIGNvbW1lbnQuCgo+ICAKPiAgCWlmIChwb3J0LT51c2IyX3NwZWVkID09 IFVTQl9TUEVFRF9MT1cpIHsKPiAtCQlkd2MzX3Fjb21fZW5hYmxlX3dha2V1cF9pcnEocG9ydC0+ ZG1faHNfcGh5X2lycSwKPiAtCQkJCQkgICAgSVJRX1RZUEVfRURHRV9GQUxMSU5HKTsKPiArCQlp ZiAocWNvbS0+aGFzX2V1c2IyX3BoeSkKPiArCQkJZHdjM19xY29tX2VuYWJsZV93YWtldXBfaXJx KHBvcnQtPmRwX2hzX3BoeV9pcnEsCj4gKwkJCQkJCSAgICBJUlFfVFlQRV9FREdFX1JJU0lORyk7 ClsgLi4uIF0KPiBAQCAtNjgzLDYgKzcwMywxOSBAQCBzdGF0aWMgaW50IGR3YzNfcWNvbV9wcm9i ZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQo+ICAJaWYgKGlnbm9yZV9waXBlX2NsaykK PiAgCQlkd2MzX3Fjb21fc2VsZWN0X3V0bWlfY2xrKHFjb20pOwo+ICAKPiArCWlmIChxY29tLT5u dW1fcG9ydHMgPT0gMSkKPiArCQlwaHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAidXNiMi1waHkiKTsK PiArCWVsc2UKPiArCQlwaHkgPSBkZXZtX3BoeV9nZXQoZGV2LCAidXNiMi0wIik7Cj4gKwo+ICsJ aWYgKElTX0VSUihwaHkpKSB7Cj4gKwkJaWYgKFBUUl9FUlIocGh5KSAhPSAtRU5PREVWKQoKW1Nl dmVyaXR5OiBIaWdoXQpJZiB0aGUga2VybmVsIGlzIGNvbXBpbGVkIHdpdGhvdXQgQ09ORklHX0dF TkVSSUNfUEhZLCBkZXZtX3BoeV9nZXQoKSB3aWxsCnJldHVybiAtRU5PU1lTLiBTaW5jZSB0aGlz IGNoZWNrIG9ubHkgaWdub3JlcyAtRU5PREVWLCB3aWxsIHRoaXMgY2F1c2UgdGhlCnByb2JlIHRv IGZhaWwgZW50aXJlbHkgZm9yIGNvbmZpZ3VyYXRpb25zIHdpdGhvdXQgZ2VuZXJpYyBQSFkgc3Vw cG9ydD8KCj4gKwkJCXJldHVybiBkZXZfZXJyX3Byb2JlKGRldiwgUFRSX0VSUihwaHkpLAo+ICsJ CQkJCSAgICAgImZhaWxlZCB0byBnZXQgdXNiMiBwaHlcbiIpOwoKW1NldmVyaXR5OiBIaWdoXQpE b2VzIHRoaXMgcmV0dXJuIGRpcmVjdGx5IHdpdGhvdXQganVtcGluZyB0byB0aGUgY2xrX2Rpc2Fi bGUgZXJyb3IgbGFiZWw/CgpFYXJsaWVyIGluIGR3YzNfcWNvbV9wcm9iZSgpLCBjbGtfYnVsa19w cmVwYXJlX2VuYWJsZSgpIGlzIGNhbGxlZC4gIElmCmRldm1fcGh5X2dldCgpIGZhaWxzIHdpdGgg YW4gZXJyb3IgbGlrZSAtRVBST0JFX0RFRkVSLCB3aWxsIHRoaXMgbGVhayB0aGUKY2xvY2sgcHJl cGFyZSBhbmQgZW5hYmxlIGNvdW50cz8KCj4gKwkJcGh5ID0gTlVMTDsKPiArCX0KPiArCXFjb20t Pmhhc19ldXNiMl9waHkgPSBwaHkgJiYgKHBoeV9nZXRfdHlwZShwaHkpID09IFBIWV9UWVBFX0VV U0IyKTsKPiArCj4gIAlxY29tLT5tb2RlID0gdXNiX2dldF9kcl9tb2RlKGRldik7CgotLSAKU2Fz aGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzIz LWV1c2IyLWludC1oYW5kbGluZy12NS12NS0wLWYzMmVhNmMxYTMxOEBvc3MucXVhbGNvbW0uY29t P3BhcnQ9NQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGlu dXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4FEFA471CE6 for ; Thu, 23 Jul 2026 11:31:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784806306; cv=none; b=HArdv7IzC7UKMefrMDWV7kdsXzQ4tUB6OZWvPe+nZsqx+6IYGJgwaCBhFeJF+zVQAH2Ho6SPe1BqB/2lElL6HQBKITooPsI0pEljXGq5FcNJiP8FAbNYLgKpUf/E8Jmm3DXoXMCzszwgBToiTba5mGQU3/Fr/OWDZRnXqmKXb7M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784806306; c=relaxed/simple; bh=+Z2o2+OeWwf7TMSK6JgFeKAT/ZHDmeqoaq76XEuH288=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=c6jNflUatnmQgkCIz5wh+AQFwmw5I9pSDFvuKdYtccYkL+dhPWBjyKtlPWXq1mSrFUdlSP9UB2i0o0GWAscdf2qpF4WnLmi13ZNVufLqtTLzTFoFU1f5sLbZAzUXYVMa3k1m+LeMJEzU/MIWi9S+yB3Oj5IdS8P6g/RrA1RneqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NhCTzTbI; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NhCTzTbI" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1152C1F000E9; Thu, 23 Jul 2026 11:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784806300; bh=zTHmzbpmqcAkcVzqNFSrhGQW6IhnCGf+SrtuCSFJ24w=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NhCTzTbIdxxXsQpPQuPUVm80tZmjDffm3qFZLd5uAt9RfWfTt5tEQxdk+M1+hS+RL C6Yr0IkKpYXBy2ZYutGT6/Fxr1JKEft7nCJULIMvASwCsYPe8v+/WK97XcsPOhAn0r unCrdtRgLT6RQGNaFtv0BqW3CdOxavmSWme2qkzTydhwaUvirlAC2WhOHOMhRdR5Sc Lt4BcEWp7h/rXw5i7T9hJlYzGcsHwk7mq7W/qq8/M4yL9G17Xf7IImQyIwZ7Y/cdNc QVBDT9cO0Vy60PSLV4ggM5kFBYvnfdaOW58Skj2NVDISB8iU1BWgaKmNKTsbjv8eDU HKJi4pLPYpsig== From: sashiko-bot@kernel.org Subject: Re: [PATCH v5 5/5] usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets Reply-To: sashiko-reviews@lists.linux.dev To: "Krishna Kurapati" Cc: linux-phy@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20260723-eusb2-int-handling-v5-v5-5-f32ea6c1a318@oss.qualcomm.com> References: <20260723-eusb2-int-handling-v5-v5-0-f32ea6c1a318@oss.qualcomm.com> <20260723-eusb2-int-handling-v5-v5-5-f32ea6c1a318@oss.qualcomm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 23 Jul 2026 11:31:39 +0000 Message-Id: <20260723113140.1152C1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 3 potential issue(= s) to consider: - [High] Resource leak on devm_phy_get() error path in dwc3_qcom_probe(). - [High] Probe fails due to unhandled -ENOSYS when CONFIG_GENERIC_PHY is di= sabled. - [Low] Comment describing DP/DM interrupt polarity contradicts new eUSB2 l= ogic. -- --- Patch [5]: [PATCH v5 5/5] usb: dwc3: qcom: Modify interrupt handling fo= r eUSB2 Phy targets --- commit e7aac8b655de03b8e81bfa727922960500cb9ae3 Author: Krishna Kurapati usb: dwc3: qcom: Modify interrupt handling for eUSB2 Phy targets This commit modifies the interrupt handling logic in the DWC3 Qualcomm driver to support eUSB2 PHY targets. It queries the PHY type during probe and configures remote wakeup interrupt polarities based on the eUSB2 specification for different device speeds. > diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c > index f43f73ac36ff1..4c559b97c6276 100644 > --- a/drivers/usb/dwc3/dwc3-qcom.c > +++ b/drivers/usb/dwc3/dwc3-qcom.c [ ... ] > @@ -289,8 +298,10 @@ static void dwc3_qcom_disable_port_interrupts(struct= dwc3_qcom_port *port) > dwc3_qcom_disable_wakeup_irq(port->ss_phy_irq); > } > =20 > -static void dwc3_qcom_enable_port_interrupts(struct dwc3_qcom_port *port) > +static void dwc3_qcom_enable_port_interrupts(struct dwc3_qcom *qcom, int= port_index) > { > + struct dwc3_qcom_port *port =3D &qcom->ports[port_index]; > + > dwc3_qcom_enable_wakeup_irq(port->qusb2_phy_irq, 0); > =20 > /* > @@ -303,12 +314,20 @@ static void dwc3_qcom_enable_port_interrupts(struct= dwc3_qcom_port *port) > */ [Severity: Low] This isn't a bug, but does this comment block need to be updated? The newly added eUSB2 logic below configures these lines as rising edge, which contradicts the behavior described in this comment. > =20 > if (port->usb2_speed =3D=3D USB_SPEED_LOW) { > - dwc3_qcom_enable_wakeup_irq(port->dm_hs_phy_irq, > - IRQ_TYPE_EDGE_FALLING); > + if (qcom->has_eusb2_phy) > + dwc3_qcom_enable_wakeup_irq(port->dp_hs_phy_irq, > + IRQ_TYPE_EDGE_RISING); [ ... ] > @@ -683,6 +703,19 @@ static int dwc3_qcom_probe(struct platform_device *p= dev) > if (ignore_pipe_clk) > dwc3_qcom_select_utmi_clk(qcom); > =20 > + if (qcom->num_ports =3D=3D 1) > + phy =3D devm_phy_get(dev, "usb2-phy"); > + else > + phy =3D devm_phy_get(dev, "usb2-0"); > + > + if (IS_ERR(phy)) { > + if (PTR_ERR(phy) !=3D -ENODEV) [Severity: High] If the kernel is compiled without CONFIG_GENERIC_PHY, devm_phy_get() will return -ENOSYS. Since this check only ignores -ENODEV, will this cause the probe to fail entirely for configurations without generic PHY support? > + return dev_err_probe(dev, PTR_ERR(phy), > + "failed to get usb2 phy\n"); [Severity: High] Does this return directly without jumping to the clk_disable error label? Earlier in dwc3_qcom_probe(), clk_bulk_prepare_enable() is called. If devm_phy_get() fails with an error like -EPROBE_DEFER, will this leak the clock prepare and enable counts? > + phy =3D NULL; > + } > + qcom->has_eusb2_phy =3D phy && (phy_get_type(phy) =3D=3D PHY_TYPE_EUSB2= ); > + > qcom->mode =3D usb_get_dr_mode(dev); --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260723-eusb2-int-= handling-v5-v5-0-f32ea6c1a318@oss.qualcomm.com?part=3D5