From: sashiko-bot@kernel.org
To: "Finn Callies" <fcallies@linux.ibm.com>
Cc: "Alexander Gordeev" <agordeev@linux.ibm.com>,
linux-s390@vger.kernel.org, "Vasily Gorbik" <gor@linux.ibm.com>,
"Heiko Carstens" <hca@linux.ibm.com>
Subject: Re: [PATCH v1 1/1] s390/ap: Fix queue depth field length
Date: Thu, 23 Jul 2026 15:13:21 +0000 [thread overview]
Message-ID: <20260723151322.2CAE31F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260723150038.93617-2-fcallies@linux.ibm.com>
> The queue depth field is defined as a 5 bit field in the Z architecture
> instead of a 4 bit field.
>
> The queue depth (qd) can be in range 0-31 and is reported in bits 59-63
> of the TAPQ response. Currently this has no effect as all CEX generations
> report a queue depth of 7, which fits into 4 bits. However, future CEX
> generations reporting a value >15 would not be properly reflected by the
> ap bus and therefore all user space applications relying on it.
>
> Reviewed-by: Harald Freudenberger <freude@linux.ibm.com>
> Signed-off-by: Finn Callies <fcallies@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260723150038.93617-2-fcallies@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-07-23 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 15:00 [PATCH v1 0/1] Fix the length of the qd field of the TAPQ response Finn Callies
2026-07-23 15:00 ` [PATCH v1 1/1] s390/ap: Fix queue depth field length Finn Callies
2026-07-23 15:13 ` sashiko-bot [this message]
2026-07-29 11:25 ` [PATCH v1 0/1] Fix the length of the qd field of the TAPQ response Vasily Gorbik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723151322.2CAE31F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=fcallies@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.