Re: [PATCH v6 45/56] scsi: qla2xxx: Fix 64G link speed reporting in get_data_rate

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete removal of the `0x7` legacy sentinel filter in `qla2x00_set_data_rate()`, causing the success debug log to be skipped when setting a 64G port speed.
--

--- Patch [45]: [PATCH v6 45/56] scsi: qla2xxx: Fix 64G link speed reporting in get_data_rate ---
commit 052c747978461ea82dcccd377a664fbb8431d087
Author: Nilesh Javali <njavali@marvell.com>

scsi: qla2xxx: Fix 64G link speed reporting in get_data_rate

qla2x00_get_data_rate() skips updating ha->link_data_rate when the
firmware returns mcp->mb[1] == 0x7. This updates the check to allow
0x07 on 64G-capable adapters while keeping the legacy filter for older ones.

Cc: stable@vger.kernel.org

> diff --git a/drivers/scsi/qla2xxx/qla_mbx.c b/drivers/scsi/qla2xxx/qla_mbx.c
> index ba822c196894b..b32ca8ed274d6 100644
> --- a/drivers/scsi/qla2xxx/qla_mbx.c
> +++ b/drivers/scsi/qla2xxx/qla_mbx.c
> @@ -5785,10 +5785,11 @@ qla2x00_get_data_rate(scsi_qla_host_t *vha)
>  		ql_dbg(ql_dbg_mbx, vha, 0x1107,
>  		    "Failed=%x mb[0]=%x.\n", rval, mcp->mb[0]);
>  	} else {
> -		if (mcp->mb[1] != 0x7)
> +		if (mcp->mb[1] != 0x7 || IS_QLA28XX(ha) || IS_QLA29XX(ha))
>  			ha->link_data_rate = mcp->mb[1];

[Severity: Low]
Since the legacy filter was updated here to allow 0x7 for 64G-capable
adapters, should the same check be updated in qla2x00_set_data_rate()?

It looks like qla2x00_set_data_rate() still retains the legacy check:

drivers/scsi/qla2xxx/qla_mbx.c:qla2x00_set_data_rate() {
    ...
	} else {
		if (mcp->mb[1] != 0x7)
			ql_dbg(ql_dbg_mbx, vha, 0x1179,
				"Speed set:0x%x\n", mcp->mb[1]);
    ...
}

Will this skip the success debug log when a 64G speed is successfully
applied on a 64G-capable adapter?

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260723050413.3897522-1-njavali@marvell.com?part=45