From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7C44F3BD63D for ; Thu, 23 Jul 2026 19:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784833318; cv=none; b=qSTBDf9HQtBrexrrP0tixnJIukGMBexYbk4T7fd9CPHvksMruhMQm9qoKm+qDChv0J9MEhnBxT2v7n29/PFkNomwjmELTUgcxfs193R21eHigCiLIfb5PXIdhFSveAsWTUQB9KSUpz3PZCRPz0Xv8ZFvUPKUIHZV8tdlzBTnIMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784833318; c=relaxed/simple; bh=dxyVUOhyUCwKQI9L9T93o4SkWNAynjxH6x7zP/jwkdo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=b9gIpeklObfhETRFIhFUg5/DbFwIjyMPnkm6kpXxoybqeHbqJoypYJlMvMo/9Xz4avu2t0qF9eKuwIGGo6+ZY0/4NMUoXU0h27uRTOPv5g7U5mbEErEV70wjpoFnq8mpoh8Vo4CRyGgDdDbrZZXzqcThsDaYEALfpjKJ5jFCvnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bU+cZsJh; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bU+cZsJh" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-47f633e6058so888015f8f.0 for ; Thu, 23 Jul 2026 12:01:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784833312; x=1785438112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=VbjSj1FJc/37XhN1xufw4wYZyGvnI/BuNwtSoHqxosQ=; b=bU+cZsJhDzFDZGSjDSJunT+vyrJ1au8u2X/xtyFjVFZQ64DgAg7VDRROtaQvfq2gpn X4CMkSMN6Z0tqAM9ItizSPsR5mPaNUk654TTSehDdN/0jzHyG1w5NlwFdispMQF93xt4 hes74hzp4Ls42+VDBTQdDoaWMPN1KTGvvCT2VyeAsjJ72Ts64WGyR5Gi6kONGIPj+je9 md/eZJCjQzZwj76TDWHvkbhMXMQwfz+EUBWbj6QAQcTHcqxiwxLuIP20bFilRXR4dMFu rvQSWkovTNIGNmhy9Agme77Q9SA/f/xss3+EZ7lPsoR7IoEWUbWeXSH4XMtkP9C63VGS 7nlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784833312; x=1785438112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=VbjSj1FJc/37XhN1xufw4wYZyGvnI/BuNwtSoHqxosQ=; b=kwGGmXYyiJwTP27EA+DqTTmaSc+1Cx9OIzJ0P1PCsfw9TP17TvYF8YJ85TJWU5Y7By IGJx+svjq5mP49cdf0l6n+xIsbKZzKXVVGnrSpqz9G6T7FbRuzOXzQPldlqcbD3kbhTA 9sJOXeoJ8+y7SKxQW4FklwlLiWZxRn/koZgzPi6MiN2ayfi7NU+eL/hOAeD1PcDIdpMX KXsAFL1Ia0YwzkujwjcfC/LhIIoXDwgV9yR74CarEymDoT0I1q0MVWSoeqRQ7ZyhZQqi O2yfv4AzDLgEvoYo1Uqvaefq9BQ4s4bNMwzpqgUZOL7zM//eVMHuTnJSb+DKe0LaqZ7u UnFA== X-Forwarded-Encrypted: i=1; AHgh+Rqpb4dwgGwfEw+9TmY2BYYZkNGQXMrtTN1cMC7rnX5xKWlGttIhiO0BO8jPJ645m15ycmOXgE5E0qvgLX0=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5rC5E1SNJXXMCPjxSHrkpVLU+h4dNFF3gqoh2ydd/vBrDoLBm uKOxmyEJJcu782V3/gfoDTAwxGOKLxhEWlrGfrUGo83bi5yqhzwDdDsD X-Gm-Gg: AR+sD11LocgnQhURQ0Lvie+9w/MOBppQcJdweAuh38fIxh9pky4vbOaPHAZg5bsR2BN Y5dKV1jQY+SwxFylsHlOh+IBm1/DuvmWZIUq7pIBHIXfvPiP1cENIosHUzYNmmoIflewvI1ngUD OkVDBwy+D8xuh0kRWHN1OkvPjS1KsHtHj9j5MobUccsE37u+yR4fdQdPs0z7JoqzvlWhCBtgjk8 yuV/xLbL/tF9/Icb4jDkxgSb8HYGS3sI0xXRoaw9XajfNSNd+AfU6nIi4tnm7I/Jd0zAAwZeV9I Z4kjnhQ9H9B7odpa5cLy/Pysx6BG941DhCL+mm9O+REr/hIdQSLrB2yvVbr6ocq5gtT6iFw5qlh cbzlJLTqNTwbL8csV6xyLBRTMCAvQsFAIrx2ATvOZDatGGYdZrJSp0Arqi1YjONf49Owrw1fzqm YodCKxtv7v30O4wGkQwjGPNXhKksCGx0u8rUgYarf919fbwY4jUlnIE08VqEajW2Gf X-Received: by 2002:a05:6000:1849:b0:47f:7e7d:eb0 with SMTP id ffacd0b85a97d-47f8d71f831mr6174123f8f.19.1784833311710; Thu, 23 Jul 2026 12:01:51 -0700 (PDT) Received: from Ansuel-XPS24.localdomain (host-87-3-249-180.retail.telecomitalia.it. [87.3.249.180]) by smtp.googlemail.com with ESMTPSA id ffacd0b85a97d-47f85b9a5d9sm16912197f8f.5.2026.07.23.12.01.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Jul 2026 12:01:50 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: Christian Marangi Subject: [PATCH 2/2] clk: en7523: add support for dedicated PCIe PERSTOUT reset Date: Thu, 23 Jul 2026 21:01:31 +0200 Message-ID: <20260723190133.22577-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260723190133.22577-1-ansuelsmth@gmail.com> References: <20260723190133.22577-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Add support for resetting the PCIe lines with the PERSTOUT reset. These special reset are controlled by the PCIC register and are specific to each of the 3 PCIe lines. Contrary to the dedicated reset register where 0 deassert and 1 assert the reset line for the related bit, for PCIe PERSTOUT reset in the PCIC register, the deassert and assert value is swapped, with 1 for deassert and 0 for assert. (HW have these bit set as 1 by default after a cold boot) This is internally handled in the reset function. PCI enable/disable are updated to drop PERSTOUT bits in favor dedicated reset handling. Signed-off-by: Christian Marangi --- drivers/clk/clk-en7523.c | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 1ab0e2eca5d3..2f53e0b42ead 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -338,6 +338,7 @@ static const struct en_clk_desc en7581_base_clks[] = { static const u16 en7581_rst_ofs[] = { REG_RST_CTRL2, REG_RST_CTRL1, + REG_NP_SCU_PCIC, }; static const u16 en751221_rst_ofs[] = { @@ -450,6 +451,11 @@ static const u16 en7581_rst_map[] = { [EN7581_CPU_TIMER_RST] = RST_NR_PER_BANK + 28, [EN7581_PCIE_HB_RST] = RST_NR_PER_BANK + 29, [EN7581_XPON_MAC_RST] = RST_NR_PER_BANK + 31, + + /* RST_PCIC */ + [EN7581_PCIC_PERSTOUT0_RST] = 2 * RST_NR_PER_BANK + 29, + [EN7581_PCIC_PERSTOUT1_RST] = 2 * RST_NR_PER_BANK + 26, + [EN7581_PCIC_PERSTOUT2_RST] = 2 * RST_NR_PER_BANK + 16, }; static const u16 en751221_rst_map[] = { @@ -635,9 +641,7 @@ static int en7581_pci_enable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val | mask, np_base + REG_PCI_CONTROL); @@ -650,9 +654,7 @@ static void en7581_pci_disable(struct clk_hw *hw) void __iomem *np_base = cg->base; u32 val, mask; - mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1 | - REG_PCI_CONTROL_PERSTOUT1 | REG_PCI_CONTROL_PERSTOUT2 | - REG_PCI_CONTROL_PERSTOUT; + mask = REG_PCI_CONTROL_REFCLK_EN0 | REG_PCI_CONTROL_REFCLK_EN1; val = readl(np_base + REG_PCI_CONTROL); writel(val & ~mask, np_base + REG_PCI_CONTROL); usleep_range(1000, 2000); @@ -754,11 +756,17 @@ static int en7523_reset_update(struct reset_controller_dev *rcdev, unsigned long id, bool assert) { struct en_rst_data *rst_data = container_of(rcdev, struct en_rst_data, rcdev); - void __iomem *addr = rst_data->base + rst_data->bank_ofs[id / RST_NR_PER_BANK]; + u32 offset = rst_data->bank_ofs[id / RST_NR_PER_BANK]; + void __iomem *addr = rst_data->base + offset; + bool inverted = false; u32 val; + /* For PCIC reset logic is inverted, 0:assert 1:deassert */ + if (offset == REG_NP_SCU_PCIC) + inverted = true; + val = readl(addr); - if (assert) + if (assert ^ inverted) val |= BIT(id % RST_NR_PER_BANK); else val &= ~BIT(id % RST_NR_PER_BANK); @@ -783,9 +791,17 @@ static int en7523_reset_status(struct reset_controller_dev *rcdev, unsigned long id) { struct en_rst_data *rst_data = container_of(rcdev, struct en_rst_data, rcdev); - void __iomem *addr = rst_data->base + rst_data->bank_ofs[id / RST_NR_PER_BANK]; + u32 offset = rst_data->bank_ofs[id / RST_NR_PER_BANK]; + void __iomem *addr = rst_data->base + offset; + bool inverted = false; + u32 val; + + /* For PCIC reset logic is inverted, 0:assert 1:deassert */ + if (offset == REG_NP_SCU_PCIC) + inverted = true; - return !!(readl(addr) & BIT(id % RST_NR_PER_BANK)); + val = readl(addr) & BIT(id % RST_NR_PER_BANK); + return inverted ? !val : !!val; } static int en7523_reset_xlate(struct reset_controller_dev *rcdev, -- 2.53.0