From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: Julia.Lawall@inria.fr,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eugen Hristev <ehristev@kernel.org>,
Vikash Garodia <vikash.garodia@oss.qualcomm.com>,
Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>,
Bryan O'Donoghue <bod@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Sylwester Nawrocki <sylvester.nawrocki@gmail.com>,
Michael Krufky <mkrufky@linuxtv.org>,
Hans Verkuil <hverkuil@kernel.org>,
cocci@inria.fr, Abhinav Kumar <abhinav.kumar@linux.dev>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 12/36] media: remove conditional return with no effect
Date: Thu, 23 Jul 2026 22:26:16 +0200 [thread overview]
Message-ID: <20260723202616.GE2273555@ragnatech.se> (raw)
In-Reply-To: <20260723184538.3888637-13-ekffu200098@gmail.com>
Hi Sang-Heon,
Thanks for your work.
On 2026-07-24 03:45:14 +0900, Sang-Heon Jeon wrote:
> Both branches of the check return the same value, so the check has
> no effect. Remove it and return the value directly.
>
> This is the result of running the Coccinelle script from
> scripts/coccinelle/misc/cond_return_no_effect.cocci.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
> ---
> drivers/media/i2c/mt9p031.c | 6 +-----
> .../media/platform/microchip/microchip-sama7g5-isc.c | 7 +------
> drivers/media/platform/qcom/iris/iris_resources.c | 6 +-----
> drivers/media/platform/qcom/venus/pm_helpers.c | 7 +------
> drivers/media/platform/renesas/rcar-csi2.c | 6 +-----
For rcar-csi2.c,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> .../media/platform/samsung/s3c-camif/camif-core.c | 7 +------
> drivers/media/usb/dvb-usb-v2/mxl111sf.c | 12 ++----------
> drivers/media/usb/gspca/jl2005bcd.c | 7 +------
> 8 files changed, 9 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c
> index d21510caf45a..2b09e8315c8e 100644
> --- a/drivers/media/i2c/mt9p031.c
> +++ b/drivers/media/i2c/mt9p031.c
> @@ -452,11 +452,7 @@ static int mt9p031_set_params(struct mt9p031 *mt9p031)
> ret = mt9p031_write(client, MT9P031_HORIZONTAL_BLANK, hblank - 1);
> if (ret < 0)
> return ret;
> - ret = mt9p031_write(client, MT9P031_VERTICAL_BLANK, vblank - 1);
> - if (ret < 0)
> - return ret;
> -
> - return ret;
> + return mt9p031_write(client, MT9P031_VERTICAL_BLANK, vblank - 1);
> }
>
> static int mt9p031_s_stream(struct v4l2_subdev *subdev, int enable)
> diff --git a/drivers/media/platform/microchip/microchip-sama7g5-isc.c b/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> index b0302dfc3278..7383341ec51d 100644
> --- a/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> +++ b/drivers/media/platform/microchip/microchip-sama7g5-isc.c
> @@ -598,13 +598,8 @@ static int __maybe_unused xisc_runtime_suspend(struct device *dev)
> static int __maybe_unused xisc_runtime_resume(struct device *dev)
> {
> struct isc_device *isc = dev_get_drvdata(dev);
> - int ret;
> -
> - ret = clk_prepare_enable(isc->hclock);
> - if (ret)
> - return ret;
>
> - return ret;
> + return clk_prepare_enable(isc->hclock);
> }
>
> static const struct dev_pm_ops microchip_xisc_dev_pm_ops = {
> diff --git a/drivers/media/platform/qcom/iris/iris_resources.c b/drivers/media/platform/qcom/iris/iris_resources.c
> index 773f6548370a..872bd09656b1 100644
> --- a/drivers/media/platform/qcom/iris/iris_resources.c
> +++ b/drivers/media/platform/qcom/iris/iris_resources.c
> @@ -78,11 +78,7 @@ int iris_enable_power_domains(struct iris_core *core, struct device *pd_dev)
> if (ret)
> return ret;
>
> - ret = pm_runtime_get_sync(pd_dev);
> - if (ret < 0)
> - return ret;
> -
> - return ret;
> + return pm_runtime_get_sync(pd_dev);
> }
>
> int iris_disable_power_domains(struct iris_core *core, struct device *pd_dev)
> diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c
> index be1cbd5cfe84..e88e66be4f6d 100644
> --- a/drivers/media/platform/qcom/venus/pm_helpers.c
> +++ b/drivers/media/platform/qcom/venus/pm_helpers.c
> @@ -781,7 +781,6 @@ static int decide_core(struct venus_inst *inst)
> unsigned long max_freq = ULONG_MAX;
> struct device *dev = core->dev;
> struct dev_pm_opp *opp;
> - int ret = 0;
>
> if (legacy_binding) {
> if (inst->session_type == VIDC_SESSION_TYPE_DEC)
> @@ -829,11 +828,7 @@ static int decide_core(struct venus_inst *inst)
> }
>
> done:
> - ret = hfi_session_set_property(inst, ptype, &cu);
> - if (ret)
> - return ret;
> -
> - return ret;
> + return hfi_session_set_property(inst, ptype, &cu);
> }
>
> static int acquire_core(struct venus_inst *inst)
> diff --git a/drivers/media/platform/renesas/rcar-csi2.c b/drivers/media/platform/renesas/rcar-csi2.c
> index 7305cc4a04cb..6635f5782175 100644
> --- a/drivers/media/platform/renesas/rcar-csi2.c
> +++ b/drivers/media/platform/renesas/rcar-csi2.c
> @@ -2273,11 +2273,7 @@ static int rcsi2_init_phtw_v3u(struct rcar_csi2 *priv,
> return ret;
> }
>
> - ret = rcsi2_phtw_write_array(priv, step4, ARRAY_SIZE(step4));
> - if (ret)
> - return ret;
> -
> - return ret;
> + return rcsi2_phtw_write_array(priv, step4, ARRAY_SIZE(step4));
> }
>
> /* -----------------------------------------------------------------------------
> diff --git a/drivers/media/platform/samsung/s3c-camif/camif-core.c b/drivers/media/platform/samsung/s3c-camif/camif-core.c
> index 14eedd1ceb27..bb06847f3a63 100644
> --- a/drivers/media/platform/samsung/s3c-camif/camif-core.c
> +++ b/drivers/media/platform/samsung/s3c-camif/camif-core.c
> @@ -301,7 +301,6 @@ static int camif_media_dev_init(struct camif_dev *camif)
> struct media_device *md = &camif->media_dev;
> struct v4l2_device *v4l2_dev = &camif->v4l2_dev;
> unsigned int ip_rev = camif->variant->ip_revision;
> - int ret;
>
> memset(md, 0, sizeof(*md));
> snprintf(md->model, sizeof(md->model), "Samsung S3C%s CAMIF",
> @@ -316,11 +315,7 @@ static int camif_media_dev_init(struct camif_dev *camif)
>
> media_device_init(md);
>
> - ret = v4l2_device_register(camif->dev, v4l2_dev);
> - if (ret < 0)
> - return ret;
> -
> - return ret;
> + return v4l2_device_register(camif->dev, v4l2_dev);
> }
>
> static void camif_clk_put(struct camif_dev *camif)
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> index 870ac3c8b085..6404eb74db32 100644
> --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> @@ -987,11 +987,7 @@ static int mxl111sf_frontend_attach_atsc_mh(struct dvb_usb_adapter *adap)
> if (ret < 0)
> return ret;
>
> - ret = mxl111sf_lg2160_frontend_attach(adap, 2);
> - if (ret < 0)
> - return ret;
> -
> - return ret;
> + return mxl111sf_lg2160_frontend_attach(adap, 2);
> }
>
> static int mxl111sf_frontend_attach_mercury(struct dvb_usb_adapter *adap)
> @@ -1007,11 +1003,7 @@ static int mxl111sf_frontend_attach_mercury(struct dvb_usb_adapter *adap)
> if (ret < 0)
> return ret;
>
> - ret = mxl111sf_lg2161_ep6_frontend_attach(adap, 2);
> - if (ret < 0)
> - return ret;
> -
> - return ret;
> + return mxl111sf_lg2161_ep6_frontend_attach(adap, 2);
> }
>
> static int mxl111sf_frontend_attach_mercury_mh(struct dvb_usb_adapter *adap)
> diff --git a/drivers/media/usb/gspca/jl2005bcd.c b/drivers/media/usb/gspca/jl2005bcd.c
> index a408fcc3a060..4988fbf5005e 100644
> --- a/drivers/media/usb/gspca/jl2005bcd.c
> +++ b/drivers/media/usb/gspca/jl2005bcd.c
> @@ -148,17 +148,12 @@ static int jl2005c_start_new_frame(struct gspca_dev *gspca_dev)
> static int jl2005c_write_reg(struct gspca_dev *gspca_dev, unsigned char reg,
> unsigned char value)
> {
> - int retval;
> u8 instruction[2];
>
> instruction[0] = reg;
> instruction[1] = value;
>
> - retval = jl2005c_write2(gspca_dev, instruction);
> - if (retval < 0)
> - return retval;
> -
> - return retval;
> + return jl2005c_write2(gspca_dev, instruction);
> }
>
> static int jl2005c_get_firmware_id(struct gspca_dev *gspca_dev)
> --
> 2.43.0
>
--
Kind Regards,
Niklas Söderlund
next prev parent reply other threads:[~2026-07-23 20:26 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 18:45 [PATCH 00/36] treewide: remove conditional returns with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [Intel-wired-lan] " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 01/36] coccinelle: misc: add cond_return_no_effect.cocci Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 02/36] drm/amd: remove conditional return with no effect Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 03/36] drm/radeon: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 04/36] dpll: zl3073x: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 05/36] drm/i915: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 06/36] drm: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 07/36] net: ethernet: " Sang-Heon Jeon
2026-07-23 20:24 ` Niklas Söderlund
2026-07-23 20:35 ` Kiyanovski, Arthur
2026-07-23 18:45 ` [PATCH 08/36] net: " Sang-Heon Jeon
2026-07-23 19:04 ` Andrew Lunn
2026-07-23 18:45 ` [Intel-wired-lan] [PATCH 09/36] net: intel: " Sang-Heon Jeon
2026-07-23 18:45 ` Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 10/36] wifi: " Sang-Heon Jeon
2026-07-24 0:37 ` Ping-Ke Shih
2026-07-23 18:45 ` [PATCH 11/36] ipvs: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 12/36] media: " Sang-Heon Jeon
2026-07-23 20:26 ` Niklas Söderlund [this message]
2026-07-23 18:45 ` [PATCH 13/36] ALSA: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 14/36] ASoC: " Sang-Heon Jeon
2026-07-24 5:05 ` Mukunda,Vijendar
2026-07-23 18:45 ` [PATCH 15/36] iio: " Sang-Heon Jeon
2026-07-23 21:46 ` Joshua Crofts
2026-07-24 0:38 ` Jonathan Cameron
2026-07-23 18:45 ` [PATCH 16/36] Input: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 17/36] clk: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 18/36] crypto: drivers - " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 19/36] dmaengine: qcom_hidma: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 20/36] stm class: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 21/36] RDMA/ocrdma: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 22/36] iommu/s390: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 23/36] dm vdo: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 24/36] pinctrl: mediatek: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 25/36] platform/x86: toshiba_haps: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 26/36] power: supply: pm8916_lbc: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 27/36] RAS/AMD/ATL: " Sang-Heon Jeon
2026-07-23 19:44 ` Borislav Petkov
2026-07-23 18:45 ` [PATCH 28/36] regulator: wm831x-isink: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 29/36] rtc: pcf2127: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 30/36] scsi: mpt3sas: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 31/36] thermal/drivers/k3_bandgap: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 32/36] USB: serial: ch341: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 33/36] usb: typec: fusb302: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 34/36] smb: client: " Sang-Heon Jeon
2026-07-23 20:27 ` Steve French
2026-07-23 18:45 ` [PATCH 35/36] cpupower: " Sang-Heon Jeon
2026-07-23 18:45 ` [PATCH 36/36] memblock: " Sang-Heon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723202616.GE2273555@ragnatech.se \
--to=niklas.soderlund@ragnatech.se \
--cc=Julia.Lawall@inria.fr \
--cc=abhinav.kumar@linux.dev \
--cc=bod@kernel.org \
--cc=cocci@inria.fr \
--cc=dikshita.agarwal@oss.qualcomm.com \
--cc=ehristev@kernel.org \
--cc=ekffu200098@gmail.com \
--cc=geert+renesas@glider.be \
--cc=hverkuil@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=sakari.ailus@linux.intel.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=vikash.garodia@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.