From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f197.google.com (mail-pg1-f197.google.com [209.85.215.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56FB03F3266 for ; Thu, 23 Jul 2026 21:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784840905; cv=none; b=Ls/YrOPV2M5/79PT3sggiQrzILWKLC9O7ILh7loYfzbRcEWQGamneF6qxLpNmf5ao1jb1bZ72E9nlE88cyA5eALbbEFA76m2NAvrjkY5CNI+nNlEdxLT1cq/1uFjG5pPSn1n2E5T3+9I3OqcSjyzg2+H+DEqs3dwFXm93HOjIyA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784840905; c=relaxed/simple; bh=LljWRFUKb6b8P53VSK2dy8jrpSiFxDei2TKifqh5AZk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Mkk3aSOZv6EMq1h5IfLgF8DaV5BMKGG1hN6XoZl6/KGt24dJ52SR9buY954aTaEAcrIInYq4yhnhQg0vKTs+VhH1zjWsVkQ4SbsP5dK0VjlZYpxD7SvDEutmfeekQ3KG8XMBDWadX8GCQLc+1NWFtjLP6JltNyXnzkajHdHngxA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=rm7SvqAC; arc=none smtp.client-ip=209.85.215.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="rm7SvqAC" Received: by mail-pg1-f197.google.com with SMTP id 41be03b00d2f7-cb11535e6a1so985299a12.0 for ; Thu, 23 Jul 2026 14:08:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784840897; x=1785445697; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:from:to:cc:subject:date:message-id :reply-to:content-type; bh=fbwF6vr/AOTW7Vn1a0v89zwGTRmaPYHRuV1v74U/8hY=; b=rm7SvqACJnm73fOfx2fHpCKKV24BxWiWPI5zs4xZQtyfPvKob3YETVXUgMaC8Uem/i 65E+h5749uVYPSW1H/IWud/Yz7+UXX2b9od4iEQuPdartpsfYGosUI9SWgt4Kw2odRFN ImWfHTTVuU7WAzSmllm+dggRi+froCMucB3sFixAn/8mzHmQzQzRozYTI10gpEkACTRP Hr7OIy7PPjQ6aIThEJFAKB2aLDWY5ARjxAlYcGXmPg/c8TZ4TCWMhUxmvOXoUE8IVIik NPuKQptPsct4J1AeTMwWMWnQmXmF1EFwZREU6P5t15qKZzZLpedaKlloAKbRGCphXnqa wx8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784840897; x=1785445697; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:reply-to:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=fbwF6vr/AOTW7Vn1a0v89zwGTRmaPYHRuV1v74U/8hY=; b=dpGok3kZpxYs50uECCGA2CcEy/OY73s9fSezJHE4RLCx8mVjATC0C3xbNkhnKrKkge Ir7kbyj0KKhrM0WHBk0Evxz19BgyTQmzDgMA8TpocU0HIftSji721fdyhYZ3OYYyFGAp /iYIuAm/746qXWFtXPWGOtRDiJOsJ57GDxfXdUVY9/tI4sj5urf+baia3WxdxgkPWF/i c518VBNIgwc/kFcbCmJyfT0Ho4prAoXAYk6gqeQOrkXARy5C8sSa+XjOtKyeotpz/3qh xXL6d7ruWaLzKYYHsnexPqUnzOc6ZDDF+bnjvusA4CDrTFhlTKMoXdg3SRYWMx/P18he CgdQ== X-Forwarded-Encrypted: i=1; AHgh+RrsOXTZQRKTK/1hAJcVcctTjAIx7m6dg9Z6tPtR5S8QowpuAwDkPvcWb740kxFK+m83+CvU2nq01iLuZJE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4t9XEF0w2RZXEb3XGddxW6bP+JOL20iroWRdG7E58KiTh55px obmfaNWOz5yUjFSJjqpyvpVQjo6uMdk9vwe4SRZBc5zykaIFjGpilH116qkHt+FEelYhyEKWLyA bVgiwsw== X-Received: from pfeu4-n1.prod.google.com ([2002:a05:6a00:c0c4:10b0:848:2a35:eb83]) (user=seanjc job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:b902:b0:848:2c6c:dfc0 with SMTP id d2e1a72fcca58-84e2b898e78mr5346341b3a.24.1784840896735; Thu, 23 Jul 2026 14:08:16 -0700 (PDT) Reply-To: Sean Christopherson Date: Thu, 23 Jul 2026 14:08:06 -0700 In-Reply-To: <20260723210811.72720-1-seanjc@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260723210811.72720-1-seanjc@google.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Message-ID: <20260723210811.72720-5-seanjc@google.com> Subject: [PATCH v6 4/9] KVM: guest_memfd: Drop the redundant printk on arch gmem_prepare() failure From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Fuad Tabba , Ackerley Tng , Xiaoyao Li , Michael Roth , Fuad Tabba Content-Type: text/plain; charset="UTF-8" Drop guest_memfd's ratelimited printk to log "preparation" failures, as KVM SNP already logs more precise messages in all error paths, and whether or not failure to convert the pfn to private is "unexpected", i.e. warrants logging, is firmly an architecture specific detail. Reviewed-by: Ackerley Tng Reviewed-by: Xiaoyao Li Reviewed-by: Fuad Tabba Signed-off-by: Sean Christopherson --- virt/kvm/guest_memfd.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/virt/kvm/guest_memfd.c b/virt/kvm/guest_memfd.c index b5272645a98d..2effff582f50 100644 --- a/virt/kvm/guest_memfd.c +++ b/virt/kvm/guest_memfd.c @@ -66,15 +66,11 @@ static int __kvm_gmem_prepare_folio(struct kvm *kvm, struct kvm_memory_slot *slo #ifdef CONFIG_HAVE_KVM_ARCH_GMEM_PREPARE kvm_pfn_t pfn = folio_file_pfn(folio, index); gfn_t gfn = slot->base_gfn + index - slot->gmem.pgoff; - int rc = kvm_arch_gmem_prepare(kvm, gfn, pfn, folio_order(folio)); - if (rc) { - pr_warn_ratelimited("gmem: Failed to prepare folio for index %lx GFN %llx PFN %llx error %d.\n", - index, gfn, pfn, rc); - return rc; - } -#endif + return kvm_arch_gmem_prepare(kvm, gfn, pfn, folio_order(folio)); +#else return 0; +#endif } /* -- 2.55.0.229.g6434b31f56-goog