From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Adi Nata <adinata.softwareengineer@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, mazziesaccount@gmail.com, email@sirat.me,
u.kleine-koenig@baylibre.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linux.dev
Subject: Re: [PATCH] iio: chemical: cleanup codestyle warning
Date: Thu, 23 Jul 2026 23:53:12 +0200 [thread overview]
Message-ID: <20260723235312.432a895c@systembl0wer> (raw)
In-Reply-To: <20260723235139.02fdab3f@systembl0wer>
On Thu, 23 Jul 2026 23:51:39 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:
> On Fri, 24 Jul 2026 00:10:38 +0800
> Adi Nata <adinata.softwareengineer@gmail.com> wrote:
>
> > Reported by checkpatch:
> > FILE: drivers/iio/chemical/ccs811.c
> >
> > WARNING: Prefer __packed over __attribute__((__packed__))
> > +} __attribute__((__packed__));
>
> Perhaps a nit, but I'd change the commit title to "prefer __packed"
> and the commit message to something like:
>
> "Change instance of __attribute__((__packed__)) to __packed per
> checkpatch.pl warning.
>
> Other than that:
>
> Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Additionally, you're missing the driver name in the subject/commit
message, it should be something like "iio: chemical: ccs811: prefer __packed"
--
Kind regards,
Joshua Crofts
prev parent reply other threads:[~2026-07-23 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 16:10 [PATCH] iio: chemical: cleanup codestyle warning Adi Nata
2026-07-23 21:51 ` Joshua Crofts
2026-07-23 21:53 ` Joshua Crofts [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260723235312.432a895c@systembl0wer \
--to=joshua.crofts1@gmail.com \
--cc=adinata.softwareengineer@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=email@sirat.me \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=nuno.sa@analog.com \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.