Re: [RFC PATCH v2 1/3] error-injection: Introduce EI_ETYPE_FALSE for fail_function

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new EI_ETYPE_FALSE error injection type is missing string mapping in lib/error-inject.c and documentation updates, causing debugfs to report '(unknown)'.
--

--- Patch [1]: [RFC PATCH v2 1/3] error-injection: Introduce EI_ETYPE_FALSE for fail_function ---
commit 5374b818d585ee0b9130e232537545cf0e64070a
Author: Song Chen <chensong_2000@126.com>

error-injection: Introduce EI_ETYPE_FALSE for fail_function

This commit introduces a new error injection type, EI_ETYPE_FALSE. It is
intended for functions that require false as a return value during error
injection, such as btrfs_data_csum_ok.

> diff --git a/include/asm-generic/error-injection.h b/include/asm-generic/error-injection.h
> index b05253f68eaa5..6c399121ab7ab 100644
> --- a/include/asm-generic/error-injection.h
> +++ b/include/asm-generic/error-injection.h
> @@ -8,6 +8,7 @@ enum {
>  	EI_ETYPE_ERRNO,		/* Return -ERRNO if failure */
>  	EI_ETYPE_ERRNO_NULL,	/* Return -ERRNO or NULL if failure */
>  	EI_ETYPE_TRUE,		/* Return true if failure */
> +	EI_ETYPE_FALSE,		/* Return false if failure */

[Severity: Medium]
Does this commit miss updating error_type_string() in lib/error-inject.c to
handle the new type?

Currently, error_type_string() maps the other enum values to strings, but
without an update here it appears it will fall through to the default case:

lib/error-inject.c:error_type_string() {
	...
	case EI_ETYPE_TRUE:
		return "TRUE";
	default:
		return "(unknown)";
}

Won't this cause functions annotated with ALLOW_ERROR_INJECTION(..., FALSE)
to display as '(unknown)' in the /sys/kernel/debug/error_injection/list
debugfs file?

Also, should Documentation/fault-injection/fault-injection.rst be updated to
document EI_ETYPE_FALSE alongside EI_ETYPE_TRUE?

>  };
>  
>  struct error_injection_entry {

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724021229.47302-1-chensong_2000@126.com?part=1