All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ibrahim Hashimov <security@auditcode.ai>
To: hexlabsecurity@proton.me
Cc: dust.li@linux.alibaba.com, alibuda@linux.alibaba.com,
	wenjia@linux.ibm.com, tonylu@linux.alibaba.com,
	guwen@linux.alibaba.com, netdev@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-s390@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net/smc: validate peer CDC cursor against RMBE size before accepting it
Date: Fri, 24 Jul 2026 09:21:17 +0200	[thread overview]
Message-ID: <20260724072117.73038-1-security@auditcode.ai> (raw)
In-Reply-To: <20260723230647.138311-1-hexlabsecurity@proton.me>

> The insight is yours either way -- may I add your Suggested-by (or
> Co-developed-by)?

Please do, and thanks for running it end to end. Suggested-by is the
honest one -- I pointed at the gap and the advance-bound, you did the
series. If you carry the

	if (smc_curs_diff(size, &old, &temp) > size)
		return;

verbatim, Co-developed-by is fine too, your call. Either way:

	Ibrahim Hashimov <security@auditcode.ai>

And your split is right -- advance-bound as the early catch, bytes_to_rcv
after the atomic_add for the accumulation the per-cursor check can't see.

Thanks,
Ibrahim

      reply	other threads:[~2026-07-24  7:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 17:07 [PATCH net] net/smc: validate peer CDC cursor against RMBE size before accepting it Ibrahim Hashimov
2026-07-21 17:08 ` sashiko-bot
2026-07-22  3:47 ` Dust Li
2026-07-22 10:29   ` Ibrahim Hashimov
2026-07-23 23:06     ` Bryam Vargas
2026-07-24  7:21       ` Ibrahim Hashimov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724072117.73038-1-security@auditcode.ai \
    --to=security@auditcode.ai \
    --cc=alibuda@linux.alibaba.com \
    --cc=dust.li@linux.alibaba.com \
    --cc=guwen@linux.alibaba.com \
    --cc=hexlabsecurity@proton.me \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tonylu@linux.alibaba.com \
    --cc=wenjia@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.