All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guixin Liu <kanie@linux.alibaba.com>
To: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Nilay Shroff <nilay@linux.ibm.com>,
	Daniel Wagner <dwagner@suse.de>,
	John Garry <john.g.garry@oracle.com>
Cc: linux-nvme@lists.infradead.org
Subject: [PATCH v4 0/2] nvme-multipath: expose path_state via sysfs
Date: Fri, 24 Jul 2026 17:00:02 +0800	[thread overview]
Message-ID: <20260724090004.1146014-1-kanie@linux.alibaba.com> (raw)

This series adds a read-only "path_state" sysfs attribute to each NVMe
multipath path namespace device (/sys/block/nvmeXcYnZ/path_state), giving
userspace visibility into whether a path is currently usable for I/O and,
if not, the reason it is disabled.

Today users have to piece this together from the controller state and
various namespace flags. The new attribute reports the path selection
state directly, and is kept in sync with the path selection logic by
sharing a single nvme_path_get_state() helper.

Patch 1 adds the attribute and the helper; patch 2 documents it in the
stable NVMe sysfs ABI file.

Changes since v3:
- Use single-token sysfs values ("enabled", "ctrl-down", "ana-pending",
  "ns-not-ready") instead of the composite "disabled (reason)" and
  "enabled (optimized)/(non-optimized)" strings, following the sysfs
  convention of exporting one simple value per attribute.
- Drop the "enabled (optimized)" vs "enabled (non-optimized)"
  distinction; the ANA access state is already exposed through the
  existing per-path ana_state attribute.
- Add a second patch documenting path_state in the stable NVMe sysfs
  ABI (Documentation/ABI/stable/sysfs-nvme).

Changes since v2:
- Factor path disable checks into nvme_path_get_state() helper returning
  enum nvme_path_state, and rebuild nvme_path_is_disabled() on top of it
  to keep path selection logic and sysfs reporting in sync. (Nilay Shroff)
- Distinguish "enabled (optimized)" vs "enabled (non-optimized)" based on
  ANA state. (Keith Busch)

Changes since v1:
- Show specific disabled reason instead of just "disabled":
  "disabled (ctrl_down)", "disabled (ana_pending)",
  "disabled (ns_not_ready)". (Nilay Shroff)

Guixin Liu (2):
  nvme-multipath: expose path_state via sysfs
  nvme-multipath: document path_state sysfs attribute

 Documentation/ABI/stable/sysfs-nvme | 21 +++++++++++++
 drivers/nvme/host/multipath.c       | 47 +++++++++++++++++++++++++----
 drivers/nvme/host/nvme.h            |  1 +
 drivers/nvme/host/sysfs.c           |  4 ++-
 4 files changed, 66 insertions(+), 7 deletions(-)


base-commit: 7caaa4120d8dd73bb251410e1d007b4131d024c4
-- 
2.43.7



             reply	other threads:[~2026-07-24  9:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-24  9:00 Guixin Liu [this message]
2026-07-24  9:00 ` [PATCH v4 1/2] nvme-multipath: expose path_state via sysfs Guixin Liu
2026-07-24  9:00 ` [PATCH v4 2/2] nvme-multipath: document path_state sysfs attribute Guixin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724090004.1146014-1-kanie@linux.alibaba.com \
    --to=kanie@linux.alibaba.com \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=hch@lst.de \
    --cc=john.g.garry@oracle.com \
    --cc=kbusch@kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.