From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2D26D41DED2 for ; Fri, 24 Jul 2026 09:44:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886273; cv=none; b=CAdEBYYbABqEROPsoIaQukuNgC70Zkido6ygCnflTJiMGIb5I8ZnpiXjF0KfC2lu+tBcurpEfq8iUhR2P/XFSKxnNAAacgIZTFSr5QORXiYwjUgrLwNFRkMyoFIFim9/xth4ctoO6QkphRShV/FzHpR+rqbt3/I0dsPQwtGkYRE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784886273; c=relaxed/simple; bh=eR7+Xd+VqrkaMibHzXeZvPDiNxOe5G2DypMol5wF6h8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References; b=k92obSatrR8YTwmH4ckBj7ww63XAVi8bsM+b8VLzBnxramipUSe3ghEw3XKeq7H/4LChdnjE6MY86DBjbEDYRj4BMOAZh2KxJg9vNQnAhARRKp1bIqpYOhqQebNcRd7aVqlcLfMB6bYF3lLtL0qoCe5MKMXTuDlXH+ETH1dSXP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sSGVNfXw; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sSGVNfXw" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-69e28b554ceso383155a12.0 for ; Fri, 24 Jul 2026 02:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784886270; x=1785491070; darn=vger.kernel.org; h=references:in-reply-to:message-id:date:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=Be81MoWCkWbNVBXpOEfawVOZ99FwymP5loMauubaj34=; b=sSGVNfXwpQGBxPQJGcfq857SW2QkNaGGtuegVnMWyDQe9sqvjgKGuu74bg5hBGlhJh jUtyunalYBvk/IZVAPnr4SEQcDx07zPMNli0cg2jNe7eSbhdeOP8ua6WPbpuX5Z6b6ay BmwtTrFoXfLQQr/2UbRm/N4ndmrJWGVELKP5NS+FRBnRW11ZrS1PZ6U2xRpi0VoqD1aC riadr9QP+VkaAfKZTKKY9jhJnlU2dNmyMeOR4ertAWWhtfbYhqkzUyaP97OkO0q6B96u pCagqUPbb9Eo9fi/nmTsUt2WTVFu6pxHnGvzVyd+pbCWrJbYU5w2o9wbnhd60x5NeSoz TQzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784886270; x=1785491070; h=references:in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Be81MoWCkWbNVBXpOEfawVOZ99FwymP5loMauubaj34=; b=KKuFFgD0U4SBAATV78QiB9LbgYtgpUkYmGmLxq7GbPAzoIWBR1K1874sRFqD5KIbPg TYDBJ7+zMGPeQJK1PnO+5KHH8Hb5yJumVAFlPEfoT0WVfQbEdP+UyJ+c229KWlzoXDvL tuDK5YucTWcpYt4/C1bFz20ftxGKWO1skgrZjq/27qhVdZbPaPa/X6VM14G2vUt9bfVI E9+PoObCe2muPzSYZsitdO7fDRN8rlcDBNecyPCxkHhagYBKIUFRc4qtc4kUfKUDN7IS memkBXN8jrkHRytQGUMEs5Mmvsxa/CByUQrOAn7hxjY3D0sDaAUXmRwtiHK8zojXDaGl 9gsg== X-Forwarded-Encrypted: i=1; AHgh+RruF+SrPusDNaLU77XJRg7s+Vpo7XmTPzXeiJFY8nLryV3KfxI3dZXQeixkfu6O78jV6fmzg6jqBOxKvvI=@vger.kernel.org X-Gm-Message-State: AOJu0YxOrx+SKecG4PD/Rc10bDAWsQYs1t0U5V+zuUEaRueIVFN+KXIY U4BodoEjHVxs+bkaEJkvK88+Z7593EvhHZlXsHVKyuEcTV6r0Ghe3BK9 X-Gm-Gg: AR+sD11XwbWTVIvBxtp1rt+ihE1SWlYC3mcEGolmwjnHdEmkX68uEhGd1LkdCoXWB2I UBzPxYzQ0T2qeM1p2jW0eC/0vb/GIXVFvLoXw4INAo1QJR/MIcUcAnmhcPetbSEAeTfokAWaD8B g1RQ1FUM/XEFpxI4wC4dh0HIWr/6+jBbEIj5VAm2sK7Ju5AYii1gwNadk7A6orS3WOr/JGy4c3i Mgi+XlMiB8bdf14gSjBjNLVKwcoQv9RLq9FJtAZ3xOIB1YLOdaHDvu3Kx8z5ixUsmwcSQyHaryq woxGL4EsWGuMsiJt/pddmg4y8edIvRN/G/Xy9DLqRBYJxuWLRDZZxBMyeiyKc6peObGY2w4uTxE B2IHmBfNsat8XkEAx1LPPng7HIkOJA+qrpSCxinwdUPjoRKoVj0b4M0amZT2HLFZ3oMS9EzqLJP nEH2w9PXvm/uQC2LIQdRdhJBn2gPfKvg== X-Received: by 2002:a17:906:730f:b0:c15:b133:9dfe with SMTP id a640c23a62f3a-c1c50c401c6mr310536966b.43.1784886269898; Fri, 24 Jul 2026 02:44:29 -0700 (PDT) Received: from localhost (c-85-228-45-68.bbcust.telenor.se. [85.228.45.68]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1c32a76fecsm330490866b.8.2026.07.24.02.44.29 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Jul 2026 02:44:29 -0700 (PDT) From: Eli Billauer To: gregkh@linuxfoundation.org Cc: arnd@arndb.de, linux-kernel@vger.kernel.org, corbet@lwn.net, Eli Billauer Subject: [PATCH v3 5/7] char: xillybus: Integer arithmetic improvements Date: Fri, 24 Jul 2026 11:43:00 +0200 Message-Id: <20260724094302.50761-6-eli.billauer@gmail.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20260724094302.50761-1-eli.billauer@gmail.com> References: <20260724094302.50761-1-eli.billauer@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Choose unsigned integers instead of signed where natural, and also ensure overflow wraps as expected. Simplify an arithmetic expression too. No functional change is expected, as the relevant variables normally never reach values where this transition matters. Assisted-by: Deepseek:v4-pro Kimi:K2.6 ChatGPT:GPT-5.5 Claude:Sonnet-4.6 Signed-off-by: Eli Billauer --- Notes: Changes v2->v3: -- Add Assisted-by tag to description No change on v1->v2. drivers/char/xillybus/xillybus_core.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/char/xillybus/xillybus_core.c b/drivers/char/xillybus/xillybus_core.c index 7acebc1e6050..b264578b2572 100644 --- a/drivers/char/xillybus/xillybus_core.c +++ b/drivers/char/xillybus/xillybus_core.c @@ -343,7 +343,8 @@ static int xilly_map_single(struct xilly_endpoint *ep, static int xilly_get_dma_buffers(struct xilly_endpoint *ep, struct xilly_alloc_state *s, struct xilly_buffer **buffers, - int bufnum, int bytebufsize) + unsigned int bufnum, + unsigned int bytebufsize) { int i, rc; dma_addr_t dma_addr; @@ -431,8 +432,8 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, struct device *dev = ep->dev; int i, entry, rc; struct xilly_channel *channel; - int channelnum, bufnum, bufsize, format, is_writebuf; - int bytebufsize; + unsigned int channelnum, bufnum, bufsize, format, is_writebuf; + unsigned int bytebufsize; int synchronous, allowpartial, exclusive_open, seekable; int supports_nonempty; int msg_buf_done = 0; @@ -531,8 +532,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, channel->log2_element_size = ((format > 2) ? 2 : format); - bytebufsize = bufsize * - (1 << channel->log2_element_size); + bytebufsize = bufsize << channel->log2_element_size; buffers = devm_kcalloc(dev, bufnum, sizeof(struct xilly_buffer *), @@ -589,7 +589,7 @@ static int xilly_setupchannels(struct xilly_endpoint *ep, static int xilly_scan_idt(struct xilly_endpoint *endpoint, struct xilly_idt_handle *idt_handle) { - int count = 0; + unsigned int count = 0; unsigned char *idt = endpoint->channels[1]->wr_buffers[0]->addr; unsigned char *end_of_idt = idt + endpoint->idtlen - 4; unsigned char *scan; -- 2.34.1