Re: [PATCH v7 14/19] dt-bindings: dma: ti: Add K3 PKTDMA V2

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The `#dma-cells` documentation describing TX/RX flow index interleaving directly contradicts the `interrupt-names` example.
--

--- Patch [14]: [PATCH v7 14/19] dt-bindings: dma: ti: Add K3 PKTDMA V2 ---
commit 1ae599a55fbde375545e0e61dca9e77cb2c44acc
Author: Sai Sree Kartheek Adivi <s-adivi@ti.com>

dt-bindings: dma: ti: Add K3 PKTDMA V2

This commit adds a new device tree binding document for Texas Instruments
K3 Packet DMA (PKTDMA) V2. PKTDMA V2 is introduced as part of AM62L.

> diff --git a/Documentation/devicetree/bindings/dma/ti/ti,am62l-dmss-pktdma.yaml b/Documentation/devicetree/bindings/dma/ti/ti,am62l-dmss-pktdma.yaml
> new file mode 100644
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/ti/ti,am62l-dmss-pktdma.yaml
[ ... ]
> +  "#dma-cells":
> +    const: 2
> +    description: |
> +      cell 1: Flow ID for the peripheral
> +        This is the hardware flow index assigned to the peripheral. TX flows
> +        use even indices and RX flows use odd indices in an interleaved
> +        manner. For XYMF peripherals (SPI, CRC32) each chip-select/FIFO has

[Severity: Low]
Is this description for the TX and RX flow indices correct? The text states
that TX flows use even indices and RX flows use odd indices in an
interleaved manner, but the example below contradicts this.

[ ... ]
> +        interrupt-names = "rflow0", "tflow1", "rflow2", "tflow3", "rflow4",
> +                          "tflow5", "rflow6", "tflow7", "rflow8", "tflow9",

[Severity: Low]
The example shows RX flows using even indices (e.g., rflow0, rflow2) and TX
flows using odd indices (e.g., tflow1, tflow3).

Additionally, the interleaving appears to be abandoned for higher indices
later in this array, which shows contiguous blocks for TX (flows 64-79) and
RX (flows 96-111).

Could the description for #dma-cells be updated to accurately reflect the
actual hardware flow mapping shown here?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724102115.2854-1-s-adivi@ti.com?part=14