From: sashiko-bot@kernel.org
To: "Ciunas Bennett" <ciunas@linux.ibm.com>
Cc: "Heiko Carstens" <hca@linux.ibm.com>,
linux-s390@vger.kernel.org,
"Alexander Gordeev" <agordeev@linux.ibm.com>,
"Vasily Gorbik" <gor@linux.ibm.com>
Subject: Re: [PATCH v3 1/2] s390/kvm: Refactor __diag_time_slice_end_directed for single exit point
Date: Fri, 24 Jul 2026 11:07:52 +0000 [thread overview]
Message-ID: <20260724110752.DF8FF1F031E2@smtp.kernel.org> (raw)
In-Reply-To: <20260724103959.14861-2-ciunas@linux.ibm.com>
> Refactor the DIAG 9c (directed yield) handler to use a unified exit path,
> improving code maintainability and reducing duplication.
> Changes:
> - Consolidate all exit paths to use a single 'out' label
> - Replace multiple VCPU_EVENT logging calls with one unified call
> - Introduce 'result' string variable to track operation outcome
> - Initialize tcpu_cpu to -1 for safe handling across all code paths
> - Ensure statistics updates occur before the common exit point
>
> This refactoring maintains identical functionality while making the control
> flow clearer and easier to maintain. All three possible outcomes (yield
> forwarded, done, ignored) now converge at a single logging point
>
> Signed-off-by: Ciunas Bennett <ciunas@linux.ibm.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260724103959.14861-1-ciunas@linux.ibm.com?part=1
next prev parent reply other threads:[~2026-07-24 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 10:39 [PATCH v3 0/2] Improve DIAG 9c observability Ciunas Bennett
2026-07-24 10:39 ` [PATCH v3 1/2] s390/kvm: Refactor __diag_time_slice_end_directed for single exit point Ciunas Bennett
2026-07-24 11:07 ` sashiko-bot [this message]
2026-07-24 12:10 ` Christian Borntraeger
2026-07-24 10:39 ` [PATCH v3 2/2] s390/kvm: Add tracepoint for DIAG 9c directed yield operations Ciunas Bennett
2026-07-24 11:05 ` sashiko-bot
2026-07-24 12:18 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724110752.DF8FF1F031E2@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agordeev@linux.ibm.com \
--cc=ciunas@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.