Re: [PATCH v2 1/3] dt-bindings: nvmem: mediatek: efuse: add mt6572

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The new `mediatek,mt6572-efuse` compatible string is defined as a standalone enum without a generic fallback, yet the driver lacks support for it.
--

--- Patch [1]: [PATCH v2 1/3] dt-bindings: nvmem: mediatek: efuse: add mt6572 ---
commit 16da21605192748d95ca1fe2779220ec48ccf918
Author: Roman Vivchar <rva333@protonmail.com>

dt-bindings: nvmem: mediatek: efuse: add mt6572

This commit adds a compatible string for the MediaTek MT6572 SoC efuse
controller to the binding schema. It introduces a new enum block for both
the new mt6572 string and the existing mt8186 string.

> diff --git a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> index f9323b3ecfc83..e109471649412 100644
> --- a/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/mediatek,efuse.yaml
> @@ -24,13 +24,16 @@ properties:
>  
>    compatible:
>      oneOf:
> +      - enum:
> +          - mediatek,mt6572-efuse

[Severity: Medium]
Will device trees using this new compatible string fail to probe?

The mediatek,mt6572-efuse string is defined here as a standalone enum
without a generic mediatek,efuse fallback. However, the mtk-efuse driver
in drivers/nvmem/mtk-efuse.c does not match mediatek,mt6572-efuse
specifically.

If a system integrator strictly follows this schema, the device node will
not probe. Conversely, if the device tree includes the mediatek,efuse
fallback so the driver can match and probe, it will fail dtbs_check
validation because this schema does not expect the fallback in an items
list.

Should mediatek,mt6572-efuse be defined alongside the generic
mediatek,efuse fallback instead of as a standalone enum?

> +          - mediatek,mt8186-efuse
> +
>        - items:

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-6572-nvmem-v2-0-e58d16a29621@protonmail.com?part=1