From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7656C3CDBD7; Fri, 24 Jul 2026 13:14:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784898874; cv=none; b=MjVq0zOUMtwY/ZHM4OfzBi5I0txzDWgaNTid7Hwhrsb72mBEb2ssALvzAsF/q5+juTlAZkvC6r2fLWy8FYvN8SEXvHzfFlDu5ON2M58IsMNNBLi0WhufRPpTJH7GnPJnM+Y0kGutOx9vzv69FI8gude318pIL3IIgN9AGdsR7Ds= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784898874; c=relaxed/simple; bh=vp3uPHdG112SgKxd8a986oZMiBqWhSeCaU25fUr9XoI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=btQ/sNHUM+DVkxrfBlpwluTPs48Jaqoop27ZaP3RgRHeIu7jak5wbOVviiDL4A6XcAcEkER5GnjB+PlXO0cVutU8Qk7MFezhGU53xzDMe7u0TnKFOwjIbGueNXAxA6HkEIbuNTDnV/wLymdGH47kgRrSGk7UQMRSP+dcbW++rCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id BC81F68CFE; Fri, 24 Jul 2026 15:14:30 +0200 (CEST) Date: Fri, 24 Jul 2026 15:14:30 +0200 From: Christoph Hellwig To: Andrey Albershteyn Cc: linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, linux-fsdevel@vger.kernel.org, ebiggers@kernel.org, hch@lst.de, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, djwong@kernel.org Subject: Re: [PATCH v13 07/23] fs,fsverity: remove check for fsverity being enabled in setattr_prepare() Message-ID: <20260724131430.GC27878@lst.de> References: <20260721184346.416657-1-aalbersh@kernel.org> <20260721184346.416657-8-aalbersh@kernel.org> Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260721184346.416657-8-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) On Tue, Jul 21, 2026 at 08:40:44PM +0200, Andrey Albershteyn wrote: > The check that fs-verity is available in the kernel is not necessary > here. Filesystems could have fsverity files even without fs-verity > module, then truncate will succeed. Previously, this would return > EOPNOTSUPP if verity is missing, but if it's not EPERM was returned > anyway. Looks good: Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A98A7C531C9 for ; Fri, 24 Jul 2026 15:41:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+BqnP3VDmK2hToVHljr7xXwZVmZWmLy0yMN4M1L5e3o=; b=hZgQrgBcuMPb8r9PGtmvf+wvkn 3KB19mdnSOPlcDIQCO8nJyP9DSCLSdnEiQwpICi+7wMnbdclqFhraAn+vqlFA3M83EIzbU1oHc0R6 1x4Fo012f71c8y6P0Bapc5O1EOuuP03fOxg/o1Vqp+q5SfK/M+g19Nbi9i1tL08tll+c=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wnI1e-0002tT-0k; Fri, 24 Jul 2026 15:41:23 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wnI1c-0002tL-Pt for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Jul 2026 15:41:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=vp3uPHdG112SgKxd8a986oZMiBqWhSeCaU25fUr9XoI=; b=gx7kLZEr+7z0yz7q1ZKWHfsOEb 3sSdtS7U0idykcukBW+6Ttrvw6BcOOeEgWsZD0nArwFDkOBK+0vwUhnfEuobn3dZ/DLjKZYs158rx UKQqQcYtd3QqjXQCA+7xwZjjpDI94EGaJf6HAC72J9dNYmZeTn1kpVjSWDgwJI85YIY0=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=vp3uPHdG112SgKxd8a986oZMiBqWhSeCaU25fUr9XoI=; b=jFthkYOAbbMVD9VGUHn2RwaKE7 lHgYUqjL0b+jVOwikVAw8IYmkpznirIaAR0MmoTc0J6/xUgDHm/O0amT+A6EnNy3ORYqMf9jrOXv5 KKURLbOm91ECJ6FTpyKv794aaxs/gl7WhRZ5/of/4jvWdbpuHdVeWw0MRfPQmmF/BX+g=; Received: from verein.lst.de ([213.95.11.211]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wnI1a-0004kh-WF for linux-f2fs-devel@lists.sourceforge.net; Fri, 24 Jul 2026 15:41:22 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id BC81F68CFE; Fri, 24 Jul 2026 15:14:30 +0200 (CEST) Date: Fri, 24 Jul 2026 15:14:30 +0200 From: Christoph Hellwig To: Andrey Albershteyn Message-ID: <20260724131430.GC27878@lst.de> References: <20260721184346.416657-1-aalbersh@kernel.org> <20260721184346.416657-8-aalbersh@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20260721184346.416657-8-aalbersh@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Headers-End: 1wnI1a-0004kh-WF Subject: Re: [f2fs-dev] [PATCH v13 07/23] fs, fsverity: remove check for fsverity being enabled in setattr_prepare() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fsverity@lists.linux.dev, ebiggers@kernel.org, djwong@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, hch@lst.de, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Tue, Jul 21, 2026 at 08:40:44PM +0200, Andrey Albershteyn wrote: > The check that fs-verity is available in the kernel is not necessary > here. Filesystems could have fsverity files even without fs-verity > module, then truncate will succeed. Previously, this would return > EOPNOTSUPP if verity is missing, but if it's not EPERM was returned > anyway. Looks good: Reviewed-by: Christoph Hellwig _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel