From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E402DC531F9 for ; Fri, 24 Jul 2026 14:32:20 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [127.0.0.1]) by lists.ozlabs.org (Postfix) with ESMTP id 4h69S32kkpz2yYf; Sat, 25 Jul 2026 00:32:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; arc=none smtp.remote-ip=148.163.158.5 ARC-Seal: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1784903539; cv=none; b=TFJ4oWRFtIDVEi798vxb06CJX5WRyv+tPQdpOt18u09/t4+muDWvthvWf/3XqBG8DaVBjYnWtYRKvjICWH//Q3o9Pu4AzBpdGzmUo4PPRK+IfNcCfMoYzIgrjM3ugLxVOpHw3yw95GskJFuVRTnQqFt8Hn9/hnniXExn8xN4AtdJBI8MMY9vO6evPQbWO4wd8nNjp0tA3XkA0bpZTej5oTMZV7A9limfZXuqJKjTSvJeTGnoqAYAksFkoDSnL7QDQ4hmdu1ppdxyq8JwN0j3rKbtJcRSJbjvNfeRVVEEVJmefLYA7VD4eMTPpyfQ9oLA7Ceesmti6gzSutbVltbR8A== ARC-Message-Signature: i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1784903539; c=relaxed/relaxed; bh=gJDwNNHRg/V9p64WyFdbjNg9L2skeIGL5SnPkd5M45Q=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FAieyNpWUOwGwt6aNVDokX34PD55Sf8LasWCU1TqKmCDjjY9MmEItP1nqkeABhZ5ovHySJFcDLFMD7lJEa4ZOWqAiGZQpVi9I0VHLO+51SRsPUVzCvReZZnZGujodRXHdpyCmPsstqajUpZaIWqvHTfUbQM19l7LlrwwPDntdzIlmunrfzdVfPD/J7CaHCO0DZjFUmUtow/SDAvp8Ss8TaZCDTeKwEbhrhq/9oQjZZx3TJLdurIzSch9+ZBT6CGDqd1p/4ErOnZSZK0M5R0mByVpumj+LEa+3PVxZygYF1NZGKX1JFjmzjIObYpOtw8pnsUqUvnqz6t2ZnluelSMQg== ARC-Authentication-Results: i=1; lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=SAtvlz0D; dkim-atps=neutral; spf=pass (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=tshah@linux.ibm.com; receiver=lists.ozlabs.org) smtp.mailfrom=linux.ibm.com Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ibm.com header.i=@ibm.com header.a=rsa-sha256 header.s=pp1 header.b=SAtvlz0D; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.158.5; helo=mx0b-001b2d01.pphosted.com; envelope-from=tshah@linux.ibm.com; receiver=lists.ozlabs.org) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4h69S15h4Sz2yFg for ; Sat, 25 Jul 2026 00:32:17 +1000 (AEST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66ODg2981994686; Fri, 24 Jul 2026 14:32:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=gJDwNNHRg/V9p64WyFdbjNg9L2skeIGL5SnPkd5M4 5Q=; b=SAtvlz0D2QeQ9U3BuGFbII/BHBDBKawSyyGKDWDwm3EUSySWk/NwTgEjk zbDcQlNkbhcuCwrzr/zEPUjwEUlQ3QduxZNnbyBx3gaYgQxL/wcopZzaAMs0UIJ/ 9qpzfGdyD9fdvoCXq2E/GIlQoqSsCT5imrj2MxFqB6P/14DN0jLhQBslgpF3edCB GxjRsgZ3uW08hvOjRUOaFlPck+JOdpwsPaCQp6eLKy/uiQ9T0R0XA6INxIuEm7kE dy6NeUhm66nYgHziDy+VhMSbhEJxqEEc9emjRRNUsLBv3YSI33uh7BtZbguxKGcS Q5YnDGYGiWQE5XewiTDqr2cC92mKg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fg7ahmfxr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jul 2026 14:32:12 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66OEJcxq031263; Fri, 24 Jul 2026 14:32:11 GMT Received: from smtprelay07.fra02v.mail.ibm.com ([9.218.2.229]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fgm6whcqm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 24 Jul 2026 14:32:11 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay07.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66OEW7l134865468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jul 2026 14:32:07 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EF6FA20217; Fri, 24 Jul 2026 14:13:22 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 000A62021C; Fri, 24 Jul 2026 14:13:18 +0000 (GMT) Received: from li-4c4c4544-0047-4210-804e-b5c04f423534.ibm.com.com (unknown [9.39.22.34]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Fri, 24 Jul 2026 14:13:18 +0000 (GMT) From: Tanushree Shah To: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com, vmolnaro@redhat.com, mpetlan@redhat.com, tmricht@linux.ibm.com, maddy@linux.ibm.com, irogers@google.com, namhyung@kernel.org Cc: linux-perf-users@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, atrajeev@linux.ibm.com, hbathini@linux.ibm.com, Tejas.Manhas1@ibm.com, Tanushree.Shah@ibm.com, Shivani.Nittor@ibm.com, Tanushree Shah Subject: [PATCH v3 0/5] perf trace-event: Fix security bugs in trace-event-read.c and trace-event.c Date: Fri, 24 Jul 2026 19:43:11 +0530 Message-ID: <20260724141316.99507-1-tshah@linux.ibm.com> X-Mailer: git-send-email 2.54.0 X-Mailing-List: linuxppc-dev@lists.ozlabs.org List-Id: List-Help: List-Owner: List-Post: List-Archive: , List-Subscribe: , , List-Unsubscribe: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-ORIG-GUID: E6hTu7Hy7LaqXJ7txrjdgiNJcsr65_aC X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI0MDEyOCBTYWx0ZWRfX9/fM4pvbwQNX OskAKp03VO9PKwDr8BDIVKl4FlsrbWMBwnJ0sAAuNsbNtTt955yCSYoJbh3uMqLS8kQaKwgPu/e SWPSZxAtJRt4JhpdUBZwHJ5Kd4qRmddsi4WOXOmmGMytppMx9DaBxP9LjpQ2rQPmZYfpLjhDpnY ZCb2zKL7bK96D/F9c+yhX9jNSIatURX8a4qj8rMUg5OGpNDQ1gXR/7NhDUyWMmJbFg74hNT+NNg x/nE/yGFG8OaEOAmKo0bzf+NZzCV1ecUsZ0HYGxb2DUITqiM4mcTnYHtKs1uFtta5w2wEKyJCb2 bTuQkkm/Zjw8xwyjjb/rnMU855ELv4JM40h5+wkp//D4ChfaHIGrvidaGxg6MwEgvD0JmtaoU2X Uz4zKz6l7gmL595jUk7H6YmH3l++xnsiwJaeajjQ6OH5kJ4q/N4ToFOdBdBnQRzbjJEXTvTa1Cs 8xfX1i5sp/XZ730Y5Nw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI0MDEyOCBTYWx0ZWRfXziqfvyYCPd9b 1TaDuMEY9rVXKebbZNvJeyHiPmbBG+MvbYZmktwpGvKl7hHiG07ZrcR0sbFJ3Vc+ktArLRlUTC7 41/TNd1cjVYyHJcP7UBR3wwCl34+Zys= X-Proofpoint-GUID: mda5cVLL2Vmb8-pOPFlshmjyNNROiJv0 X-Authority-Analysis: v=2.4 cv=SM5ykuvH c=1 sm=1 tr=0 ts=6a63776c cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=RzCfie-kr_QcCd8fBx8p:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=_TZ-ywmwFNITdAXsKjsA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-24_03,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 bulkscore=0 suspectscore=0 adultscore=0 spamscore=0 malwarescore=0 priorityscore=1501 phishscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607240128 This series fixes five security issues in trace-event-read.c and trace-event.c: 1. Stack buffer overflow in read_string() when a string exceeds BUFSIZ, due to a missing bounds check. 2. Integer truncation when passing 64-bit sizes into do_read() and skip(), which use 'int' parameters, causing uninitialized memory to be dumped and parsers to read out of bounds. 3. Double free / use-after-free in trace_event__cleanup(): it frees t->pevent but never clears the pointer, so calling it twice on the same trace_event touches already-freed memory. 4. Heap buffer overflow in read_ftrace_printk(): size + 1 can overflow to 0 in malloc(), allocating a tiny buffer while a huge read is still attempted into it. 5. Infinite loop in skip(): it does not check do_read()'s return value, so a crafted size can spin the loop indefinitely. Patches 4 and 5 are latent bugs that patch 2's type fix exposes by removing accidental truncation that had been masking them. Tanushree Shah (5): perf trace-event: Fix buffer overflow in read_string() perf trace-event: Fix integer truncation in do_read() and skip() perf trace-event: Avoid double free in trace_event__cleanup() perf trace-event: Fix heap buffer overflow in read_ftrace_printk() perf trace-event: Fix infinite loop in skip() tools/perf/util/trace-event-read.c | 48 +++++++++++++++++++----------- tools/perf/util/trace-event.c | 4 +++ 2 files changed, 35 insertions(+), 17 deletions(-) --- Changes in v3: - Added new patch to fix double free in trace_event__cleanup(). - Added new patch to fix heap buffer overflow in read_ftrace_printk(). - Added new patch to fix infinite loop in skip(). Changes in v2: - Added new patch to fix integer truncation in do_read() and skip(). - Organized as patch series to separate the two security fixes. v1: https://lore.kernel.org/linux-perf-users/20260722113552.191143-3-tshah@linux.ibm.com/ -- 2.47.3