All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: Carlo Caione <ccaione@baylibre.com>
Cc: sjg@chromium.org, quentin.schulz@cherry.de,
	u-boot@lists.u-boot-project.org, dlechner@baylibre.com,
	jstephan@baylibre.com, GSS_MTK_Uboot_upstream@mediatek.com
Subject: Re: [PATCH v2] fit: prefer the default configuration on best-match ties
Date: Fri, 24 Jul 2026 09:53:24 -0600	[thread overview]
Message-ID: <20260724155324.GE749385@bill-the-cat> (raw)
In-Reply-To: <DK6WQC5RS7VS.7LJNJHF6LZ2I@baylibre.com>

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

On Fri, Jul 24, 2026 at 05:30:17PM +0200, Carlo Caione wrote:
> On Thu Jul 9, 2026 at 12:48 PM CEST, Carlo Caione wrote:
> > With CONFIG_FIT_BEST_MATCH, fit_conf_find_compat() selects the
> > configuration matching the most specific U-Boot compatible string; on
> > equal matches the first listed configuration wins and the configurations
> > node 'default' property is never consulted.
> >
> > A FIT whose configurations all share the same base devicetree compatible
> > (e.g. one manifest carrying a base tree plus overlay combinations for a
> > single board) therefore always boots the first configuration, silently
> > ignoring the default chosen by the manifest author.
> >
> > Break score ties in favour of the default configuration. A strictly
> > better compatible match still wins over it, and FITs without a default
> > keep the current first-listed behaviour.
> >
> > Reviewed-by: Simon Glass <sjg@chromium.org>
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> > Signed-off-by: Carlo Caione <ccaione@baylibre.com>
> 
> Hi Simon and Tom,
> any chance you can pick this up for the next release?

Ah, so I had read
https://github.com/open-source-firmware/flat-image-tree/pull/59#pullrequestreview-4663326599
as requesting a change in wording, but I guess it was acknowledging a
change in wording you had done, so I should grab this soon then, yes,
thanks for the reminder.

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2026-07-24 15:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 10:48 [PATCH v2] fit: prefer the default configuration on best-match ties Carlo Caione
2026-07-22  8:21 ` Carlo Caione via U-Boot
2026-07-24 15:30 ` Carlo Caione
2026-07-24 15:53   ` Tom Rini [this message]
2026-07-24 19:58 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260724155324.GE749385@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=GSS_MTK_Uboot_upstream@mediatek.com \
    --cc=ccaione@baylibre.com \
    --cc=dlechner@baylibre.com \
    --cc=jstephan@baylibre.com \
    --cc=quentin.schulz@cherry.de \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.u-boot-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.