From: Jakub Kicinski <kuba@kernel.org>
To: Mark Bloch <mbloch@nvidia.com>
Cc: Jiri Pirko <jiri@resnulli.us>, Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Saeed Mahameed <saeedm@nvidia.com>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>, <netdev@vger.kernel.org>,
<linux-rdma@vger.kernel.org>, <linux-doc@vger.kernel.org>,
Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next V7 4/4] devlink: Apply eswitch mode boot defaults
Date: Fri, 24 Jul 2026 16:11:11 -0700 [thread overview]
Message-ID: <20260724161111.2ac47089@kernel.org> (raw)
In-Reply-To: <20260716084852.549909-5-mbloch@nvidia.com>
On Thu, 16 Jul 2026 11:48:52 +0300 Mark Bloch wrote:
> void devl_unlock(struct devlink *devlink)
> {
> + devlink_default_eswitch_mode_apply_pending(devlink);
> mutex_unlock(&devlink->lock);
> }
Nack, please don't insert such hacks into core helpers :|
I thought we discussed this.
--
pw-bot: cr
prev parent reply other threads:[~2026-07-24 23:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 8:48 [PATCH net-next V7 0/4] devlink: Add boot-time eswitch mode defaults Mark Bloch
2026-07-16 8:48 ` [PATCH net-next V7 1/4] net/mlx5: Clear FW reset-in-progress bit before reload Mark Bloch
2026-07-16 8:48 ` [PATCH net-next V7 2/4] devlink: Factor out eswitch mode setting Mark Bloch
2026-07-16 8:48 ` [PATCH net-next V7 3/4] devlink: Parse eswitch mode boot defaults Mark Bloch
2026-07-16 8:48 ` [PATCH net-next V7 4/4] devlink: Apply " Mark Bloch
2026-07-24 23:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724161111.2ac47089@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=skhan@linuxfoundation.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.