[Buildroot] [PATCH/RFC 2/3] package/taglib: needs gcc >= 7

[Bernd Kuhls <bernd@kuhls.net>]

Fixes a build error caught by the Gitlab pipelines:

/builds/bkuhls/buildroot/br-test-pkg/bootlin-aarch64-glibc-old/build/taglib-2.3/taglib/mpeg/mpegfile.cpp:113:10:
 error: expected primary-expression before ‘const’
       if(const Header header(&file, headerOffset + i, true); header.isValid()) {

which was introduced by code format changes in upstream commit
https://github.com/taglib/taglib/commit/dfe2aa52532fc9f73a67499dd17fb527a856a22f

which was first released with taglib 2.0, added to buildroot with commit
9cd3464afa13fd0190fb3e94fd850cc8063cf297.

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
I have no idea if this patch is correct, at least blocking gcc 6 makes
the Gitlab pipelines happy. It seems to me that the upstream commit uses
newer language features not supported by gcc 6, but with my limited
knowledge about C++ I could not find evidence to support my theory.

 package/gstreamer1/gst1-plugins-good/Config.in | 6 ++++--
 package/taglib/Config.in                       | 6 ++++--
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/package/gstreamer1/gst1-plugins-good/Config.in b/package/gstreamer1/gst1-plugins-good/Config.in
index 6a738faa00..c4eb4efb65 100644
--- a/package/gstreamer1/gst1-plugins-good/Config.in
+++ b/package/gstreamer1/gst1-plugins-good/Config.in
@@ -403,13 +403,15 @@ config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_SPEEX
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TAGLIB
 	bool "taglib"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_TAGLIB
 	help
 	  Taglib tagging plugin library
 
-comment "taglib needs a toolchain w/ C++, wchar"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
+comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7
 
 config BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_TWOLAME
 	bool "twolame"
diff --git a/package/taglib/Config.in b/package/taglib/Config.in
index 5b641a9653..9a43c82a5e 100644
--- a/package/taglib/Config.in
+++ b/package/taglib/Config.in
@@ -1,6 +1,7 @@
 config BR2_PACKAGE_TAGLIB
 	bool "taglib"
 	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_7 # C++17
 	depends on BR2_USE_WCHAR
 	select BR2_PACKAGE_UTFCPP
 	help
@@ -12,5 +13,6 @@ config BR2_PACKAGE_TAGLIB
 
 	  http://taglib.org/
 
-comment "taglib needs a toolchain w/ C++, wchar"
-	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR
+comment "taglib needs a toolchain w/ C++, wchar, gcc >= 7"
+	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_GCC_AT_LEAST_7
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot