From: Jakub Kicinski <kuba@kernel.org>
To: Luke Howard <lukeh@padl.com>
Cc: Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Vivien Didelot <vivien.didelot@gmail.com>,
Gregory CLEMENT <gregory.clement@bootlin.com>,
Andrew Lunn <andrew@lunn.ch>,
Richard Cochran <richardcochran@gmail.com>,
Cedric Jehasse <cedric.jehasse@gmail.com>,
Kieran Tyrrell <kieran@sienda.com>,
Max Holtmann <mh@rme-audio.de>, Max Hunter <max@huntershome.org>,
Christoph Mellauner <christoph.mellauner@joyned.at>,
Simon Gapp <simon.gapp@gapp-audio.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] net: dsa: mv88e6xxx: embedded PTP timestamp support
Date: Fri, 24 Jul 2026 16:48:58 -0700 [thread overview]
Message-ID: <20260724164858.4581408e@kernel.org> (raw)
In-Reply-To: <20260719-mv88e6xxx-ptp-fixes-v3-2-161386ac8a62@padl.com>
On Sun, 19 Jul 2026 15:30:54 +1000 Luke Howard wrote:
> + /* APPEND means the switch appended the time stamp as a 4-byte trailer
> + * (not all switches support this). Any other non-zero value is the byte
> + * offset past the start of the PTP common header at which the switch
> + * overwrote the time stamp in place (e.g. the reserved header bytes).
> + */
> + if (arr_ts_mode == MV88E6XXX_PTP_ARR_TS_MODE_APPEND && skb->len >= 4) {
> + if (skb_linearize(skb))
> + return false;
> +
> + *ns = (u64)get_unaligned_be32(skb_tail_pointer(skb) - 4);
> + if (pskb_trim_rcsum(skb, skb->len - 4))
> + return false;
The append mode would extend the frame, and possibly run afoul the MTU
on the conduit AFAIU? Since neither implemented chip uses this it's
both dead code and questionable. Let's remove it.
next prev parent reply other threads:[~2026-07-24 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 5:30 [PATCH net-next v3 0/3] net: dsa: mv88e6xxx: various hwstamp fixes Luke Howard
2026-07-19 5:30 ` [PATCH net-next v3 1/3] net: dsa: mv88e6xxx: use ARRIVAL1 counter for all peer delay messages Luke Howard
2026-07-19 5:30 ` [PATCH net-next v3 2/3] net: dsa: mv88e6xxx: embedded PTP timestamp support Luke Howard
2026-07-24 23:48 ` Jakub Kicinski [this message]
2026-07-19 5:30 ` [PATCH net-next v3 3/3] net: dsa: mv88e6xxx: apply embedded PTP arrival times inline Luke Howard
2026-07-24 23:52 ` [PATCH net-next v3 0/3] net: dsa: mv88e6xxx: various hwstamp fixes Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724164858.4581408e@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=cedric.jehasse@gmail.com \
--cc=christoph.mellauner@joyned.at \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregory.clement@bootlin.com \
--cc=kieran@sienda.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukeh@padl.com \
--cc=max@huntershome.org \
--cc=mh@rme-audio.de \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=simon.gapp@gapp-audio.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.