From: "Darrick J. Wong" <djwong@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: cem@kernel.org, stable@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 4/6] xfs: don't zap the attr fork on repair when there are queued pptr updates
Date: Fri, 24 Jul 2026 10:05:23 -0700 [thread overview]
Message-ID: <20260724170523.GA2901224@frogsfrogsfrogs> (raw)
In-Reply-To: <20260724132526.GD28170@lst.de>
On Fri, Jul 24, 2026 at 03:25:26PM +0200, Christoph Hellwig wrote:
> On Thu, Jul 23, 2026 at 11:22:03PM -0700, Darrick J. Wong wrote:
> > - if (rx->attrs_found == 0) {
> > + if (rx->attrs_found == 0 && (!xfs_has_parent(sc->mp) ||
> > + xfarray_length(rx->pptr_recs) == 0)) {
>
> Hmm, this formatting looks at least a bit confusing. Why not:
>
> if (rx->attrs_found == 0 &&
> (!xfs_has_parent(sc->mp) || xfarray_length(rx->pptr_recs) == 0)) {
>
> ?
Yeah, I will fix this.
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
Thanks for reviewing this series!
--D
next prev parent reply other threads:[~2026-07-24 17:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 6:21 [PATCHSET] xfs: LLM-inspired bug fixes, part 4 Darrick J. Wong
2026-07-24 6:21 ` [PATCH 1/6] xfs: only check mergeability of bnobt records Darrick J. Wong
2026-07-24 13:21 ` Christoph Hellwig
2026-07-24 6:21 ` [PATCH 2/6] xfs: don't double-lock when deleting a self-referential directory Darrick J. Wong
2026-07-24 13:23 ` Christoph Hellwig
2026-07-24 6:21 ` [PATCH 3/6] xfs: don't return EFSCORRUPTED when scrubbing corrupt parent pointers Darrick J. Wong
2026-07-24 13:23 ` Christoph Hellwig
2026-07-24 6:22 ` [PATCH 4/6] xfs: don't zap the attr fork on repair when there are queued pptr updates Darrick J. Wong
2026-07-24 13:25 ` Christoph Hellwig
2026-07-24 17:05 ` Darrick J. Wong [this message]
2026-07-24 6:22 ` [PATCH 5/6] xfs: nlink scrub must take IOLOCK before determining ILOCK state Darrick J. Wong
2026-07-24 13:26 ` Christoph Hellwig
2026-07-24 6:22 ` [PATCH 6/6] xfs: avoid UAF on sc->tempip in xrep_tempfile_create Darrick J. Wong
2026-07-24 13:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260724170523.GA2901224@frogsfrogsfrogs \
--to=djwong@kernel.org \
--cc=cem@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.