From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1436533F59D for ; Fri, 24 Jul 2026 18:12:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784916774; cv=none; b=TannmlAsRpPOHDPGnI0ybqsf9Y/YgB+AD/QbaSfU9AfxUQpb5GVvWhJbzToUXVT1rbObknkYP3Kp48JVYCzcU9YANnP4GiSyRxeAGtCm5PJNa0RgR2XUPDGnIpt1nZ5RHPP60KGmwWpLh7Or0PGSdugZKbPlQoz0etz3RQyqzK0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784916774; c=relaxed/simple; bh=z0ZiB9KxT5aGyBJU2MIivLCaJvRQgJtm2WHHVgwy/UM=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Y0gLIQLsuU1a3GWn6mkjMKeJemBa1+pAdYRT4emNBTw5wm5/MfqVCWhJ37D1F2t+g2DNngEMrmFVcMa+eTKLPqLbFVLlFKfTV/LvfTK2ddTEbxjjiveYj1crdi3rsn0pGBr1+t8BVruX4OtkUu7H3W3m7dinlfEgHwLdKL9In5s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=IKVKja23; arc=none smtp.client-ip=209.85.210.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--jstultz.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="IKVKja23" Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-84a67b16217so1080182b3a.3 for ; Fri, 24 Jul 2026 11:12:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1784916768; x=1785521568; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KprZwAc5q4vY44wv9gOnWLxxrrdKt2iGwmqxm7X05+I=; b=IKVKja23POoN098zhv+giSpZz504CNZfF70jlkvB1YdR82TuaLefOYKBHKP6s7vMzb 4BhoDu59OZxFVwOY83+MGDyiI/ZHCf+zS7sqWEruJQulh6NwA94YziXwAhyddU0zAwRW GHQIViw5TxVtlaLUOnV8SvW1CDamrI389pas9qKRsgKC5FcakUJen7XWFqozDEEFHrHw GhsdhnA9XVC6TspL5s142+nTtZe4v4EhhE3pD2UvIapWTeCq9BNFRrScz+HxpVbRndVz VUH9Hc5GNRM0YRiPXnfXfX/lo5XXmNBSl/5wc4/pfVMFoWrzGnOrk4NEUjCjQfWUgFrg aYLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784916768; x=1785521568; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=KprZwAc5q4vY44wv9gOnWLxxrrdKt2iGwmqxm7X05+I=; b=bemLSCm8Lsgco4kMu/v+L5G6xwvrn7ZUqbQTGZ734XTE3HGo+DzHO6ipV7lE1xrIsg rUY44sydwcok4Di8REXd4atAtfTIHRQi1ebjO43dI4fbFUbwd1pwe/+TcBzQv7QpmmEe SxvhjENTviuprdN5g/XLfHsbt29SsL0e0hl2dldk6pzmcwEVJGdht8ToD3cyhxUMFe8W 5MyfXnrExWD9eGogClFwH/bpas/j0b//kTxC69AdiAx5lJNVXsLYD4Y+iOFoufszGmQm pQrHCHdRFUVQFMFfBl2fUDuCPYag9itNZLpLjfC4lLAQPDsIp7tPMV5vxFg8rLviVVZu 6w0Q== X-Gm-Message-State: AOJu0YyFQdI82uUml/JOgYSvt0GycGGplzKA2fUwwPEAdbOKP6p4jGT7 tlie1WQpBF5/S++jNsw1FylCRDzaiCBc5J2ctO1idCNlv7oM98NZCXZNu2IHjJ17wkTDlVlalyR MMTuSlNlTK63iUKZ7qFRioAtJh24mg7YOcX0wGN9h1HwZfziS4DamZTlgke1ZvkpDKTVekdYTyq pfcoK03CnmMCDGVlQrlwAHYNrJRdeK8uwHy52YanxXrSS35Myz X-Received: from pfbmb13.prod.google.com ([2002:a05:6a00:760d:b0:847:a7b8:c316]) (user=jstultz job=prod-delivery.src-stubby-dispatcher) by 2002:a05:6a00:451a:b0:847:86b0:888c with SMTP id d2e1a72fcca58-84e2bb54669mr9285040b3a.48.1784916767308; Fri, 24 Jul 2026 11:12:47 -0700 (PDT) Date: Fri, 24 Jul 2026 18:12:20 +0000 In-Reply-To: <20260724181238.3445275-1-jstultz@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260724181238.3445275-1-jstultz@google.com> X-Mailer: git-send-email 2.55.0.229.g6434b31f56-goog Message-ID: <20260724181238.3445275-7-jstultz@google.com> Subject: [PATCH v31 6/9] sched: Break out core of attach_tasks() helper into sched.h From: John Stultz To: LKML Cc: John Stultz , K Prateek Nayak , Joel Fernandes , Qais Yousef , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Valentin Schneider , Steven Rostedt , Ben Segall , Zimuzo Ezeozue , Will Deacon , Waiman Long , Boqun Feng , "Paul E. McKenney" , Metin Kaya , Xuewen Yan , Thomas Gleixner , Daniel Lezcano , Suleiman Souhlal , Andrea Righi , kuyo chang , hupu , kernel-team@android.com Content-Type: text/plain; charset="UTF-8" Pull the core of attach_tasks() out into sched.h so it can be used more generically. Suggested-by: K Prateek Nayak Signed-off-by: John Stultz --- Cc: Joel Fernandes Cc: Qais Yousef Cc: Ingo Molnar Cc: Peter Zijlstra Cc: Juri Lelli Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Valentin Schneider Cc: Steven Rostedt Cc: Ben Segall Cc: Zimuzo Ezeozue Cc: Will Deacon Cc: Waiman Long Cc: Boqun Feng Cc: "Paul E. McKenney" Cc: Metin Kaya Cc: Xuewen Yan Cc: K Prateek Nayak Cc: Thomas Gleixner Cc: Daniel Lezcano Cc: Suleiman Souhlal Cc: Andrea Righi Cc: kuyo chang Cc: hupu Cc: kernel-team@android.com --- kernel/sched/fair.c | 16 +--------------- kernel/sched/sched.h | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+), 15 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index d78467ec6ee13..6d2fa0cd77779 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -11035,21 +11035,7 @@ static int detach_tasks(struct lb_env *env) */ static void attach_tasks(struct lb_env *env) { - struct list_head *tasks = &env->tasks; - struct task_struct *p; - struct rq_flags rf; - - rq_lock(env->dst_rq, &rf); - update_rq_clock(env->dst_rq); - - while (!list_empty(tasks)) { - p = list_first_entry(tasks, struct task_struct, se.group_node); - list_del_init(&p->se.group_node); - - attach_task(env->dst_rq, p); - } - - rq_unlock(env->dst_rq, &rf); + __attach_tasks(env->dst_rq, &env->tasks); } #ifdef CONFIG_NO_HZ_COMMON diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 56acf502ba260..56d9c09c485e6 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -3100,6 +3100,25 @@ static inline void attach_one_task(struct rq *rq, struct task_struct *p) attach_task(rq, p); } +/* + * __attach_tasks() - attaches a list of tasks (using se.group_node) to + * the new rq + */ +static inline void __attach_tasks(struct rq *rq, struct list_head *tasks) +{ + guard(rq_lock)(rq); + update_rq_clock(rq); + + while (!list_empty(tasks)) { + struct task_struct *p; + + p = list_first_entry(tasks, struct task_struct, se.group_node); + list_del_init(&p->se.group_node); + + attach_task(rq, p); + } +} + #ifdef CONFIG_PREEMPT_RT # define SCHED_NR_MIGRATE_BREAK 8 #else -- 2.55.0.229.g6434b31f56-goog