From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59578390200 for ; Fri, 24 Jul 2026 18:54:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784919291; cv=none; b=s0nMhWIETpkXcMHX4wZSWxLeO5VG+qSRNeDlFOIkHHUDG6NO4hygHYlL6evO7QPLnfoQ6yGj6ui6y7dL/a+3rE+vtlLmuSj7xksHKj9QbS1XXSxltl20PyTtVnqNZLs1V3vIuk4FXGRiH+10tiZ/5kYFxMAVzbq5StCnul6skE0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784919291; c=relaxed/simple; bh=DnBE3RoRaz+yEm1lum1DfDBvx7ETMVQcmhnFv/vdmj8=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=At6R2vsZ9Ifa4V73k0aA8xhVYh7pmZBZEQsvZ8aeAnH/OhD+iSkTACHCWF2P4pE6bB/Kyl/IOkeYBG2iCvftcSsMZV2wWtEnD1RchJaMjxp+bCw7oN3S/tx2wPCj8pB7yP8WbdR3dskMJ11bV+/IOA6V2j+v57F3b9ogxX8BC5E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=omMxzNTL; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="omMxzNTL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C4001F000E9; Fri, 24 Jul 2026 18:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784919290; bh=eb26OAfco3uffdPcqncNqeLr8DgPBJuAarHg9Y1si9Q=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=omMxzNTLIYq1qWGIHwhi9Eu46GXA2a/7QO5dtw3zMUo8MpaJIV62QQ23zY3kt0aMD 5l7c5TxdhnVN8cJpOVY57xMvhHIHQNWWFbWZHrry0kj65ZqdbyDyT/ia2Mg6Wjvg6F KL30Myaa+B0LhuKy2OBIQc/3bCGl+gcgwxuyPGObKQclG6KZCgQwucRhcsOvdnWTV1 BfWadNYH3+QtAWJ6uP5HFTzNJbeUQvGlFS9qFqkzRluMWsqgJOJ0Slj44Ippe1H3QI aBc8uCiA01DY7odJNjmEmZnJp/kXYrz8fKr479CRLGckxNALC0JDvAaqOTt4+vEucG mVRboFbHa67Kg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory Reply-To: sashiko-reviews@lists.linux.dev To: "Christian Marangi" Cc: neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org In-Reply-To: <20260724184523.193661-3-ansuelsmth@gmail.com> References: <20260724184523.193661-1-ansuelsmth@gmail.com> <20260724184523.193661-3-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 24 Jul 2026 18:54:49 +0000 Message-Id: <20260724185449.8C4001F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] The newly added drivers/phy/airoha/Kconfig and drivers/phy/airoha/M= akefile are not covered by the MAINTAINERS entry. -- --- Patch [2]: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver = to dedicated directory --- commit 83a3c170a5f0894b166822d36bf49798d65f73e9 Author: Christian Marangi phy: move and rename Airoha PCIe PHY driver to dedicated directory This commit moves the Airoha PCIe PHY driver to a dedicated directory and renames the files to specifically reference the AN7581 SoC. It also adds a new Kconfig and Makefile to the newly created drivers/phy/airoha/ directory to support future drivers for different SoCs. > diff --git a/MAINTAINERS b/MAINTAINERS > index cb7836a27b177..bbfaca572118c 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -765,8 +765,8 @@ M: Lorenzo Bianconi > L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) > S: Maintained > F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml > -F: drivers/phy/phy-airoha-pcie-regs.h > -F: drivers/phy/phy-airoha-pcie.c > +F: drivers/phy/airoha/phy-an7581-pcie-regs.h > +F: drivers/phy/airoha/phy-an7581-pcie.c [Severity: Low] This isn't a bug, but should the newly created drivers/phy/airoha/Kconfig and drivers/phy/airoha/Makefile files also be included in this entry? Currently, get_maintainer.pl might not automatically include the Airoha PCIe PHY driver maintainers for patches modifying those build files. Could this entry be simplified to cover the new files by using a directory match like "F: drivers/phy/airoha/" instead? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260724184523.1936= 61-1-ansuelsmth@gmail.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D88EC531C9 for ; Fri, 24 Jul 2026 18:54:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qriFXhJKmEGsHbNXSaoLjMOZrBOfZdUVzygj48dqfeA=; b=aFj+PfuocQy6Y0 DL61iejiZBkI9xdDwd+IozZ4iXljjnlsgxnt0domwwTRUVH+uM8j1P8NrSsuh9u8DCpPLsVJUMW9c efG25NlWrMwFYVXpZZUt5p4/y4AnkiODVYH5aeis97eCUdtaWZDTr2bWOe4xp3b8+8q+8vsDJ66p7 GMfiGjKYWfw4XuLp4it7LcmXQhVNCxYT2dIQZuYQ22oK55OmKOzf9VJKXok6aHJ2oic/0q+PrIyh4 c0PyBaOmTPU3dZ80htj8RabwJM6p07wVfJ8nnYUU4UdSx2N9D9MNgtOIIqYo6pW9poPnlKVdvPkPZ IgOS+1PwEjRuwDqSy9Yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnL2r-0000000H6Ce-3pzU; Fri, 24 Jul 2026 18:54:53 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnL2q-0000000H6CV-2ygb for linux-phy@lists.infradead.org; Fri, 24 Jul 2026 18:54:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 1AB9841310; Fri, 24 Jul 2026 18:54:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C4001F000E9; Fri, 24 Jul 2026 18:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784919290; bh=eb26OAfco3uffdPcqncNqeLr8DgPBJuAarHg9Y1si9Q=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=omMxzNTLIYq1qWGIHwhi9Eu46GXA2a/7QO5dtw3zMUo8MpaJIV62QQ23zY3kt0aMD 5l7c5TxdhnVN8cJpOVY57xMvhHIHQNWWFbWZHrry0kj65ZqdbyDyT/ia2Mg6Wjvg6F KL30Myaa+B0LhuKy2OBIQc/3bCGl+gcgwxuyPGObKQclG6KZCgQwucRhcsOvdnWTV1 BfWadNYH3+QtAWJ6uP5HFTzNJbeUQvGlFS9qFqkzRluMWsqgJOJ0Slj44Ippe1H3QI aBc8uCiA01DY7odJNjmEmZnJp/kXYrz8fKr479CRLGckxNALC0JDvAaqOTt4+vEucG mVRboFbHa67Kg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 2/3] phy: move and rename Airoha PCIe PHY driver to dedicated directory To: "Christian Marangi" Cc: neil.armstrong@linaro.org, olteanv@gmail.com, linux-phy@lists.infradead.org, conor+dt@kernel.org, robh@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org In-Reply-To: <20260724184523.193661-3-ansuelsmth@gmail.com> References: <20260724184523.193661-1-ansuelsmth@gmail.com> <20260724184523.193661-3-ansuelsmth@gmail.com> Date: Fri, 24 Jul 2026 18:54:49 +0000 Message-Id: <20260724185449.8C4001F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gVGhlIG5ld2x5IGFkZGVk IGRyaXZlcnMvcGh5L2Fpcm9oYS9LY29uZmlnIGFuZCBkcml2ZXJzL3BoeS9haXJvaGEvTWFrZWZp bGUgYXJlIG5vdCBjb3ZlcmVkIGJ5IHRoZSBNQUlOVEFJTkVSUyBlbnRyeS4KLS0KCi0tLSBQYXRj aCBbMl06IFtQQVRDSCB2MTEgMi8zXSBwaHk6IG1vdmUgYW5kIHJlbmFtZSBBaXJvaGEgUENJZSBQ SFkgZHJpdmVyIHRvIGRlZGljYXRlZCBkaXJlY3RvcnkgLS0tCmNvbW1pdCA4M2EzYzE3MGE1ZjA4 OTRiMTY2ODIyZDM2YmY0OTc5OGQ2NWY3M2U5CkF1dGhvcjogQ2hyaXN0aWFuIE1hcmFuZ2kgPGFu c3VlbHNtdGhAZ21haWwuY29tPgoKcGh5OiBtb3ZlIGFuZCByZW5hbWUgQWlyb2hhIFBDSWUgUEhZ IGRyaXZlciB0byBkZWRpY2F0ZWQgZGlyZWN0b3J5CgpUaGlzIGNvbW1pdCBtb3ZlcyB0aGUgQWly b2hhIFBDSWUgUEhZIGRyaXZlciB0byBhIGRlZGljYXRlZCBkaXJlY3RvcnkgYW5kCnJlbmFtZXMg dGhlIGZpbGVzIHRvIHNwZWNpZmljYWxseSByZWZlcmVuY2UgdGhlIEFONzU4MSBTb0MuIEl0IGFs c28gYWRkcyBhCm5ldyBLY29uZmlnIGFuZCBNYWtlZmlsZSB0byB0aGUgbmV3bHkgY3JlYXRlZCBk cml2ZXJzL3BoeS9haXJvaGEvIGRpcmVjdG9yeQp0byBzdXBwb3J0IGZ1dHVyZSBkcml2ZXJzIGZv ciBkaWZmZXJlbnQgU29Dcy4KCj4gZGlmZiAtLWdpdCBhL01BSU5UQUlORVJTIGIvTUFJTlRBSU5F UlMKPiBpbmRleCBjYjc4MzZhMjdiMTc3Li5iYmZhY2E1NzIxMThjIDEwMDY0NAo+IC0tLSBhL01B SU5UQUlORVJTCj4gKysrIGIvTUFJTlRBSU5FUlMKPiBAQCAtNzY1LDggKzc2NSw4IEBAIE06CUxv cmVuem8gQmlhbmNvbmkgPGxvcmVuem9Aa2VybmVsLm9yZz4KPiAgTDoJbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnIChtb2RlcmF0ZWQgZm9yIG5vbi1zdWJzY3JpYmVycykKPiAg UzoJTWFpbnRhaW5lZAo+ICBGOglEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5 L2Fpcm9oYSxlbjc1ODEtcGNpZS1waHkueWFtbAo+IC1GOglkcml2ZXJzL3BoeS9waHktYWlyb2hh LXBjaWUtcmVncy5oCj4gLUY6CWRyaXZlcnMvcGh5L3BoeS1haXJvaGEtcGNpZS5jCj4gK0Y6CWRy aXZlcnMvcGh5L2Fpcm9oYS9waHktYW43NTgxLXBjaWUtcmVncy5oCj4gK0Y6CWRyaXZlcnMvcGh5 L2Fpcm9oYS9waHktYW43NTgxLXBjaWUuYwoKW1NldmVyaXR5OiBMb3ddClRoaXMgaXNuJ3QgYSBi dWcsIGJ1dCBzaG91bGQgdGhlIG5ld2x5IGNyZWF0ZWQgZHJpdmVycy9waHkvYWlyb2hhL0tjb25m aWcKYW5kIGRyaXZlcnMvcGh5L2Fpcm9oYS9NYWtlZmlsZSBmaWxlcyBhbHNvIGJlIGluY2x1ZGVk IGluIHRoaXMgZW50cnk/CgpDdXJyZW50bHksIGdldF9tYWludGFpbmVyLnBsIG1pZ2h0IG5vdCBh dXRvbWF0aWNhbGx5IGluY2x1ZGUgdGhlIEFpcm9oYSBQQ0llClBIWSBkcml2ZXIgbWFpbnRhaW5l cnMgZm9yIHBhdGNoZXMgbW9kaWZ5aW5nIHRob3NlIGJ1aWxkIGZpbGVzLiBDb3VsZCB0aGlzCmVu dHJ5IGJlIHNpbXBsaWZpZWQgdG8gY292ZXIgdGhlIG5ldyBmaWxlcyBieSB1c2luZyBhIGRpcmVj dG9yeSBtYXRjaCBsaWtlCiJGOiBkcml2ZXJzL3BoeS9haXJvaGEvIiBpbnN0ZWFkPwoKWyAuLi4g XQoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNl dC8yMDI2MDcyNDE4NDUyMy4xOTM2NjEtMS1hbnN1ZWxzbXRoQGdtYWlsLmNvbT9wYXJ0PTIKCi0t IApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=