Re: [PATCH 1/2] dt-bindings: dpll: zl3073x: add ZL30643 compatible

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete Implementation: Missing driver support for microchip,zl30643.
--

--- Patch [1]: [PATCH 1/2] dt-bindings: dpll: zl3073x: add ZL30643 compatible ---
commit 890eef3f2bfb25bd5d633b88f0a74281dde779f7
Author: Vincent Jardin <vjardin@free.fr>

dt-bindings: dpll: zl3073x: add ZL30643 compatible

This commit adds the microchip,zl30643 compatible string to the ZL3073x
family device tree binding schema.

> diff --git a/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml b/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
> index fa5a8f8e390cd..13ea55c2c1467 100644
> --- a/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
> +++ b/Documentation/devicetree/bindings/dpll/microchip,zl30731.yaml
> @@ -18,6 +18,7 @@ description:
>  properties:
>    compatible:
>      enum:
> +      - microchip,zl30643

[Severity: Medium]
Are there accompanying driver changes for this new compatible string, or is
this regression expected to be addressed in a subsequent patch in a series?

If a device tree uses this new compatible string, it appears the device will
fail to bind and probe. The zl3073x_i2c_of_match table in
drivers/dpll/zl3073x/i2c.c and the zl3073x_spi_of_match table in
drivers/dpll/zl3073x/spi.c currently do not include "microchip,zl30643". 

Additionally, the commit message mentions the ZL30643 has a chip ID of
0x0E3B, but this ID is missing from the zl3073x_chip_ids array in
drivers/dpll/zl3073x/core.c. Without it, zl3073x_dev_probe() will fail to
identify the device and return -ENODEV.

>        - microchip,zl30731
>        - microchip,zl30732
>        - microchip,zl30733

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260724-for-upstream-zl30643-v1-0-ea93ba4d85c8@free.fr?part=1