From: Tao Cui <cui.tao@linux.dev>
To: zeng_chi911@163.com
Cc: chenhuacai@kernel.org, kernel@xen0n.name, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org, loongarch@lists.linux.dev,
maobibo@loongson.cn, stable@vger.kernel.org, zengchi@kylinos.cn,
zhaotianrui@loongson.cn, cui.tao@linux.dev, cuitao@kylinos.cn
Subject: Re: [PATCH 1/2] LoongArch: KVM: Fix PC double advance in kernel MMIO read fast path
Date: Sat, 25 Jul 2026 11:38:20 +0800 [thread overview]
Message-ID: <20260725033820.21904-1-cui.tao@linux.dev> (raw)
In-Reply-To: <20260723111552.1623996-1-zeng_chi911@163.com>
From: Tao Cui <cuitao@kylinos.cn>
> In the in-kernel MMIO read fast path of kvm_emu_mmio_read(),
> kvm_complete_mmio_read() already advances the guest PC via update_pc().
> The explicit update_pc() call right after it advances the PC a second
> time, so PC moves forward by 8 instead of 4 and the instruction
> following the MMIO read is silently skipped.
Good catch!
Reviewed-by: Tao Cui <cuitao@kylinos.cn>
prev parent reply other threads:[~2026-07-25 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 11:15 [PATCH 1/2] LoongArch: KVM: Fix PC double advance in kernel MMIO read fast path Zeng Chi
2026-07-24 1:23 ` Bibo Mao
2026-07-25 3:38 ` Tao Cui [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260725033820.21904-1-cui.tao@linux.dev \
--to=cui.tao@linux.dev \
--cc=chenhuacai@kernel.org \
--cc=cuitao@kylinos.cn \
--cc=kernel@xen0n.name \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=maobibo@loongson.cn \
--cc=stable@vger.kernel.org \
--cc=zeng_chi911@163.com \
--cc=zengchi@kylinos.cn \
--cc=zhaotianrui@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.