From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85D70348C7C for ; Sat, 25 Jul 2026 05:17:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784956635; cv=none; b=GDoC8uyv4VlMiOlWFaUyhHGdfbdUYxoyv31pUWMv48SA2atDIiggxNWK9IEvKzwZ8tMl2tvRUtVx8B2l7GZRtjV8oFazOCwBISMg5WZiT+NXsuATxImIuA/TbNTGWVPyhTM1OVhF5/mwLiORQB6SLZBmVYYHHaR4b2mCWPrKIl4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784956635; c=relaxed/simple; bh=nAle3ZClXxMagcNPp8+34Wi40EM/Aq2BXNS8bYyljxA=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Hap9wRYdZC4kG5W0ww7UG7JRFKcKHMr6gRMSxHnLq91zzB1bZuC7sg0NIuiLH3hCrZZqIW1vfbn0KNjSlsNFO8At2/RfWSl5mOcsivsyzIQB3G99w6kh65Q0ophH1XqiZIICdb1zG/HUArxmKRBL+DR3433C9S5H45KtHr8woKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C0Bv2Ld4; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C0Bv2Ld4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B60E61F000E9; Sat, 25 Jul 2026 05:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784956634; bh=Utnein2fnJxWftuwWQeGdjOhiB9dMIZV1q9PqnQrr98=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=C0Bv2Ld40wQ6+8vikGOaoSPlyWlzyzUAZvzV0WPqrzN784v6ooPSmkEpqV6WFnNAh 3x0H/uGa83P6nqOEW0A4k9+BZgsT9bfY/yes+XT13U0yHijA0M5prTtCjg/6Y2Tt/F eAbG8eEDTRmNZ5ugwQvjwBQX6eYq3xhz2G/w9paOr9G39DtJYn2T0xjHHtuMneJlR6 YJt9TlPxwnSXtyKIqXpFs98c5sMknkdDQrRheydjraXz6K/74RA75D4uyisCudat6j h2AgvMXb1POCuR0bTqB2nU2XoX0EuSlpP50SxZEM9twWjsgsCvAW5z48xPKWLbmIy5 mdfjA8XQo8Ccg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 11/17] drm/spacemit: add Saturn DPU DRM device driver Reply-To: sashiko-reviews@lists.linux.dev To: "Cody Kang" Cc: vkoul@kernel.org, robh@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org In-Reply-To: <20260724-k3-display-v1-11-f22a10a52867@gmail.com> References: <20260724-k3-display-v1-0-f22a10a52867@gmail.com> <20260724-k3-display-v1-11-f22a10a52867@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 25 Jul 2026 05:17:13 +0000 Message-Id: <20260725051713.B60E61F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Missing IS_ERR() check for 'match' causes an ERR_PTR dereference i= nside component_master_add_with_match(). - [Medium] The atomic commit tail stalls the commit pipeline by waiting for= flip completion before signaling hardware done. -- --- Patch [11]: [PATCH 11/17] drm/spacemit: add Saturn DPU DRM device drive= r --- commit e12174b9614adeccb5a06f03b5944837004e96f4 Author: Cody Kang drm/spacemit: add Saturn DPU DRM device driver This commit adds the DRM device for the SpacemiT K3 Saturn display processi= ng unit. The SoC has two DPU instances, each driving one CRTC that scans out a single primary plane in linear RGB, feeding a downstream DP/eDP controller over an OF-graph endpoint. > diff --git a/drivers/gpu/drm/spacemit/spacemit_drm.c b/drivers/gpu/drm/sp= acemit/spacemit_drm.c > new file mode 100644 > --- /dev/null > +++ b/drivers/gpu/drm/spacemit/spacemit_drm.c > @@ -0,0 +1,132 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Copyright (C) 2025-2026 SpacemiT Co., Ltd. > + * > + */ [ ... ] > +static void spacemit_drm_atomic_commit_tail(struct drm_atomic_commit *ol= d_state) > +{ > + struct drm_device *dev =3D old_state->dev; > + > + drm_atomic_helper_commit_modeset_disables(dev, old_state); > + > + drm_atomic_helper_commit_modeset_enables(dev, old_state); > + > + drm_atomic_helper_commit_planes(dev, old_state, > + DRM_PLANE_COMMIT_ACTIVE_ONLY); > + > + drm_atomic_helper_wait_for_flip_done(dev, old_state); > + > + drm_atomic_helper_commit_hw_done(old_state); [Severity: Medium] Does calling drm_atomic_helper_wait_for_flip_done() before drm_atomic_helper_commit_hw_done() stall the commit pipeline? By waiting for the flip completion before signaling hardware done, the CPU = work for the next frame (such as state preparation and buffer pinning) is blocked until the hardware flip completes. Should commit_hw_done() be called before wait_for_flip_done() to avoid degrading atomic commit performance? > + > + drm_atomic_helper_cleanup_planes(dev, old_state); > +} [ ... ] > +int spacemit_drm_of_component_probe(struct device *dev) > +{ > + struct device_node *ports, *port, *ep; > + struct device_node *remote; > + struct component_match *match =3D NULL; [ ... ] > + for_each_child_of_node(ports, port) { > + if (!of_node_name_eq(port, "port")) > + continue; > + for_each_child_of_node(port, ep) { > + if (!of_node_name_eq(ep, "endpoint")) > + continue; > + remote =3D of_graph_get_remote_port_parent(ep); > + if (!remote) > + continue; > + if (of_device_is_available(remote)) > + drm_of_component_match_add(dev, &match, > + compare_of, remote); > + of_node_put(remote); > + } > + } > + of_node_put(ports); > + > + if (!match) { > + dev_err(dev, "no downstream component available\n"); > + return -ENODEV; > + } > + > + return component_master_add_with_match(dev, &spacemit_drm_master_ops, > + match); [Severity: High] Can match be an ERR_PTR here instead of just NULL? If memory allocation fails inside drm_of_component_match_add(), it can set the match pointer to an ERR_PTR. Since the code only checks if (!match), an error pointer would bypass this check and be passed directly to component_master_add_with_match(). Looking at component_master_add_with_match(), it immediately accesses the pointer: drivers/base/component.c:component_master_add_with_match() { ... /* Reallocate the match array for its true size */ ret =3D component_match_realloc(match, match->num); ... } Should this code check IS_ERR(match) to prevent a potential kernel panic under memory pressure? > +} --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260724-k3-display= -v1-0-f22a10a52867@gmail.com?part=3D11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48A6EC53200 for ; Sat, 25 Jul 2026 05:17:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e1xhq+0fwWtyMv6XYo/AqeSQwsQC4S7/mDM1oClf5bA=; b=AV4d9FgSiNoxH/ rrURRQF2i0Orvhp1GmFVEDjkKxzQ7Ewr7ekkG3VWTVo7WdPgbYtXSARKkeADf6JQGJMXeKkZoESLy rOVc2gpobd+Tc8wUxL96F+fL5P64JeUwfL7OMGlKj1m/paaO0Gwi659hptZ4aJ5qMpMq8aHzHkYXJ 5iVIbM/qWwv4alJ5qxRhUwuFhapD2JL19oXhXaBb/zKUm/q+bo6hEXf55JgA/Lq+Bi/6NYWGwlHDM G6tTi4PTzM9/kqlmXjr6SOoxJEKC45akqibrT1h/xntOuEX94Ef38bH526UfYjiru2Wa9fOZr0+GN yqr1gmR4a3t49qF5ZIEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnUlA-000000003yY-4A9b; Sat, 25 Jul 2026 05:17:16 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnUl8-000000003yO-2vnQ for linux-phy@lists.infradead.org; Sat, 25 Jul 2026 05:17:14 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 508CB40430; Sat, 25 Jul 2026 05:17:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B60E61F000E9; Sat, 25 Jul 2026 05:17:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784956634; bh=Utnein2fnJxWftuwWQeGdjOhiB9dMIZV1q9PqnQrr98=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=C0Bv2Ld40wQ6+8vikGOaoSPlyWlzyzUAZvzV0WPqrzN784v6ooPSmkEpqV6WFnNAh 3x0H/uGa83P6nqOEW0A4k9+BZgsT9bfY/yes+XT13U0yHijA0M5prTtCjg/6Y2Tt/F eAbG8eEDTRmNZ5ugwQvjwBQX6eYq3xhz2G/w9paOr9G39DtJYn2T0xjHHtuMneJlR6 YJt9TlPxwnSXtyKIqXpFs98c5sMknkdDQrRheydjraXz6K/74RA75D4uyisCudat6j h2AgvMXb1POCuR0bTqB2nU2XoX0EuSlpP50SxZEM9twWjsgsCvAW5z48xPKWLbmIy5 mdfjA8XQo8Ccg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 11/17] drm/spacemit: add Saturn DPU DRM device driver To: "Cody Kang" Cc: vkoul@kernel.org, robh@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, olteanv@gmail.com, linux-phy@lists.infradead.org, neil.armstrong@linaro.org, devicetree@vger.kernel.org In-Reply-To: <20260724-k3-display-v1-11-f22a10a52867@gmail.com> References: <20260724-k3-display-v1-0-f22a10a52867@gmail.com> <20260724-k3-display-v1-11-f22a10a52867@gmail.com> Date: Sat, 25 Jul 2026 05:17:13 +0000 Message-Id: <20260725051713.B60E61F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgSVNfRVJS KCkgY2hlY2sgZm9yICdtYXRjaCcgY2F1c2VzIGFuIEVSUl9QVFIgZGVyZWZlcmVuY2UgaW5zaWRl IGNvbXBvbmVudF9tYXN0ZXJfYWRkX3dpdGhfbWF0Y2goKS4KLSBbTWVkaXVtXSBUaGUgYXRvbWlj IGNvbW1pdCB0YWlsIHN0YWxscyB0aGUgY29tbWl0IHBpcGVsaW5lIGJ5IHdhaXRpbmcgZm9yIGZs aXAgY29tcGxldGlvbiBiZWZvcmUgc2lnbmFsaW5nIGhhcmR3YXJlIGRvbmUuCi0tCgotLS0gUGF0 Y2ggWzExXTogW1BBVENIIDExLzE3XSBkcm0vc3BhY2VtaXQ6IGFkZCBTYXR1cm4gRFBVIERSTSBk ZXZpY2UgZHJpdmVyIC0tLQpjb21taXQgZTEyMTc0Yjk2MTRhZGVjY2I1YTA2ZjAzYjU5NDQ4Mzcw MDRlOTZmNApBdXRob3I6IENvZHkgS2FuZyA8Y29keWthbmcuaGtAZ21haWwuY29tPgoKZHJtL3Nw YWNlbWl0OiBhZGQgU2F0dXJuIERQVSBEUk0gZGV2aWNlIGRyaXZlcgoKVGhpcyBjb21taXQgYWRk cyB0aGUgRFJNIGRldmljZSBmb3IgdGhlIFNwYWNlbWlUIEszIFNhdHVybiBkaXNwbGF5IHByb2Nl c3NpbmcKdW5pdC4gVGhlIFNvQyBoYXMgdHdvIERQVSBpbnN0YW5jZXMsIGVhY2ggZHJpdmluZyBv bmUgQ1JUQyB0aGF0IHNjYW5zIG91dCBhCnNpbmdsZSBwcmltYXJ5IHBsYW5lIGluIGxpbmVhciBS R0IsIGZlZWRpbmcgYSBkb3duc3RyZWFtIERQL2VEUCBjb250cm9sbGVyCm92ZXIgYW4gT0YtZ3Jh cGggZW5kcG9pbnQuCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc3BhY2VtaXQvc3Bh Y2VtaXRfZHJtLmMgYi9kcml2ZXJzL2dwdS9kcm0vc3BhY2VtaXQvc3BhY2VtaXRfZHJtLmMKPiBu ZXcgZmlsZSBtb2RlIDEwMDY0NAo+IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vc3BhY2VtaXQvc3BhY2VtaXRfZHJtLmMKPiBAQCAtMCwwICsxLDEzMiBAQAo+ICsvLyBTUERY LUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMAo+ICsvKgo+ICsgKiBDb3B5cmlnaHQgKEMpIDIw MjUtMjAyNiBTcGFjZW1pVCBDby4sIEx0ZC4KPiArICoKPiArICovCgpbIC4uLiBdCgo+ICtzdGF0 aWMgdm9pZCBzcGFjZW1pdF9kcm1fYXRvbWljX2NvbW1pdF90YWlsKHN0cnVjdCBkcm1fYXRvbWlj X2NvbW1pdCAqb2xkX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gb2xk X3N0YXRlLT5kZXY7Cj4gKwo+ICsJZHJtX2F0b21pY19oZWxwZXJfY29tbWl0X21vZGVzZXRfZGlz YWJsZXMoZGV2LCBvbGRfc3RhdGUpOwo+ICsKPiArCWRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9t b2Rlc2V0X2VuYWJsZXMoZGV2LCBvbGRfc3RhdGUpOwo+ICsKPiArCWRybV9hdG9taWNfaGVscGVy X2NvbW1pdF9wbGFuZXMoZGV2LCBvbGRfc3RhdGUsCj4gKwkJCQkJRFJNX1BMQU5FX0NPTU1JVF9B Q1RJVkVfT05MWSk7Cj4gKwo+ICsJZHJtX2F0b21pY19oZWxwZXJfd2FpdF9mb3JfZmxpcF9kb25l KGRldiwgb2xkX3N0YXRlKTsKPiArCj4gKwlkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9u ZShvbGRfc3RhdGUpOwoKW1NldmVyaXR5OiBNZWRpdW1dCkRvZXMgY2FsbGluZyBkcm1fYXRvbWlj X2hlbHBlcl93YWl0X2Zvcl9mbGlwX2RvbmUoKSBiZWZvcmUKZHJtX2F0b21pY19oZWxwZXJfY29t bWl0X2h3X2RvbmUoKSBzdGFsbCB0aGUgY29tbWl0IHBpcGVsaW5lPwoKQnkgd2FpdGluZyBmb3Ig dGhlIGZsaXAgY29tcGxldGlvbiBiZWZvcmUgc2lnbmFsaW5nIGhhcmR3YXJlIGRvbmUsIHRoZSBD UFUgd29yawpmb3IgdGhlIG5leHQgZnJhbWUgKHN1Y2ggYXMgc3RhdGUgcHJlcGFyYXRpb24gYW5k IGJ1ZmZlciBwaW5uaW5nKSBpcyBibG9ja2VkCnVudGlsIHRoZSBoYXJkd2FyZSBmbGlwIGNvbXBs ZXRlcy4KClNob3VsZCBjb21taXRfaHdfZG9uZSgpIGJlIGNhbGxlZCBiZWZvcmUgd2FpdF9mb3Jf ZmxpcF9kb25lKCkgdG8gYXZvaWQKZGVncmFkaW5nIGF0b21pYyBjb21taXQgcGVyZm9ybWFuY2U/ Cgo+ICsKPiArCWRybV9hdG9taWNfaGVscGVyX2NsZWFudXBfcGxhbmVzKGRldiwgb2xkX3N0YXRl KTsKPiArfQoKWyAuLi4gXQoKPiAraW50IHNwYWNlbWl0X2RybV9vZl9jb21wb25lbnRfcHJvYmUo c3RydWN0IGRldmljZSAqZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgZGV2aWNlX25vZGUgKnBvcnRzLCAq cG9ydCwgKmVwOwo+ICsJc3RydWN0IGRldmljZV9ub2RlICpyZW1vdGU7Cj4gKwlzdHJ1Y3QgY29t cG9uZW50X21hdGNoICptYXRjaCA9IE5VTEw7CgpbIC4uLiBdCgo+ICsJZm9yX2VhY2hfY2hpbGRf b2Zfbm9kZShwb3J0cywgcG9ydCkgewo+ICsJCWlmICghb2Zfbm9kZV9uYW1lX2VxKHBvcnQsICJw b3J0IikpCj4gKwkJCWNvbnRpbnVlOwo+ICsJCWZvcl9lYWNoX2NoaWxkX29mX25vZGUocG9ydCwg ZXApIHsKPiArCQkJaWYgKCFvZl9ub2RlX25hbWVfZXEoZXAsICJlbmRwb2ludCIpKQo+ICsJCQkJ Y29udGludWU7Cj4gKwkJCXJlbW90ZSA9IG9mX2dyYXBoX2dldF9yZW1vdGVfcG9ydF9wYXJlbnQo ZXApOwo+ICsJCQlpZiAoIXJlbW90ZSkKPiArCQkJCWNvbnRpbnVlOwo+ICsJCQlpZiAob2ZfZGV2 aWNlX2lzX2F2YWlsYWJsZShyZW1vdGUpKQo+ICsJCQkJZHJtX29mX2NvbXBvbmVudF9tYXRjaF9h ZGQoZGV2LCAmbWF0Y2gsCj4gKwkJCQkJCQkgICBjb21wYXJlX29mLCByZW1vdGUpOwo+ICsJCQlv Zl9ub2RlX3B1dChyZW1vdGUpOwo+ICsJCX0KPiArCX0KPiArCW9mX25vZGVfcHV0KHBvcnRzKTsK PiArCj4gKwlpZiAoIW1hdGNoKSB7Cj4gKwkJZGV2X2VycihkZXYsICJubyBkb3duc3RyZWFtIGNv bXBvbmVudCBhdmFpbGFibGVcbiIpOwo+ICsJCXJldHVybiAtRU5PREVWOwo+ICsJfQo+ICsKPiAr CXJldHVybiBjb21wb25lbnRfbWFzdGVyX2FkZF93aXRoX21hdGNoKGRldiwgJnNwYWNlbWl0X2Ry bV9tYXN0ZXJfb3BzLAo+ICsJCQkJCSAgICAgICBtYXRjaCk7CgpbU2V2ZXJpdHk6IEhpZ2hdCkNh biBtYXRjaCBiZSBhbiBFUlJfUFRSIGhlcmUgaW5zdGVhZCBvZiBqdXN0IE5VTEw/CgpJZiBtZW1v cnkgYWxsb2NhdGlvbiBmYWlscyBpbnNpZGUgZHJtX29mX2NvbXBvbmVudF9tYXRjaF9hZGQoKSwg aXQgY2FuIHNldAp0aGUgbWF0Y2ggcG9pbnRlciB0byBhbiBFUlJfUFRSLiBTaW5jZSB0aGUgY29k ZSBvbmx5IGNoZWNrcyBpZiAoIW1hdGNoKSwgYW4KZXJyb3IgcG9pbnRlciB3b3VsZCBieXBhc3Mg dGhpcyBjaGVjayBhbmQgYmUgcGFzc2VkIGRpcmVjdGx5IHRvCmNvbXBvbmVudF9tYXN0ZXJfYWRk X3dpdGhfbWF0Y2goKS4KCkxvb2tpbmcgYXQgY29tcG9uZW50X21hc3Rlcl9hZGRfd2l0aF9tYXRj aCgpLCBpdCBpbW1lZGlhdGVseSBhY2Nlc3NlcyB0aGUKcG9pbnRlcjoKCmRyaXZlcnMvYmFzZS9j b21wb25lbnQuYzpjb21wb25lbnRfbWFzdGVyX2FkZF93aXRoX21hdGNoKCkgewogICAgLi4uCgkv KiBSZWFsbG9jYXRlIHRoZSBtYXRjaCBhcnJheSBmb3IgaXRzIHRydWUgc2l6ZSAqLwoJcmV0ID0g Y29tcG9uZW50X21hdGNoX3JlYWxsb2MobWF0Y2gsIG1hdGNoLT5udW0pOwogICAgLi4uCn0KClNo b3VsZCB0aGlzIGNvZGUgY2hlY2sgSVNfRVJSKG1hdGNoKSB0byBwcmV2ZW50IGEgcG90ZW50aWFs IGtlcm5lbCBwYW5pYwp1bmRlciBtZW1vcnkgcHJlc3N1cmU/Cgo+ICt9CgotLSAKU2FzaGlrbyBB SSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzI0LWszLWRp c3BsYXktdjEtMC1mMjJhMTBhNTI4NjdAZ21haWwuY29tP3BhcnQ9MTEKCi0tIApsaW51eC1waHkg bWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo=