From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E72F3C531D0 for ; Sat, 25 Jul 2026 05:20:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4286310E663; Sat, 25 Jul 2026 05:20:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="kllQWRX2"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 92AF410E663 for ; Sat, 25 Jul 2026 05:20:11 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4E70D42A1C; Sat, 25 Jul 2026 05:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA5FD1F000E9; Sat, 25 Jul 2026 05:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784956811; bh=IA9z5D4ZArJj0QrrlSo1OconEddOByGPua3AQf+cpZI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kllQWRX2YHFW4STyjT004YbM9wRxyJXpAUDhmB/8Fy0CrS4XPI1XdIekEdsneanYu 9dI3ngHRUrinO1L83Ofc/+dbmaW3C6cxV9SftazAzNO/rPFCyM6iqpKBAvw4eGayz0 ZSkQIDXDaffH7ceWmMqg5OfRP2qkz8FEvYXtZt97FXBYY95bIBEG0XUY4y0qAGtOW7 V90OG0adVIWSB7s3YYPphjMdSe66qWGVyT3oE8lNHE4I3P/acGGA4BEivPFrd2eH7U jg1Hjv169VwuuyT0SAbMyys1GiIS869qT+t0wHo40TiOM7LsQMvjn+wsCyFyaAiwHc 0qgmhrrsXeApg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 14/17] riscv: dts: spacemit: k3: add display nodes To: "Cody Kang" Cc: neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, vkoul@kernel.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260724-k3-display-v1-14-f22a10a52867@gmail.com> References: <20260724-k3-display-v1-0-f22a10a52867@gmail.com> <20260724-k3-display-v1-14-f22a10a52867@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sat, 25 Jul 2026 05:20:10 +0000 Message-Id: <20260725052010.AA5FD1F000E9@smtp.kernel.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: - [High] Cyclic DT dependency between DP controllers, their child PHY nodes= , and the APMU syscon will cause a fw_devlink warning and a potential -EPRO= BE_DEFER deadlock. - [Medium] Fragile array override of `syscon_apmu` clocks creates a severe = maintenance hazard. -- --- Patch [14]: [PATCH 14/17] riscv: dts: spacemit: k3: add display nodes -= -- commit c12c6ab932374f52bfc3ce3d04640d8193a9bfea Author: Cody Kang riscv: dts: spacemit: k3: add display nodes Add the SoC-level display nodes: the two Saturn DPUs, the two DP/eDP controllers with their PHY children. > diff --git a/arch/riscv/boot/dts/spacemit/k3-display.dtsi b/arch/riscv/bo= ot/dts/spacemit/k3-display.dtsi > new file mode 100644 > index 0000000000000..4892ee6acda22 > --- /dev/null > +++ b/arch/riscv/boot/dts/spacemit/k3-display.dtsi [ ... ] > + edp0: edp@cac84000 { > + compatible =3D "spacemit,k3-inno-dp"; > + reg =3D <0x0 0xcac84000 0x0 0x4000>; > + interrupts =3D <132 IRQ_TYPE_LEVEL_HIGH>; > + clocks =3D <&syscon_apmu CLK_APMU_EDP0_PXCLK>, <&edp0_phy>; [Severity: High] Does this create a cyclical dependency that could cause a fw_devlink warning or a permanent probe deadlock? edp0 depends on syscon_apmu here, while syscon_apmu depends on the edp0_phy child node below. Since edp0_phy is a child of edp0, it won't be populated until edp0 probes. If fw_devlink breaks the cycle by dropping the edp0 -> syscon_apmu link, edp0 will attempt to probe first, fail to get its clock, = and defer forever because it will not proceed to populate the child PHY. > + clock-names =3D "pxclk", "pll"; > + resets =3D <&syscon_apmu RESET_APMU_EDP0>; > + phys =3D <&edp0_phy>; > + phy-names =3D "dp"; > + status =3D "disabled"; > + > + edp0_phy: phy { > + compatible =3D "spacemit,k3-inno-dp-phy"; > + #phy-cells =3D <0>; > + #clock-cells =3D <0>; > + clock-output-names =3D "edp0_pll_pxclk"; > + }; [ ... ] > +/* > + * Feed the PHY PLL pixel clocks back in as the APMU mux parents. This l= ives > + * here, not in k3.dtsi: the PHYs only exist where this file is included. > + */ > +&syscon_apmu { > + clocks =3D <&osc_32k>, <&vctcxo_1m>, <&vctcxo_3m>, <&vctcxo_24m>, > + <&edp0_phy>, <&dp1_phy>; > + clock-names =3D "osc", "vctcxo_1m", "vctcxo_3m", "vctcxo_24m", > + "edp0_pll_pxclk", "edp1_pll_pxclk"; [Severity: Medium] Will overriding the clocks property completely drop any future additions ma= de to the syscon_apmu node in the base k3.dtsi? Device tree doesn't support appending to array properties, so if any new cl= ocks are added to the base syscon_apmu node later, this file will silently overr= ide them and break other subsystems relying on those clocks. > +}; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260724-k3-display= -v1-0-f22a10a52867@gmail.com?part=3D14 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7B07C531C9 for ; Sat, 25 Jul 2026 05:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TifqZykulpBLY9ywFq5i+2hcBhuBTmvzqGGiWJJXk5o=; b=yFyZKyg3IaQPAR thV/VbuhoRioWjch4n5ybZLj5opC/WhRw5jfACu7uZTcDJtakDKmFUDxv0YGGM/m0hzrvvKDSVZ7q BudIHDYKDvhSvLEXr7PYhaoJyiGQrbYu2LFeWueSfZQIeg86hhKqcj0bYCbUsKgUyAOWLwuBsB1H4 FgXEKdx0sBcEsorhvOev8mLoGru/80LbPZGIiC7KJVsFAZrHL8gmrL4wAufhp7Pr2PVAlAnuv/PjV qiuzBLCslB2XPPQbe0SThPRlGc5TK9ruMRIfUE61SlJqUFNKFtOKywdIQ4kbQZOrSjZkaFgkwmwjy G43qZtmfEb3vgaBmYyiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnUo1-000000004E0-26Dg; Sat, 25 Jul 2026 05:20:13 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wnUnz-000000004Di-2h3r for linux-phy@lists.infradead.org; Sat, 25 Jul 2026 05:20:11 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 4E70D42A1C; Sat, 25 Jul 2026 05:20:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA5FD1F000E9; Sat, 25 Jul 2026 05:20:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784956811; bh=IA9z5D4ZArJj0QrrlSo1OconEddOByGPua3AQf+cpZI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=kllQWRX2YHFW4STyjT004YbM9wRxyJXpAUDhmB/8Fy0CrS4XPI1XdIekEdsneanYu 9dI3ngHRUrinO1L83Ofc/+dbmaW3C6cxV9SftazAzNO/rPFCyM6iqpKBAvw4eGayz0 ZSkQIDXDaffH7ceWmMqg5OfRP2qkz8FEvYXtZt97FXBYY95bIBEG0XUY4y0qAGtOW7 V90OG0adVIWSB7s3YYPphjMdSe66qWGVyT3oE8lNHE4I3P/acGGA4BEivPFrd2eH7U jg1Hjv169VwuuyT0SAbMyys1GiIS869qT+t0wHo40TiOM7LsQMvjn+wsCyFyaAiwHc 0qgmhrrsXeApg== From: sashiko-bot@kernel.org Subject: Re: [PATCH 14/17] riscv: dts: spacemit: k3: add display nodes To: "Cody Kang" Cc: neil.armstrong@linaro.org, linux-phy@lists.infradead.org, olteanv@gmail.com, dri-devel@lists.freedesktop.org, vkoul@kernel.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260724-k3-display-v1-14-f22a10a52867@gmail.com> References: <20260724-k3-display-v1-0-f22a10a52867@gmail.com> <20260724-k3-display-v1-14-f22a10a52867@gmail.com> Date: Sat, 25 Jul 2026 05:20:10 +0000 Message-Id: <20260725052010.AA5FD1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIEN5Y2xpYyBEVCBkZXBl bmRlbmN5IGJldHdlZW4gRFAgY29udHJvbGxlcnMsIHRoZWlyIGNoaWxkIFBIWSBub2RlcywgYW5k IHRoZSBBUE1VIHN5c2NvbiB3aWxsIGNhdXNlIGEgZndfZGV2bGluayB3YXJuaW5nIGFuZCBhIHBv dGVudGlhbCAtRVBST0JFX0RFRkVSIGRlYWRsb2NrLgotIFtNZWRpdW1dIEZyYWdpbGUgYXJyYXkg b3ZlcnJpZGUgb2YgYHN5c2Nvbl9hcG11YCBjbG9ja3MgY3JlYXRlcyBhIHNldmVyZSBtYWludGVu YW5jZSBoYXphcmQuCi0tCgotLS0gUGF0Y2ggWzE0XTogW1BBVENIIDE0LzE3XSByaXNjdjogZHRz OiBzcGFjZW1pdDogazM6IGFkZCBkaXNwbGF5IG5vZGVzIC0tLQpjb21taXQgYzEyYzZhYjkzMjM3 NGY1MmJmYzNjZTNkMDQ2NDBkODE5M2E5YmZlYQpBdXRob3I6IENvZHkgS2FuZyA8Y29keWthbmcu aGtAZ21haWwuY29tPgoKcmlzY3Y6IGR0czogc3BhY2VtaXQ6IGszOiBhZGQgZGlzcGxheSBub2Rl cwoKQWRkIHRoZSBTb0MtbGV2ZWwgZGlzcGxheSBub2RlczogdGhlIHR3byBTYXR1cm4gRFBVcywg dGhlIHR3byBEUC9lRFAKY29udHJvbGxlcnMgd2l0aCB0aGVpciBQSFkgY2hpbGRyZW4uCgo+IGRp ZmYgLS1naXQgYS9hcmNoL3Jpc2N2L2Jvb3QvZHRzL3NwYWNlbWl0L2szLWRpc3BsYXkuZHRzaSBi L2FyY2gvcmlzY3YvYm9vdC9kdHMvc3BhY2VtaXQvazMtZGlzcGxheS5kdHNpCj4gbmV3IGZpbGUg bW9kZSAxMDA2NDQKPiBpbmRleCAwMDAwMDAwMDAwMDAwLi40ODkyZWU2YWNkYTIyCj4gLS0tIC9k ZXYvbnVsbAo+ICsrKyBiL2FyY2gvcmlzY3YvYm9vdC9kdHMvc3BhY2VtaXQvazMtZGlzcGxheS5k dHNpCgpbIC4uLiBdCgo+ICsJZWRwMDogZWRwQGNhYzg0MDAwIHsKPiArCQljb21wYXRpYmxlID0g InNwYWNlbWl0LGszLWlubm8tZHAiOwo+ICsJCXJlZyA9IDwweDAgMHhjYWM4NDAwMCAweDAgMHg0 MDAwPjsKPiArCQlpbnRlcnJ1cHRzID0gPDEzMiBJUlFfVFlQRV9MRVZFTF9ISUdIPjsKPiArCQlj bG9ja3MgPSA8JnN5c2Nvbl9hcG11IENMS19BUE1VX0VEUDBfUFhDTEs+LCA8JmVkcDBfcGh5PjsK CltTZXZlcml0eTogSGlnaF0KRG9lcyB0aGlzIGNyZWF0ZSBhIGN5Y2xpY2FsIGRlcGVuZGVuY3kg dGhhdCBjb3VsZCBjYXVzZSBhIGZ3X2Rldmxpbmsgd2FybmluZwpvciBhIHBlcm1hbmVudCBwcm9i ZSBkZWFkbG9jaz8KCmVkcDAgZGVwZW5kcyBvbiBzeXNjb25fYXBtdSBoZXJlLCB3aGlsZSBzeXNj b25fYXBtdSBkZXBlbmRzIG9uIHRoZSBlZHAwX3BoeQpjaGlsZCBub2RlIGJlbG93LiBTaW5jZSBl ZHAwX3BoeSBpcyBhIGNoaWxkIG9mIGVkcDAsIGl0IHdvbid0IGJlIHBvcHVsYXRlZAp1bnRpbCBl ZHAwIHByb2Jlcy4gSWYgZndfZGV2bGluayBicmVha3MgdGhlIGN5Y2xlIGJ5IGRyb3BwaW5nIHRo ZSBlZHAwIC0+CnN5c2Nvbl9hcG11IGxpbmssIGVkcDAgd2lsbCBhdHRlbXB0IHRvIHByb2JlIGZp cnN0LCBmYWlsIHRvIGdldCBpdHMgY2xvY2ssIGFuZApkZWZlciBmb3JldmVyIGJlY2F1c2UgaXQg d2lsbCBub3QgcHJvY2VlZCB0byBwb3B1bGF0ZSB0aGUgY2hpbGQgUEhZLgoKPiArCQljbG9jay1u YW1lcyA9ICJweGNsayIsICJwbGwiOwo+ICsJCXJlc2V0cyA9IDwmc3lzY29uX2FwbXUgUkVTRVRf QVBNVV9FRFAwPjsKPiArCQlwaHlzID0gPCZlZHAwX3BoeT47Cj4gKwkJcGh5LW5hbWVzID0gImRw IjsKPiArCQlzdGF0dXMgPSAiZGlzYWJsZWQiOwo+ICsKPiArCQllZHAwX3BoeTogcGh5IHsKPiAr CQkJY29tcGF0aWJsZSA9ICJzcGFjZW1pdCxrMy1pbm5vLWRwLXBoeSI7Cj4gKwkJCSNwaHktY2Vs bHMgPSA8MD47Cj4gKwkJCSNjbG9jay1jZWxscyA9IDwwPjsKPiArCQkJY2xvY2stb3V0cHV0LW5h bWVzID0gImVkcDBfcGxsX3B4Y2xrIjsKPiArCQl9OwoKWyAuLi4gXQoKPiArLyoKPiArICogRmVl ZCB0aGUgUEhZIFBMTCBwaXhlbCBjbG9ja3MgYmFjayBpbiBhcyB0aGUgQVBNVSBtdXggcGFyZW50 cy4gVGhpcyBsaXZlcwo+ICsgKiBoZXJlLCBub3QgaW4gazMuZHRzaTogdGhlIFBIWXMgb25seSBl eGlzdCB3aGVyZSB0aGlzIGZpbGUgaXMgaW5jbHVkZWQuCj4gKyAqLwo+ICsmc3lzY29uX2FwbXUg ewo+ICsJY2xvY2tzID0gPCZvc2NfMzJrPiwgPCZ2Y3RjeG9fMW0+LCA8JnZjdGN4b18zbT4sIDwm dmN0Y3hvXzI0bT4sCj4gKwkJIDwmZWRwMF9waHk+LCA8JmRwMV9waHk+Owo+ICsJY2xvY2stbmFt ZXMgPSAib3NjIiwgInZjdGN4b18xbSIsICJ2Y3RjeG9fM20iLCAidmN0Y3hvXzI0bSIsCj4gKwkJ ICAgICAgImVkcDBfcGxsX3B4Y2xrIiwgImVkcDFfcGxsX3B4Y2xrIjsKCltTZXZlcml0eTogTWVk aXVtXQpXaWxsIG92ZXJyaWRpbmcgdGhlIGNsb2NrcyBwcm9wZXJ0eSBjb21wbGV0ZWx5IGRyb3Ag YW55IGZ1dHVyZSBhZGRpdGlvbnMgbWFkZSB0bwp0aGUgc3lzY29uX2FwbXUgbm9kZSBpbiB0aGUg YmFzZSBrMy5kdHNpPwoKRGV2aWNlIHRyZWUgZG9lc24ndCBzdXBwb3J0IGFwcGVuZGluZyB0byBh cnJheSBwcm9wZXJ0aWVzLCBzbyBpZiBhbnkgbmV3IGNsb2NrcwphcmUgYWRkZWQgdG8gdGhlIGJh c2Ugc3lzY29uX2FwbXUgbm9kZSBsYXRlciwgdGhpcyBmaWxlIHdpbGwgc2lsZW50bHkgb3ZlcnJp ZGUKdGhlbSBhbmQgYnJlYWsgb3RoZXIgc3Vic3lzdGVtcyByZWx5aW5nIG9uIHRob3NlIGNsb2Nr cy4KCj4gK307CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8j L3BhdGNoc2V0LzIwMjYwNzI0LWszLWRpc3BsYXktdjEtMC1mMjJhMTBhNTI4NjdAZ21haWwuY29t P3BhcnQ9MTQKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xp bnV4LXBoeQo=