Re: [PATCH 1/3] dt-bindings: usb: tps6598x: Add sn201202x/ACE3

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] The `wakeup-source` property is missing from the binding schema despite the hardware supporting wake-up.
- [Low] The `reg` property lacks a `maxItems` boundary constraint.
--

--- Patch [1]: [PATCH 1/3] dt-bindings: usb: tps6598x: Add sn201202x/ACE3 ---
commit 9a24f811e68db136afd48ea26f05ded70940e705
Author: Sasha Finkelstein <k@chaosmail.tech>

dt-bindings: usb: tps6598x: Add sn201202x/ACE3

This commit adds a binding for the sn201202x, a variant of the tps6598x
Type-C Power Delivery controller attached to an SPMI bus on Apple M3 devices.

> diff --git a/Documentation/devicetree/bindings/usb/apple,sn201202x.yaml b/Documentation/devicetree/bindings/usb/apple,sn201202x.yaml
> new file mode 100644
> index 0000000000000..84d230ccccc7f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/apple,sn201202x.yaml
> @@ -0,0 +1,78 @@

[ ... ]

> +properties:
> +  compatible:
> +    enum:
> +      - apple,sn201202x
> +
> +  reg:
> +    minItems: 1

[Severity: Low]
Is a maxItems constraint also needed here?

Without a maxItems limit, the schema might silently accept device trees with
multiple register region entries, even if only one is expected on the SPMI
bus.

> +
> +  interrupts:
> +    items:
> +      - description: Primary irq used for tps6598x events
> +      - description: Logical register selection completed
> +      - description: Standby command completed
> +      - description: Wakeup command completed
> +
> +  interrupt-names:
> +    items:
> +      - const: irq
> +      - const: select
> +      - const: sleep
> +      - const: wake
> +
> +  connector:
> +    $ref: /schemas/connector/usb-connector.yaml#

[Severity: Medium]
Should a wakeup-source property be declared in this properties block?

Because the hardware supports a dedicated wake interrupt, the tps6598x driver
will likely query the wakeup-source property. Since additionalProperties is
set to false below, any board device tree that properly defines wakeup-source
will trigger validation errors during dt_binding_check.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260725-tipd-ace3-v1-0-73202d36138a@chaosmail.tech?part=1