From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 532413770B for ; Sat, 25 Jul 2026 17:52:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785001925; cv=none; b=CjDA6f8yPVIe73mInQXO+ArVwpNnR14eWsxWxM/hanYNBbfmUtFSo/tfGcFqdFhwrkKoscoyobWcKHU+z4C6sZ86Vj2f9VGStRh6LCIO9zB1Nhm8MdOCZsrGrd7XuzZkqgM25BPLW0wLS+48G48WgBdynAujIA9zxkvKVWFrR2Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785001925; c=relaxed/simple; bh=dmSLaF3JmSG03N473oGR1xv44ugjuUkoBFljlg4wI2s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ZXg2CXytVu9bPUYVKMRy7XKzXpUdp6YqIgOwfizMIPZMfUfwAdC9XDJGdc1TAktby20jrTBvRaTR8ZoG4E3ch+H4YtgSv1My766r9nlQo2hAxgQZM8QsrrF5Jv2oBO3X3/NSjUtWdcWO0RTOxLSeGgY0MmzOjFu2x/tfQjKhfSw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=pyJZn+uB; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="pyJZn+uB" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-38e07ebd263so993692a91.1 for ; Sat, 25 Jul 2026 10:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1785001922; x=1785606722; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=QTyixV4W5r/eynqu0K/4hqgUBWxGM5A/HW+QpMLLe5U=; b=pyJZn+uBWe7k/32lvG/lMlriprT/pIoUlpBqYWWD/vQUAq+Ct7BG4PWOSKhJY1am/B CtJROx4OpDEY4ArWjOuanEX7Bfx3RbpjGEczS0WvxXIZxz0mbbSl2FyOWteRTjukOk15 eC54kkxGq+kBP1qVcOveni97E0RaWlvfl1S0v5biwsCCVLGYmlCGCnWC2eTpdYECrjS3 wEMXgvd07nHZtfk9WRydqb+AolGamuBxvhROyZqkU1yfllJjgEi1WFU+E07/9Gg3Vgyb OtN1fL70I8guESiK3Pr2kp216sFxhQL3Obn5lqLPkay++dOaT7kVQBk2J8srlYbtStAI GFKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785001922; x=1785606722; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=QTyixV4W5r/eynqu0K/4hqgUBWxGM5A/HW+QpMLLe5U=; b=ZDeiPwkzMOGlL72f7//wd9yRwpyzdwH5/LCWJDBplJExz6bKmgm1l6dvAaBYMQ6BrR d01IqBMKJsdDf3GGfvV/l2GnmEak55pJh3CGeBeGFdy3308AJKMglrz9FfeIVXR1TMD7 RYnyoY5xxPhnYHnOgYVe/4w9Ba7MCrq7iTm0EX0KB6rNE2Q6gNwdKReXyZPO1XQTCRta xmuKVch/padGD8MdQ4uLouOXX3QSzeTOi6lI3zbcWdQ8GEa8OZ1MFN4XsXRRBFBCcvmm fGtwk6gsTEoqxZbeeGaa5/yWJuEAa1/rWseDbSSCZo2+ehKhskYEjXI2zHuLZoXYUOo3 8PHg== X-Forwarded-Encrypted: i=1; AHgh+RplhjpU7WaCKC9g+O4atbsHorCLjiew8GSI27ndOxlwKr6JH7CCI4VFqTtdJ2rMwVlS6wrV/PBS4ds8crY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1K9yiYUJT16XlYFNTg8qWvdWhCRzTPdorYwq3Rdlc7NJuJkZS BxLE2AVPx9l9MB2P5tfaoDWl5V8ua3gOE1tawr7QjgJ/4kjzjmebDnrM X-Gm-Gg: AR+sD12i26EpRX0mbS+UB783haLrzXUAtQOQ5WIXzKOfDi4W98J3UkjhAOr9vIGaUwp WYL37rFPCTl9Ibdp0H1uF9RoduCCEE66wJ/YWCHUGp3GoOIhuarqKewt69wrsak8bGwaqY0UB+p Pbp8Mgt3gTpf+1NNiWDCme3aqS4mDaysNq0dLl24WHZPv7awpxJfn3hRFSj4RTgXBprm5V58GPQ 3PGEeikc4yku5s2I5PKFF+emiFl5Q13lWpyUE8xd/pMjf20mRXS7Qq+A88kPDPCixL0xMftNGg7 UaN5w/vwhF3uFXIN4d8krgSWAZxUYTgTbKAqC1v+fIGp+tdRQ7VMhodoBh5XZXFTe+yzShauGij b9DRzEwW4IFnEQMoaPHdNSIGboIlKrLd+4xnXeyxzUUmU2rLCuXktLDRFTWr6lwrnqbWW3Xqtl1 DZduH95vMeYObv7eTyit6Y X-Received: by 2002:a17:90b:3811:b0:385:d033:d9f1 with SMTP id 98e67ed59e1d1-38f2961363cmr3133372a91.28.1785001921667; Sat, 25 Jul 2026 10:52:01 -0700 (PDT) Received: from localhost.localdomain ([2409:408d:79f:1f48:d3f7:8b5a:7633:b67]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13d2d1d0d1esm15485573c88.0.2026.07.25.10.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Jul 2026 10:52:01 -0700 (PDT) From: Arunachalam To: Lee Jones , Pavel Machek Cc: Andreas Werner , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, Arunachalam Subject: [PATCH 1/2] leds: menf21bmc: Use brightness_set_blocking instead of brightness_set Date: Sat, 25 Jul 2026 23:21:45 +0530 Message-Id: <20260725175145.31984-1-arun07172003@gmail.com> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20260725081938.422B11F000E9@smtp.kernel.org> References: <20260725081938.422B11F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit menf21bmc_led_set() takes a mutex and performs an I2C transaction, both of which can sleep. It was assigned to the non-blocking brightness_set callback, which the LED core may invoke from atomic context (e.g. via the timer or heartbeat triggers), risking a scheduling-while-atomic bug. Switch to brightness_set_blocking, which the LED core dispatches from a workqueue in safe, sleepable context. This also allows propagating I2C failures via the function's return value instead of silently discarding them. Signed-off-by: Arunachalam --- drivers/leds/leds-menf21bmc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/leds/leds-menf21bmc.c b/drivers/leds/leds-menf21bmc.c index a7e4db487..6b09e433a 100644 --- a/drivers/leds/leds-menf21bmc.c +++ b/drivers/leds/leds-menf21bmc.c @@ -49,7 +49,7 @@ static struct menf21bmc_led leds[] = { static DEFINE_MUTEX(led_lock); -static void +static int menf21bmc_led_set(struct led_classdev *led_cdev, enum led_brightness value) { int led_val; @@ -67,10 +67,11 @@ menf21bmc_led_set(struct led_classdev *led_cdev, enum led_brightness value) else led_val |= led->led_bit; - i2c_smbus_write_byte_data(led->i2c_client, + led_val = i2c_smbus_write_byte_data(led->i2c_client, BMC_CMD_LED_GET_SET, led_val); err_out: mutex_unlock(&led_lock); + return led_val; } static int menf21bmc_led_probe(struct platform_device *pdev) @@ -81,7 +82,7 @@ static int menf21bmc_led_probe(struct platform_device *pdev) for (i = 0; i < ARRAY_SIZE(leds); i++) { leds[i].cdev.name = leds[i].name; - leds[i].cdev.brightness_set = menf21bmc_led_set; + leds[i].cdev.brightness_set_blocking = menf21bmc_led_set; leds[i].i2c_client = i2c_client; ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev); if (ret < 0) -- 2.39.5