Re: [PATCH bpf-next v2 6/9] selftests/bpf: Add JIT-sequence tests for __arena kfunc arguments

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing test dependency check for `bpf_testmod.ko` in `test_arena_kfunc_jit()`.
--

--- Patch [6]: [PATCH bpf-next v2 6/9] selftests/bpf: Add JIT-sequence tests for __arena kfunc arguments ---
commit 127efe77c3180fef987aeb8dfccbc04666cf9935
Author: Tejun Heo <tj@kernel.org>

selftests/bpf: Add JIT-sequence tests for __arena kfunc arguments

This commit adds JIT-sequence tests for __arena and __arena_nullable
kfunc arguments on x86-64. It pins the exact rebase sequences the JITs
emit to verify correct code generation.

> diff --git a/tools/testing/selftests/bpf/prog_tests/arena_kfunc_jit.c b/tools/testing/selftests/bpf/prog_tests/arena_kfunc_jit.c
> new file mode 100644
> index 0000000000000..2359cde24c45d
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/arena_kfunc_jit.c
> @@ -0,0 +1,13 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2026 Meta Platforms, Inc. and affiliates. */
> +#include <test_progs.h>
> +#include "arena_kfunc_jit.skel.h"
> +
> +/*
> + * Runs with full capabilities: resolving module kfunc ksyms requires
> + * CAP_SYS_ADMIN, which rules out the capability-restricted runner.
> + */
> +void test_arena_kfunc_jit(void)
> +{
> +	RUN_TESTS(arena_kfunc_jit);
> +}

[Severity: Medium]
Since this test relies on kfuncs from bpf_testmod, should there be a check
for env.has_testmod before running the tests?

If the tests are run in an environment where bpf_testmod cannot be loaded,
this will fail with a verifier kfunc resolution error instead of skipping
gracefully.

For example, adding:

    if (!env.has_testmod) {
        test__skip();
        return;
    }

would allow the test runner to skip gracefully.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260726013105.3689867-1-memxor@gmail.com?part=6