From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5128C531C9 for ; Sun, 26 Jul 2026 15:02:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7wjDBlmPlbtbHmMd2ySAdDVXhzyFHqfye5d0ZEpPdZw=; b=zHAZJ2uw33F3FL JPfajb3t0z4YUV328LsxSLjSJVEbLA7lDQH+R1KOwD56iUXImtKIwvDKALOKod2QWXEWPR4pbS+If +/y8Z+rFM+F23ZH9HvFQaGDc55U5FdjGcmd4/jvI2HG3/CkuHVHJFRjH0Spw2SyRH4g3ewJwLBlVw QQJF6uHbeebqkEmxHnJg3isanGqQ6lDl7UPDCYha92GKbHMZ4UvbXQqhHKfg79PUj0jE7Pz1GRM7X NM+CYGoSfdv88TRPYDEXcTrexNd8eyWhZXhmGl1uUbjHkZPwPl8j7X7Fri6JkT6T9PqzXBUXjE2nb C5caZYy8FKb10N2F7m4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wo0NR-00000001HPQ-1n9K; Sun, 26 Jul 2026 15:02:53 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wo0NQ-00000001HPK-1gJ2 for linux-phy@lists.infradead.org; Sun, 26 Jul 2026 15:02:52 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id AD66160008; Sun, 26 Jul 2026 15:02:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8157C1F000E9; Sun, 26 Jul 2026 15:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785078171; bh=Z3DACBE56ZwFLMgfYQH7UyWpQ+If3ko8mfpG2U6ex9s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gPIUkq6z5EHLn3RqbfKo4Zo90FebBQ/Zka1MrKi287fel32OZK89e8n4UEqsHPFh+ rTh4MC0H42m1IhuReaOvRbUHTx58FEZ8z8YucKjg0kIgy2WCfH9mq6MTZ/ioUDyhr1 88mmu1rIk82JiwjrLHJFZsYuNIoP9DkyDcXtBJRNQCeuAtHB24exWSHcJQUadWziPD Oy1Z2S1wUn9Nww7udDALqV3ZH9GauBf+lFQFrzAkueBObIXwKi3O5OoR6OWz/OvYBY NDLwVlIAMds7Oqe20awakMR20/nmWCKf+cqTSeOB4nfrHO211rIG5RKsqPu1jvtSCF jt/rJpgqMkELA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/4] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-direction phys To: "Jason Yang" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, olteanv@gmail.com, robh@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, vkoul@kernel.org In-Reply-To: <20260726-dcphy-rx-v1-v2-1-cf9cc34a412a@gmail.com> References: <20260726-dcphy-rx-v1-v2-0-cf9cc34a412a@gmail.com> <20260726-dcphy-rx-v1-v2-1-cf9cc34a412a@gmail.com> Date: Sun, 26 Jul 2026 15:02:50 +0000 Message-Id: <20260726150250.8157C1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gVGhlIGR0LWJpbmRp bmcgYWxsb3dzIGAjcGh5LWNlbGxzID0gMmAgdG8gcmVwcmVzZW50IFBIWSBkaXJlY3Rpb24sIGJ1 dCB0aGUgY29ycmVzcG9uZGluZyBkcml2ZXIgYHBoeS1yb2NrY2hpcC1zYW1zdW5nLWRjcGh5LmNg IHdhcyBub3QgdXBkYXRlZCB0byBzdXBwb3J0IHRoaXMuCi0tCgotLS0gUGF0Y2ggWzFdOiBbUEFU Q0ggdjIgMS80XSBkdC1iaW5kaW5nczogcGh5OiByb2NrY2hpcCxyazM1ODgtbWlwaS1kY3BoeTog c3VwcG9ydCBwZXItZGlyZWN0aW9uIHBoeXMgLS0tCmNvbW1pdCA0MjFkMjY2ZmEzMzE4YzQ0Nzgw YzA5MjI0YTAzNGIwZWRlY2E5ZGIzCkF1dGhvcjogSmFzb24gWWFuZyA8amFzb245ODE2NkBnbWFp bC5jb20+ClN1YmplY3Q6IGR0LWJpbmRpbmdzOiBwaHk6IHJvY2tjaGlwLHJrMzU4OC1taXBpLWRj cGh5OiBzdXBwb3J0IHBlci1kaXJlY3Rpb24gcGh5cwoKVGhpcyBjb21taXQgdXBkYXRlcyB0aGUg Um9ja2NoaXAgUkszNTg4IE1JUEkgRC0vQy1QSFkgZGV2aWNlIHRyZWUgYmluZGluZwp0byBzdXBw b3J0IHBlci1kaXJlY3Rpb24gY29uZmlndXJhdGlvbi4gSXQgY2hhbmdlcyB0aGUgI3BoeS1jZWxs cyBwcm9wZXJ0eQp0byBhbGxvdyBlaXRoZXIgMSBvciAyIGNlbGxzLCB3aGVyZSB0aGUgb3B0aW9u YWwgc2Vjb25kIGNlbGwgc3BlY2lmaWVzIHRoZQpQSFkgZGlyZWN0aW9uIChUWCBvciBSWCkuCgo+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGh5L3JvY2tj aGlwLHJrMzU4OC1taXBpLWRjcGh5LnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvcGh5L3JvY2tjaGlwLHJrMzU4OC1taXBpLWRjcGh5LnlhbWwKPiBpbmRleCBjOGZmNWJh MjJhODZiLi42OGE0M2RiOWM2NjkwIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9waHkvcm9ja2NoaXAscmszNTg4LW1pcGktZGNwaHkueWFtbAo+ICsrKyBi L0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9waHkvcm9ja2NoaXAscmszNTg4LW1p cGktZGNwaHkueWFtbAo+IEBAIC0yMCwxMiArMjAsMjIgQEAgcHJvcGVydGllczoKPiAgICAgIG1h eEl0ZW1zOiAxCj4gIAo+ICAgICIjcGh5LWNlbGxzIjoKPiAtICAgIGNvbnN0OiAxCj4gKyAgICBl bnVtOiBbMSwgMl0KCltTZXZlcml0eTogTWVkaXVtXQpXaWxsIHRoaXMgbmV3IDItY2VsbCBjb25m aWd1cmF0aW9uIHdvcmsgd2l0aCB0aGUgY3VycmVudCBQSFkgZHJpdmVyPwoKTG9va2luZyBhdCBz YW1zdW5nX21pcGlfZGNwaHlfeGxhdGUoKSBpbgpkcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9j a2NoaXAtc2Ftc3VuZy1kY3BoeS5jLCB0aGUgZHJpdmVyIGV4cGxpY2l0bHkKcmVqZWN0cyBhbnl0 aGluZyBvdGhlciB0aGFuIDEgY2VsbDoKCglpZiAoYXJncy0+YXJnc19jb3VudCAhPSAxKSB7CgkJ ZGV2X2VycihkZXYsICJpbnZhbGlkIG51bWJlciBvZiBhcmd1bWVudHNcbiIpOwoJCXJldHVybiBF UlJfUFRSKC1FSU5WQUwpOwoJfQoKSWYgYSBkZXZpY2UgdHJlZSBpcyB1cGRhdGVkIHRvIHVzZSB0 aGUgbmV3bHkgYWxsb3dlZCAyLWNlbGwgY29uZmlndXJhdGlvbgp0byBzcGVjaWZ5IFRYL1JYIGRp cmVjdGlvbiwgd29uJ3QgcGh5X2dldCgpIGZhaWwgYW5kIHJldHVybiAtRUlOVkFMPyBTaG91bGQK dGhlIGRyaXZlciBiZSB1cGRhdGVkIGFsb25nc2lkZSB0aGUgYmluZGluZyBzbyBjb25zdW1lcnMg Y2FuIHN1Y2Nlc3NmdWxseQphY3F1aXJlIHRoZSBQSFk/CgpbIC4uLiBdCgotLSAKU2FzaGlrbyBB SSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwNzI2LWRjcGh5 LXJ4LXYxLXYyLTAtY2Y5Y2MzNGE0MTJhQGdtYWlsLmNvbT9wYXJ0PTEKCi0tIApsaW51eC1waHkg bWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F0D523BD06 for ; Sun, 26 Jul 2026 15:02:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785078172; cv=none; b=QXtGoCfm3tj2puXFdFDDtG6XXR6HME5ujr/YhCbNJwam08Bay05m7Kwd7Sq+wM/z8UywdIMMrRSolXgtkCl4IFeD/I7Z/HEuxHLPh4G2eONn7p/5aglt2sVR6I4KD1FZqAG3NmLlLak/O/dvnNJthUo68O938jA/LFMs/+HGqY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785078172; c=relaxed/simple; bh=DJH89T++flQRDwgtjXBiuShW5y9LSXGkqJRiY/Eu+2A=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=OQaLpBCxgiToV20913M0/+cqaRoRHvMO/LT8ugOjFR0nxH6aE5cWV5JP5h+KgzDwj0cup3DI45oUFV80JR2vDhEYD1egoNhILu90bjT/WkR0RnltWiowo1F4apmerm3u2MeVInKeMT+SyokJpU85lVw8TwPz+QI1QThNaCXTLPM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gPIUkq6z; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gPIUkq6z" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8157C1F000E9; Sun, 26 Jul 2026 15:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785078171; bh=Z3DACBE56ZwFLMgfYQH7UyWpQ+If3ko8mfpG2U6ex9s=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=gPIUkq6z5EHLn3RqbfKo4Zo90FebBQ/Zka1MrKi287fel32OZK89e8n4UEqsHPFh+ rTh4MC0H42m1IhuReaOvRbUHTx58FEZ8z8YucKjg0kIgy2WCfH9mq6MTZ/ioUDyhr1 88mmu1rIk82JiwjrLHJFZsYuNIoP9DkyDcXtBJRNQCeuAtHB24exWSHcJQUadWziPD Oy1Z2S1wUn9Nww7udDALqV3ZH9GauBf+lFQFrzAkueBObIXwKi3O5OoR6OWz/OvYBY NDLwVlIAMds7Oqe20awakMR20/nmWCKf+cqTSeOB4nfrHO211rIG5RKsqPu1jvtSCF jt/rJpgqMkELA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 1/4] dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-direction phys Reply-To: sashiko-reviews@lists.linux.dev To: "Jason Yang" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, olteanv@gmail.com, robh@kernel.org, linux-phy@lists.infradead.org, conor+dt@kernel.org, vkoul@kernel.org In-Reply-To: <20260726-dcphy-rx-v1-v2-1-cf9cc34a412a@gmail.com> References: <20260726-dcphy-rx-v1-v2-0-cf9cc34a412a@gmail.com> <20260726-dcphy-rx-v1-v2-1-cf9cc34a412a@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 26 Jul 2026 15:02:50 +0000 Message-Id: <20260726150250.8157C1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] The dt-binding allows `#phy-cells =3D 2` to represent PHY direct= ion, but the corresponding driver `phy-rockchip-samsung-dcphy.c` was not up= dated to support this. -- --- Patch [1]: [PATCH v2 1/4] dt-bindings: phy: rockchip,rk3588-mipi-dcphy:= support per-direction phys --- commit 421d266fa3318c44780c09224a034b0edeca9db3 Author: Jason Yang Subject: dt-bindings: phy: rockchip,rk3588-mipi-dcphy: support per-directio= n phys This commit updates the Rockchip RK3588 MIPI D-/C-PHY device tree binding to support per-direction configuration. It changes the #phy-cells property to allow either 1 or 2 cells, where the optional second cell specifies the PHY direction (TX or RX). > diff --git a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-d= cphy.yaml b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcph= y.yaml > index c8ff5ba22a86b..68a43db9c6690 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.ya= ml > +++ b/Documentation/devicetree/bindings/phy/rockchip,rk3588-mipi-dcphy.ya= ml > @@ -20,12 +20,22 @@ properties: > maxItems: 1 > =20 > "#phy-cells": > - const: 1 > + enum: [1, 2] [Severity: Medium] Will this new 2-cell configuration work with the current PHY driver? Looking at samsung_mipi_dcphy_xlate() in drivers/phy/rockchip/phy-rockchip-samsung-dcphy.c, the driver explicitly rejects anything other than 1 cell: if (args->args_count !=3D 1) { dev_err(dev, "invalid number of arguments\n"); return ERR_PTR(-EINVAL); } If a device tree is updated to use the newly allowed 2-cell configuration to specify TX/RX direction, won't phy_get() fail and return -EINVAL? Should the driver be updated alongside the binding so consumers can successfully acquire the PHY? [ ... ] --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260726-dcphy-rx-v= 1-v2-0-cf9cc34a412a@gmail.com?part=3D1