From: SJ Park <sj@kernel.org>
Cc: SJ Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
damon@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Subject: [RFC PATCH v2 12/17] mm/damon/sysfs: create probe prep files for preps/nr file write
Date: Sun, 26 Jul 2026 10:39:28 -0700 [thread overview]
Message-ID: <20260726173935.94046-13-sj@kernel.org> (raw)
In-Reply-To: <20260726173935.94046-1-sj@kernel.org>
Implement preps/nr file write operation to really create the probe prep
directories and their files.
Signed-off-by: SJ Park <sj@kernel.org>
---
mm/damon/sysfs.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 54 insertions(+), 2 deletions(-)
diff --git a/mm/damon/sysfs.c b/mm/damon/sysfs.c
index e348c1feed1ad..f275a6f73eee1 100644
--- a/mm/damon/sysfs.c
+++ b/mm/damon/sysfs.c
@@ -759,6 +759,17 @@ struct damon_sysfs_prep {
enum damon_prep_action action;
};
+static struct damon_sysfs_prep *damon_sysfs_prep_alloc(void)
+{
+ struct damon_sysfs_prep *prep;
+
+ prep = kzalloc_obj(struct damon_sysfs_prep);
+ if (!prep)
+ return prep;
+ prep->action = DAMON_PREP_SET_PGIDLE;
+ return prep;
+}
+
struct damon_sysfs_prep_action_name {
enum damon_prep_action action;
char *name;
@@ -827,7 +838,7 @@ static struct attribute *damon_sysfs_prep_attrs[] = {
};
ATTRIBUTE_GROUPS(damon_sysfs_prep);
-const struct kobj_type damon_sysfs_prep_ktype = {
+static const struct kobj_type damon_sysfs_prep_ktype = {
.release = damon_sysfs_prep_release,
.sysfs_ops = &kobj_sysfs_ops,
.default_groups = damon_sysfs_prep_groups,
@@ -839,6 +850,7 @@ const struct kobj_type damon_sysfs_prep_ktype = {
struct damon_sysfs_preps {
struct kobject kobj;
+ struct damon_sysfs_prep **preps_arr;
int nr;
};
@@ -849,13 +861,53 @@ static struct damon_sysfs_preps *damon_sysfs_preps_alloc(void)
static void damon_sysfs_preps_rm_dirs(struct damon_sysfs_preps *preps)
{
+ struct damon_sysfs_prep **preps_arr = preps->preps_arr;
+ int i;
+
+ for (i = 0; i < preps->nr; i++) {
+ kobject_del(&preps_arr[i]->kobj);
+ kobject_put(&preps_arr[i]->kobj);
+ }
preps->nr = 0;
+ kfree(preps_arr);
+ preps->preps_arr = NULL;
}
static int damon_sysfs_preps_add_dirs(struct damon_sysfs_preps *preps,
int nr_preps)
{
- preps->nr = nr_preps;
+ struct damon_sysfs_prep **preps_arr, *prep;
+ int err, i;
+
+ damon_sysfs_preps_rm_dirs(preps);
+ if (!nr_preps)
+ return 0;
+
+ preps_arr = kmalloc_objs(*preps_arr, nr_preps,
+ GFP_KERNEL | __GFP_NOWARN);
+ if (!preps_arr)
+ return -ENOMEM;
+ preps->preps_arr = preps_arr;
+
+ for (i = 0; i < nr_preps; i++) {
+ prep = damon_sysfs_prep_alloc();
+ if (!prep) {
+ damon_sysfs_preps_rm_dirs(preps);
+ return -ENOMEM;
+ }
+
+ err = kobject_init_and_add(&prep->kobj,
+ &damon_sysfs_prep_ktype, &preps->kobj, "%d",
+ i);
+ if (err) {
+ kobject_put(&prep->kobj);
+ damon_sysfs_preps_rm_dirs(preps);
+ return err;
+ }
+
+ preps_arr[i] = prep;
+ preps->nr++;
+ }
return 0;
}
--
2.47.3
next prev parent reply other threads:[~2026-07-26 17:39 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 17:39 [RFC PATCH v2 00/17] mm/damon: introduce data access-as-a-data attribute SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 01/17] mm/damon/core: introduce DAMON_FILTER_TYPE_PGIDLE_UNSET SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 02/17] mm/damon/paddr: support PGIDLE_UNSET probe filter type SJ Park
2026-07-26 17:53 ` sashiko-bot
2026-07-26 18:42 ` SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 03/17] mm/damon/sysfs: support pgidle_unset " SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 04/17] Docs/mm/damon/design: document " SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 05/17] mm/damon/core: introduce damon_prep struct SJ Park
2026-07-26 17:52 ` sashiko-bot
2026-07-26 18:45 ` SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 06/17] mm/damon/core: commit preps SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 07/17] mm/damon/core: introduce damon_operations->prep_probes() SJ Park
2026-07-26 17:57 ` sashiko-bot
2026-07-26 18:52 ` SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 08/17] mm/damon/paddr: support damon_prep SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 09/17] mm/damon/sysfs: implement preps directory SJ Park
2026-07-26 17:46 ` sashiko-bot
2026-07-26 18:54 ` SJ Park
2026-07-26 19:41 ` SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 10/17] mm/damon/sysfs: create probe " SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 11/17] mm/damon/sysfs: implement probe prep directory SJ Park
2026-07-26 17:47 ` sashiko-bot
2026-07-26 18:57 ` SJ Park
2026-07-26 19:42 ` SJ Park
2026-07-26 17:39 ` SJ Park [this message]
2026-07-26 17:39 ` [RFC PATCH v2 13/17] mm/damon/sysfs: pass preps to DAMON core SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 14/17] selftests/damon/sysfs.sh: test probe prep sysfs files SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 15/17] Docs/mm/damon/design: document probe preps SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 16/17] Docs/admin-guide/mm/damon/usage: document probe preps sysfs files SJ Park
2026-07-26 17:45 ` sashiko-bot
2026-07-26 18:58 ` SJ Park
2026-07-26 17:39 ` [RFC PATCH v2 17/17] Docs/ABI/damon: document probe prep " SJ Park
2026-07-26 17:45 ` sashiko-bot
2026-07-26 19:01 ` SJ Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726173935.94046-13-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.