From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97684C531C9 for ; Sun, 26 Jul 2026 20:26:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cPTJppY+qGQNhDmaDsLrBC5KKYNG2Lvsv6wuMcXphOM=; b=XKWYP3q9RSqXJD TvICfM1oEVHk44aBJoB2zbgvTtKKpNfharpOsT+p5lAU/1AeBqSvd3D92GJvm2KKBjQGAAnGuoxd/ AKFKcOlEGjvkZkjHwJTdFwoILy3yTWnNJnfEcVENkAsEAIgjRDV7O9Yw4xN/D9laYuGob0xNNw155 aU8rpSHY5+osBP4ZqfzIXbmfCcjCOanhZo7Wx7BPFWyrfMmfVZGcbB+jHVfa5TpwoX0IGXHdeo2Tc 3v0cPpyl5DtNTD/mRfey4htBtpKhcYraMjciHuVRAGFYxhHF+AnW5iVs1OsxGjKWlo6rECIXtVLaB 6DRmaxrtVehIowPc3N6g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wo5Qu-00000001anO-1XZU; Sun, 26 Jul 2026 20:26:48 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wo5Qt-00000001anE-1WUk for linux-amlogic@lists.infradead.org; Sun, 26 Jul 2026 20:26:47 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E6C3D60054; Sun, 26 Jul 2026 20:26:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B6DF1F000E9; Sun, 26 Jul 2026 20:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785097605; bh=B1YxlU8BBhOK6tQiTrcIR71UmCeieT44RHJV42wXvEM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Re5QTsHscXaEo3zTxJRozbHVTBo5BG4n7qZ+HVNea0byAUc5JsNMPbBZlQG4LiN6Q sD5s6qY2rM5fjoPgp/H0qjIiFD+lRtC2ane08vrn2tAa74d83XrjqhVdpg++P2WOke 0HWqC0KKJXIcwnMTUYxpCrnHo6dLdMiFBHSoDqGYL756BLYemQcy4eBgB4SYhR06FJ cWlJ/dy4F67RYWniufiHOO6vg45Ey5xIveDu1PJ1UOeNXwIcm2jvbIbOCmSbrhhW9n NHd3zRxqkZqRMnAPLjzKa+Y7OSbgN1iYryAbDavKfFRqs+ddyHR/ceeUDmNch7OTsD 4W40QiSfEgtxA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/3] arm64: dts: amlogic: add support for Orbbec Zora P1 To: "Alberto Robazza" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260726201647.264108-4-robazzalberto@gmail.com> References: <20260726201647.264108-1-robazzalberto@gmail.com> <20260726201647.264108-4-robazzalberto@gmail.com> Date: Sun, 26 Jul 2026 20:26:44 +0000 Message-Id: <20260726202645.3B6DF1F000E9@smtp.kernel.org> X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIFBpbiBtdWx0aXBsZXhp bmcgY29uZmxpY3Qgb24gR1BJT1hfMTYgYmV0d2VlbiB0aGUgV2ktRmkgU0RJTyBwb3dlciBzZXF1 ZW5jZSByZXNldCBhbmQgdGhlIDMyLjc2OGtIeiBQV00gY2xvY2suCi0tCgotLS0gUGF0Y2ggWzNd OiBbUEFUQ0ggdjIgMy8zXSBhcm02NDogZHRzOiBhbWxvZ2ljOiBhZGQgc3VwcG9ydCBmb3IgT3Ji YmVjIFpvcmEgUDEgLS0tCmNvbW1pdCA0YzI1YzIyYjU5ZWY1NGEzYjA4ZDAyYWFiODQ4ZDZmNmFh NmFmMWVmCkF1dGhvcjogQWxiZXJ0byBSb2JhenphIDxyb2JhenphbGJlcnRvQGdtYWlsLmNvbT4K CmFybTY0OiBkdHM6IGFtbG9naWM6IGFkZCBzdXBwb3J0IGZvciBPcmJiZWMgWm9yYSBQMQoKVGhp cyBjb21taXQgYWRkcyBkZXZpY2UgdHJlZSBzdXBwb3J0IGZvciB0aGUgT3JiYmVjIFpvcmEgUDEg Ym9hcmQsIGFuIEEzMTFECmJhc2VkIGRldmljZS4gSXQgYnVpbGRzIHVwb24gdGhlIE9EUk9JRC1O MiBkZXZpY2UgdHJlZSwgYWRkaW5nIHNwZWNpZmljIEdQSU8Kd2lyaW5nIGZvciBXaS1GaSBhbmQg Qmx1ZXRvb3RoIG92ZXIgU0RJTyBhbmQgVUFSVF9BLiBJdCBhbHNvIGluY2x1ZGVzIHRoZQpib2Fy ZCdzIGNvbXBhdGlibGUgc3RyaW5nIGFuZCBMRUQgY29uZmlndXJhdGlvbnMuCgo+IGRpZmYgLS1n aXQgYS9hcmNoL2FybTY0L2Jvb3QvZHRzL2FtbG9naWMvbWVzb24tZzEyYi16b3JhLXAxLmR0cyBi L2FyY2gvYXJtNjQvYm9vdC9kdHMvYW1sb2dpYy9tZXNvbi1nMTJiLXpvcmEtcDEuZHRzCj4gbmV3 IGZpbGUgbW9kZSAxMDA2NDQKPiAtLS0gL2Rldi9udWxsCj4gKysrIGIvYXJjaC9hcm02NC9ib290 L2R0cy9hbWxvZ2ljL21lc29uLWcxMmItem9yYS1wMS5kdHMKWyAuLi4gXQo+ICsJc2Rpb19wd3Jz ZXE6IHNkaW8tcHdyc2VxIHsKPiArCQljb21wYXRpYmxlID0gIm1tYy1wd3JzZXEtc2ltcGxlIjsK PiArCQlyZXNldC1ncGlvcyA9IDwmZ3BpbyBHUElPWF8xNiBHUElPX0FDVElWRV9MT1c+Owo+ICsJ CWNsb2NrcyA9IDwmd2lmaTMyaz47Cj4gKwkJY2xvY2stbmFtZXMgPSAiZXh0X2Nsb2NrIjsKPiAr CX07Cj4gKwo+ICsJd2lmaTMyazogd2lmaTMyayB7Cj4gKwkJY29tcGF0aWJsZSA9ICJwd20tY2xv Y2siOwo+ICsJCSNjbG9jay1jZWxscyA9IDwwPjsKPiArCQljbG9jay1mcmVxdWVuY3kgPSA8MzI3 Njg+Owo+ICsJCXB3bXMgPSA8JnB3bV9lZiAwIDMwNTE4IDA+Owo+ICsJfTsKWyAuLi4gXQo+ICsm cHdtX2VmIHsKPiArCXN0YXR1cyA9ICJva2F5IjsKPiArCXBpbmN0cmwtMCA9IDwmcHdtX2VfcGlu cz47CgpbU2V2ZXJpdHk6IEhpZ2hdCldpbGwgdGhpcyBjcmVhdGUgYSBwaW4gbXVsdGlwbGV4aW5n IGNvbmZsaWN0IG9uIEdQSU9YXzE2PwoKVGhlIHNkaW9fcHdyc2VxIG5vZGUgY2xhaW1zIEdQSU9Y XzE2IGFzIGEgc3RhbmRhcmQgR1BJTyBmb3IgdGhlIHJlc2V0LWdwaW9zCmxpbmUuIEhvd2V2ZXIs IHRoZSBwd21fZWYgbm9kZSByZXF1ZXN0cyB0aGUgcHdtX2VfcGlucyBwaW5jdHJsIGdyb3VwLiBP biB0aGUKQW1sb2dpYyBHMTJCIHBsYXRmb3JtLCBwd21fZV9waW5zIG1hcHMgZXhhY3RseSB0byBH UElPWF8xNi4KClNpbmNlIGEgc2luZ2xlIHBoeXNpY2FsIHBpbiBjYW5ub3QgY29uY3VycmVudGx5 IG91dHB1dCBhIDMya0h6IFBXTSBjbG9jayBzaWduYWwKYW5kIGZ1bmN0aW9uIGFzIGEgc3RhdGlj IEdQSU8gcmVzZXQgc2lnbmFsIGZvciB0aGUgV2ktRmkgbW9kdWxlLCB3aWxsIHRoZQpwaW5jdHJs IHN1YnN5c3RlbSBmYWlsIG9uZSBvZiB0aGUgcmVxdWVzdHMgYW5kIHByZXZlbnQgdGhlIFdpLUZp IG1vZHVsZSBmcm9tCmluaXRpYWxpemluZz8KCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRw czovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjA3MjYyMDE2NDcuMjY0MTA4LTEtcm9iYXp6 YWxiZXJ0b0BnbWFpbC5jb20/cGFydD0zCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2lj QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 07404372049 for ; Sun, 26 Jul 2026 20:26:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785097607; cv=none; b=cM11fLxmdjaVzSctTvAsAifSLOjHNBXCO+cXDSfUtMyc4n+fs7Qq3ezf8mM2IqS6rHy93DfoBc5yCPYMSS27es4qetEuLor0FcRsO+Chg3AB6cUznqlug8wWyPjLCef5Htk8p1lsbGG9mI6gcybRPfMdjAXsTpQYYoVhOmZMqro= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785097607; c=relaxed/simple; bh=djlflqW34i2wECU4MvXaQH5qJ2jPy972iv5zGS0Cc6o=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=Z38iV/L1zHykeOBkQfJfOlSdqDJ0/C3Rf2CZ3RtJzWNufSBekNVy3vOnRybMMpFlU0UM+ocENl+Nmt5DZSTGavN8Y1BfYldvYedPN26otHvdB7dQ/q6txdNO/ATj3gBJ7rMulWxDBPnNKaeZ842hae20cATJ7i+AAQQxh5UIiZs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Re5QTsHs; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Re5QTsHs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B6DF1F000E9; Sun, 26 Jul 2026 20:26:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785097605; bh=B1YxlU8BBhOK6tQiTrcIR71UmCeieT44RHJV42wXvEM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=Re5QTsHscXaEo3zTxJRozbHVTBo5BG4n7qZ+HVNea0byAUc5JsNMPbBZlQG4LiN6Q sD5s6qY2rM5fjoPgp/H0qjIiFD+lRtC2ane08vrn2tAa74d83XrjqhVdpg++P2WOke 0HWqC0KKJXIcwnMTUYxpCrnHo6dLdMiFBHSoDqGYL756BLYemQcy4eBgB4SYhR06FJ cWlJ/dy4F67RYWniufiHOO6vg45Ey5xIveDu1PJ1UOeNXwIcm2jvbIbOCmSbrhhW9n NHd3zRxqkZqRMnAPLjzKa+Y7OSbgN1iYryAbDavKfFRqs+ddyHR/ceeUDmNch7OTsD 4W40QiSfEgtxA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 3/3] arm64: dts: amlogic: add support for Orbbec Zora P1 Reply-To: sashiko-reviews@lists.linux.dev To: "Alberto Robazza" Cc: neil.armstrong@linaro.org, devicetree@vger.kernel.org, robh@kernel.org, linux-amlogic@lists.infradead.org, conor+dt@kernel.org In-Reply-To: <20260726201647.264108-4-robazzalberto@gmail.com> References: <20260726201647.264108-1-robazzalberto@gmail.com> <20260726201647.264108-4-robazzalberto@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Sun, 26 Jul 2026 20:26:44 +0000 Message-Id: <20260726202645.3B6DF1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Pin multiplexing conflict on GPIOX_16 between the Wi-Fi SDIO power= sequence reset and the 32.768kHz PWM clock. -- --- Patch [3]: [PATCH v2 3/3] arm64: dts: amlogic: add support for Orbbec Z= ora P1 --- commit 4c25c22b59ef54a3b08d02aab848d6f6aa6af1ef Author: Alberto Robazza arm64: dts: amlogic: add support for Orbbec Zora P1 This commit adds device tree support for the Orbbec Zora P1 board, an A311D based device. It builds upon the ODROID-N2 device tree, adding specific GPIO wiring for Wi-Fi and Bluetooth over SDIO and UART_A. It also includes the board's compatible string and LED configurations. > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts b/arch/ar= m64/boot/dts/amlogic/meson-g12b-zora-p1.dts > new file mode 100644 > --- /dev/null > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-zora-p1.dts [ ... ] > + sdio_pwrseq: sdio-pwrseq { > + compatible =3D "mmc-pwrseq-simple"; > + reset-gpios =3D <&gpio GPIOX_16 GPIO_ACTIVE_LOW>; > + clocks =3D <&wifi32k>; > + clock-names =3D "ext_clock"; > + }; > + > + wifi32k: wifi32k { > + compatible =3D "pwm-clock"; > + #clock-cells =3D <0>; > + clock-frequency =3D <32768>; > + pwms =3D <&pwm_ef 0 30518 0>; > + }; [ ... ] > +&pwm_ef { > + status =3D "okay"; > + pinctrl-0 =3D <&pwm_e_pins>; [Severity: High] Will this create a pin multiplexing conflict on GPIOX_16? The sdio_pwrseq node claims GPIOX_16 as a standard GPIO for the reset-gpios line. However, the pwm_ef node requests the pwm_e_pins pinctrl group. On the Amlogic G12B platform, pwm_e_pins maps exactly to GPIOX_16. Since a single physical pin cannot concurrently output a 32kHz PWM clock si= gnal and function as a static GPIO reset signal for the Wi-Fi module, will the pinctrl subsystem fail one of the requests and prevent the Wi-Fi module from initializing? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260726201647.2641= 08-1-robazzalberto@gmail.com?part=3D3