Re: [PATCH] dt-bindings: bus: brcm,bus-axi: Convert binding to YAML

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Low] DT Example Compilation Failure due to missing includes and undefined phandle.
- [Low] DT Schema Validation Failure & DTC Warning due to missing unit-address in child node.
--

--- Patch [1]: [PATCH] dt-bindings: bus: brcm,bus-axi: Convert binding to YAML ---
commit afe32a853f1abd5449035c850043c368de3892be
Author: Rosen Penev <rosenp@gmail.com>

dt-bindings: bus: brcm,bus-axi: Convert binding to YAML

Convert the Broadcom AXI bus (bcma) binding from legacy .txt format
to dt-schema YAML format. This resolves dtbs_check schema validation
warnings for the brcm,bus-axi compatible string across all BCM47xx
and BCM53xx ARM SoC board DTBs.

> diff --git a/Documentation/devicetree/bindings/bus/brcm,bus-axi.yaml b/Documentation/devicetree/bindings/bus/brcm,bus-axi.yaml
> new file mode 100644
> index 0000000000000..951aa139dd987
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/bus/brcm,bus-axi.yaml

[ ... ]

> +examples:
> +  - |
> +    axi@18000000 {
> +        compatible = "brcm,bus-axi";
> +        reg = <0x18000000 0x1000>;
> +        ranges = <0x00000000 0x18000000 0x00100000>;
> +        #address-cells = <1>;
> +        #size-cells = <1>;
> +        #interrupt-cells = <1>;
> +        interrupt-map-mask = <0x000fffff 0xffff>;
> +        interrupt-map =
> +            /* Ethernet Controller 0 */
> +            <0x00024000 0 &gic GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>,
> +            /* Ethernet Controller 1 */
> +            <0x00025000 0 &gic GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;

[Severity: Low]
Will this example fail to compile during make dt_binding_check?

The example uses macros like GIC_SPI and IRQ_TYPE_LEVEL_HIGH, but seems to be
missing the required includes:
#include <dt-bindings/interrupt-controller/arm-gic.h>
#include <dt-bindings/interrupt-controller/irq.h>

Additionally, is the &gic phandle defined anywhere in the example scope? If
not, it might cause a reference to non-existent node or label dtc error.

> +
> +        chipcommon {

[Severity: Low]
Does this child node need a unit address to pass schema validation?

The schema defines valid children using patternProperties: "@[0-9a-f]+$". Since
this node contains a reg property, the Devicetree specification requires a
unit address (e.g., chipcommon@0). Without it, make dt_binding_check might
reject this as an undocumented property and emit a unit_address_vs_reg
warning.

> +            reg = <0x00000000 0x1000>;
> +            gpio-controller;
> +            #gpio-cells = <2>;
> +        };
> +    };

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260726205518.6698-1-rosenp@gmail.com?part=1