From: sashiko-bot@kernel.org
To: "Tejun Heo" <tj@kernel.org>
Cc: sched-ext@lists.linux.dev
Subject: Re: [PATCH sched_ext/for-7.3] tools/sched_ext/include: Regenerate enum_defs.autogen.h
Date: Sun, 26 Jul 2026 22:00:16 +0000 [thread overview]
Message-ID: <20260726220016.D958B1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <048d8cc6b8e9be48ec0e6e431afc75cd@kernel.org>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch updates `enum_defs.autogen.h` to replace `HAVE_SCX_REENQ_LOCAL_MAX_REPEAT` with `HAVE_SCX_REENQ_MAX_REPEAT`, but the corresponding enum rename is missing from the kernel C source code (`kernel/sched/ext/types.h`).
--
--- Patch [1]: [PATCH sched_ext/for-7.3] tools/sched_ext/include: Regenerate enum_defs.autogen.h ---
commit 87802be8777491b94ab77d3e645df530fc777b45
Author: Tejun Heo <tj@kernel.org>
tools/sched_ext/include: Regenerate enum_defs.autogen.h
Regenerate enum_defs.autogen.h from the current vmlinux.h to pick up the SCX
enum changes accumulated since the last regeneration.
Link: https://lore.kernel.org/all/amZsEbZJdDgjstPF@gpd4/
> Regenerate enum_defs.autogen.h from the current vmlinux.h to pick up the SCX
> enum changes accumulated since the last regeneration, including the
> SCX_REENQ_LOCAL_MAX_REPEAT to SCX_REENQ_MAX_REPEAT rename.
[Severity: Medium]
Is the SCX_REENQ_LOCAL_MAX_REPEAT to SCX_REENQ_MAX_REPEAT rename actually
present in this tree?
Looking at kernel/sched/ext/types.h, the old enum name is still present:
kernel/sched/ext/types.h:
SCX_BYPASS_LB_BATCH = 256,
SCX_REENQ_LOCAL_MAX_REPEAT = 256,
SCX_SUB_MAX_DEPTH = 4,
> diff --git a/tools/sched_ext/include/scx/enum_defs.autogen.h b/tools/sched_ext/include/scx/enum_defs.autogen.h
> index da4b459820fdd..0379eff117c9e 100644
> --- a/tools/sched_ext/include/scx/enum_defs.autogen.h
> +++ b/tools/sched_ext/include/scx/enum_defs.autogen.h
[ ... ]
> @@ -20,7 +37,7 @@
> #define HAVE_SCX_BYPASS_LB_DONOR_PCT
> #define HAVE_SCX_BYPASS_LB_MIN_DELTA_DIV
> #define HAVE_SCX_BYPASS_LB_BATCH
> -#define HAVE_SCX_REENQ_LOCAL_MAX_REPEAT
> +#define HAVE_SCX_REENQ_MAX_REPEAT
[Severity: Medium]
Will this cause build failures for BPF schedulers that check for
HAVE_SCX_REENQ_MAX_REPEAT?
They might get an undeclared identifier if the actual kernel source still
exports SCX_REENQ_LOCAL_MAX_REPEAT in vmlinux.h instead of the new name.
--
Sashiko AI review · https://sashiko.dev/#/patchset/048d8cc6b8e9be48ec0e6e431afc75cd@kernel.org?part=1
next prev parent reply other threads:[~2026-07-26 22:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-26 19:49 [PATCH v3 sched_ext/for-7.3] sched_ext: Bound per-task reenqueues and eject the owning scheduler Tejun Heo
2026-07-26 20:20 ` Andrea Righi
2026-07-26 21:48 ` [PATCH sched_ext/for-7.3] tools/sched_ext/include: Regenerate enum_defs.autogen.h Tejun Heo
2026-07-26 22:00 ` sashiko-bot [this message]
2026-07-26 21:48 ` [PATCH v3 sched_ext/for-7.3] sched_ext: Bound per-task reenqueues and eject the owning scheduler Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260726220016.D958B1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sched-ext@lists.linux.dev \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.