From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3171215E5DC for ; Sun, 26 Jul 2026 20:45:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785098733; cv=none; b=miLGXUnQGnRzgAEKSQpUNZu20gCVnKVzPN9phXl52xmiWzt9mljqENjPOQ6TrstOTgV3y0yuJHlYyo7UdrooBa2tHmIPKRQh4KBu6fAOdIVRU0heTooyDKFDrGNlqN1YO+kt9+w3ufCs7Fj6CPx6jMwjT9B0Xcq9gWnviNm7Hms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785098733; c=relaxed/simple; bh=8V4SbETfqA20e58q6VCGWaqhSb6JTXgkzFqcys/62CY=; h=From:Date:Subject:MIME-Version:Message-Id:References:In-Reply-To: To:Cc:Content-Type; b=OT1PoSh+MkMOyJRu1apfkB4j5Uy+osxScCcfDsbKXCmXBXygYNV3R4OOOKhQWL8XHRH332RuKP6DAAtDer97MqdPbfGm6fb3SETtd5ZYTec3aXJb6Z9ihS5HQLh3cISzAWYNvAsXhJAmUUNN2NEu4/U8FCAAZokv9FEVNzNq/xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UlWnR1bV; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UlWnR1bV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785098731; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sgwF7jkNJLhj6j+139aaPY14IWX2xoRAqge3G7njsEU=; b=UlWnR1bV20Cd5VbMaVv7VSU1HcbU5zaOLPaZwrfUZl36CxpE4FQOCL2VKElediIhauLi66 cyL4f78XcCGmPBltHzOH0qI9owWrKTV53aJ+sbSfyP+QT6/5ndIq5mJ4hqNMcnaSH5IFaj UpVUqYRs8xhFZ0kaMy7R0eCQ7Of1pZU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-4NpKxJpOMJKlDubQtrOMeg-1; Sun, 26 Jul 2026 16:45:27 -0400 X-MC-Unique: 4NpKxJpOMJKlDubQtrOMeg-1 X-Mimecast-MFC-AGG-ID: 4NpKxJpOMJKlDubQtrOMeg_1785098725 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7AB091800590; Sun, 26 Jul 2026 20:45:25 +0000 (UTC) Received: from localhost (unknown [10.44.24.5]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id AEE531956047; Sun, 26 Jul 2026 20:45:23 +0000 (UTC) From: =?utf-8?q?Marc-Andr=C3=A9_Lureau?= Date: Mon, 27 Jul 2026 00:44:10 +0400 Subject: [PATCH v2 11/12] migration/multifd: fix Error leak in multifd_recv_terminate_threads() Precedence: bulk X-Mailing-List: linux-cxl@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20260727-fix2-v2-11-d0c4831ed7ea@redhat.com> References: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> In-Reply-To: <20260727-fix2-v2-0-d0c4831ed7ea@redhat.com> To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , =?utf-8?q?Alex_Benn=C3=A9e?= , Akihiko Odaki , Dmitry Osipenko , Stefan Hajnoczi , Kevin Wolf , Hanna Reitz , qemu-block@nongnu.org, Jonathan Cameron , Paolo Bonzini , Fam Zheng , =?utf-8?q?Daniel_P=2E_Berrang=C3=A9?= , Zhao Liu , Roman Bolshakov , Phil Dennis-Jordan , Wei Liu , linux-cxl@vger.kernel.org, Brian Cain , Pierrick Bouvier , =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= , Peter Xu , Fabiano Rosas , =?utf-8?q?Marc-Andr=C3=A9_Lureau?= X-Developer-Signature: v=1; a=openpgp-sha256; l=654; i=marcandre.lureau@redhat.com; h=from:subject:message-id; bh=8V4SbETfqA20e58q6VCGWaqhSb6JTXgkzFqcys/62CY=; b=owEBbQKS/ZANAwAKAdro4Ql1lpzlAcsmYgBqZnGXqtL4DYX9fMBDVrhGbWRZ/5vbN92kSAgN+ 0aizcq2HCSJAjMEAAEKAB0WIQSHqb2TP4fGBtJ29i3a6OEJdZac5QUCamZxlwAKCRDa6OEJdZac 5Y+tD/9qjL26Hwgig0DMmnbLIrFIqE27KE226meUw/u9RE0E3MUY18KW3AcEYHjr6JwdPCQx9oL TkTOszT0vzToFQHDuoPcQZ7zm4YERQxTOtNFEmqbN6LOMSOWG8KhcexF2uga1FsAAQA8daRiDxD eLmnhu4k0JPgSZWsqyLeL+PL4TCLXTDulglfPg4SN44JBsTysPvnKwFbhQFjeMx6OzEbVw+ipb3 sumjSr2mkyEc5UpMu0hS0JUvwLvarPtH6cByPFWnYYBs1yAzkRu1m86r9I9s67tt6VoDGQdBBPn cXqNQiJKfgAUGPuLY6QmugdGhCu4xKR78l0q7zRuCOuNwrjAkXZUESKPlSlAOHhvpCBvzp7ADg7 BpPHvf2gnVKdaAUggS57RD6eCtb2D5QMjsA3dfHvuGVaIJsi9PZov1L+GPbiPR6Dlh+pxdvqnfe MhzchAgRmakbAH6ipHQTy7axxsvHY0LHVnQMW2gDQBzDNpXFaQ6yTCJeMuoua9XvCR1EyDGtRtQ JhLJmfQ3dqV5MMhRDfgoYe8scj0IkgK2luKnkZ3vo441ydpBzfH6rrxfJH7zbLZVrOdd0gE/+Ll wytmCWs74YesvP9HH5uqVTmL6ADR5upoh9OlTKLwZEPBqKEDx6xG5jx5za/B4XH1Tdz/8cD8mCG UAdVFiWx3U0E41g== X-Developer-Key: i=marcandre.lureau@redhat.com; a=openpgp; fpr=87A9BD933F87C606D276F62DDAE8E10975969CE5 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-MFC-PROC-ID: G0hutUw1O_o24Nq61FVgPglvwC13nE6AcG66dDz6sXY_1785098725 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit If err != NULL, free it. Fixes: 11dd7be57524 ("migration/multifd: Remove p->quit from recv side") Signed-off-by: Marc-André Lureau --- migration/multifd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/migration/multifd.c b/migration/multifd.c index dbad525d2a28..503014f76ba5 100644 --- a/migration/multifd.c +++ b/migration/multifd.c @@ -1056,6 +1056,7 @@ static void multifd_recv_terminate_threads(Error *err) trace_multifd_recv_terminate_threads(err != NULL); if (qatomic_xchg(&multifd_recv_state->exiting, 1)) { + error_free(err); return; } -- 2.55.0