Re: [PATCH v2 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete schema validation: `spacemit,k3-gpu` allows up to 3 clocks instead of restricting it to 1.
--

--- Patch [1]: [PATCH v2 1/2] dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu ---
commit 5e58bdf2ff5533bc6aae23c68852fcbc9caf9570
Author: Sterling-Ash <baihui.liang@spacemit.com>

dt-bindings: gpu: img,powervr-rogue: add spacemit,k3-gpu

This commit adds a compatible string for the IMG BXM-4-64 GPU integrated
into the SpacemiT K3 SoC. It notes that the integration requires a single
core clock and omits power-domains, falling back to general schema
constraints.

> diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> index a1f54dbae3f31..2d58dd4076a87 100644
> --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> @@ -38,6 +38,11 @@ properties:
>                - thead,th1520-gpu
>            - const: img,img-bxm-4-64
>            - const: img,img-rogue
> +      - items:
> +          - enum:
> +              - spacemit,k3-gpu
> +          - const: img,img-bxm-4-64
> +          - const: img,img-rogue

[Severity: Medium]
Will omitting spacemit,k3-gpu from a conditional block allow invalid
device trees to silently pass schema validation?

The commit message explicitly states that the K3 GPU only needs a single
clock and relies on the general schema constraints. However, the general
schema configuration allows up to 3 clocks:

Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml:properties.clocks:
  clocks:
    minItems: 1
    maxItems: 3

Because spacemit,k3-gpu does not match any specific allOf.if block
enforcing a maximum of 1 clock, it falls back to this general limit.

Should an if-then conditional block be added to enforce maxItems: 1 for
the clocks property on this platform?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727012231.1025210-1-baihui.liang@spacemit.com?part=1