Re: [PATCH v5 5/6] dt-bindings: display: Add Synaptics R63455 panel support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] Missing #address-cells, #size-cells, and reg in the example's parent DSI node
- [Low] Missing schema reference for the ports node
- [Low] The 'reg' property is not marked as required
--

--- Patch [5]: [PATCH v5 5/6] dt-bindings: display: Add Synaptics R63455 panel support ---
commit 55e4e84f35f079171a4dea5e2741a34a7fac11e9
Author: Jun Nie <jun.nie@linaro.org>

dt-bindings: display: Add Synaptics R63455 panel support
    
Add support for the dual-panel system found in the virtual reality device.
This system consists of two physical 2160x2160 panels, each connected via
a MIPI DSI interface. The backlight is managed through DSI link.

> diff --git a/Documentation/devicetree/bindings/display/panel/synaptics,r63455.yaml b/Documentation/devicetree/bindings/display/panel/synaptics,r63455.yaml
> new file mode 100644
> index 0000000000000..c3bc8df981df7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/synaptics,r63455.yaml

[ ... ]

> +  vdda-supply:
> +    description: core 1.8V supply for panels
> +
> +  ports:

[Severity: Low]
Should this ports node include a $ref to /schemas/graph.yaml#/properties/ports?
Without it, standard Open Firmware (OF) graph structural checks might be
bypassed, allowing invalid port configurations to silently pass schema
validation.

> +    properties:
> +      port@0:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: DSI input port for primary DSI link
> +
> +      port@1:
> +        $ref: /schemas/graph.yaml#/properties/port
> +        description: DSI input port for secondary DSI link
> +
> +    required:
> +      - port@0
> +      - port@1
> +
> +required:
> +  - compatible
> +  - reset-gpios

[Severity: Low]
Does 'reg' need to be added to this required list? Since MIPI DSI panels
must specify a virtual channel using the reg property, omitting it here might
allow incomplete device trees to pass validation.

> +  - left-pos-supply
> +  - left-neg-supply
> +  - right-pos-supply
> +  - right-neg-supply
> +  - left-backlight-supply
> +  - right-backlight-supply
> +  - vdda-supply
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi@ae94000 {

[Severity: Low]
Will this trigger a DTC warning during dt_binding_check? The parent node has
a unit address (dsi@ae94000) but lacks a reg property, and it also lacks
#address-cells and #size-cells which are needed since the child node
panel@0 has a reg property.

> +        vdda-supply = <&vreg_l3i_1p2>;
> +        status = "okay";
> +
> +        qcom,dual-dsi-mode;
> +        qcom,master-dsi;
> +
> +        panel: panel@0 {
> +            compatible = "sharp,ls026b3sa06", "synaptics,r63455";
> +            reg = <0>;

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727-sm8650-7-1-bonded-dsi-v5-0-c042266b9eeb@linaro.org?part=5