From: Joshua Crofts <joshua.crofts1@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata()
Date: Mon, 27 Jul 2026 09:07:22 +0200 [thread overview]
Message-ID: <20260727090722.0000031f@gmail.com> (raw)
In-Reply-To: <20260726201525.0aec2c28@jic23-huawei>
On Sun, 26 Jul 2026 20:15:25 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 24 Jul 2026 00:07:08 +0200
> Joshua Crofts <joshua.crofts1@gmail.com> wrote:
>
> > The I2C client data is set but never used. Remove the unnecessary
> > function call.
> Yes it is. Take another look at how that works and how else the resulting
> data is accessed (or just look at Sashiko)
>
> I was hoping it would catch this one :)
>
> The combination of different interfaces to access the same data has
> been much debated over time but we never came to a conclusion on whether
> it was worth the effort of stopping doing so given i2c driver reviewers
> are far too familiar with this particular hole.
>
Ugh, I was too hasty - I read Sashiko's review a few hours later and
realized what (very stupid) mistake I made.
--
Kind regards,
Joshua Crofts
next prev parent reply other threads:[~2026-07-27 7:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-23 22:07 [PATCH 0/2] iio: light: veml3328: minor cleanup fixes Joshua Crofts
2026-07-23 22:07 ` [PATCH 1/2] iio: light: veml3328: remove unused i2c_set_clientdata() Joshua Crofts
2026-07-26 19:15 ` Jonathan Cameron
2026-07-27 7:07 ` Joshua Crofts [this message]
2026-07-23 22:07 ` [PATCH 2/2] iio: light: veml3328: remove extra blank line Joshua Crofts
2026-07-26 19:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260727090722.0000031f@gmail.com \
--to=joshua.crofts1@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.