All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Diesen <michael.diesen@posteo.de>
To: tiwai@suse.de
Cc: linux-sound@vger.kernel.org, alsa-devel@alsa-project.org
Subject: [PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05)
Date: Mon, 27 Jul 2026 09:19:21 +0000	[thread overview]
Message-ID: <20260727091920.4634-1-michael.diesen@posteo.de> (raw)
In-Reply-To: <874ii84j3p.wl-tiwai@suse.de>

The HP Dragonfly Folio G3 2-in-1 also ships with PCI SSID 103c:8a05.
On this unit the ALC245 codec reports subsystem id 103c:8a06 - the SSID
that is already covered by commit 0a10faad5ca5 ("ALSA: hda/realtek: add
quirk for HP Dragonfly Folio G3 2-in-1") - while the PCI SSID that
SND_PCI_QUIRK matches against is 103c:8a05:

  snd_hda_codec_alc269 ehdaudio0D0: ALC245: picked fixup for PCI SSID 103c:8a05
  cs35l41-hda spi1-CSC3551:00-cs35l41-hda.0: CS35L41 Bound - SSID: 103C8A06

The existing entry therefore never applies here, the four CS35L41
amplifiers on SPI are not registered and the internal speakers stay
silent.

Add the same fixup that the 8a06 entry uses: the four amplifiers bind
and the speaker mute LED (codec GPIO 0x04) works.

Signed-off-by: Michael Diesen <michael.diesen@posteo.de>
---
v2:
 - Resend using git send-email. v1 was mangled by my mail client (tabs
   converted to spaces, long context lines soft-wrapped) so it could not
   be applied with git am. Sorry for the noise, and thanks for the
   pointer - I tested this one by mailing it to myself and applying it
   with git am before sending.
 - Use ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED instead of plain
   ALC245_FIXUP_CS35L41_SPI_4. In v1 I claimed this was a non-2-in-1 SKU
   that does not need the LED handling. That was wrong: DMI reports the
   machine as "HP Dragonfly Folio G3 2-in-1", i.e. the same model as the
   8a06 entry, and the speaker mute LED stayed dark with plain SPI_4.
 - Name the entry identically to the 8a06 one, as it is the same machine
   with a different PCI SSID.

On the mic-mute LED: alc285_fixup_hp_gpio_led() also drives GPIO 0x01 as
mic-mute LED. That LED does not respond on this unit. Poking the codec
GPIOs directly with hda-verb shows 0x04 toggling the speaker mute LED,
while neither 0x01 nor 0x02 has any effect, so the mic-mute LED does not
appear to be wired to the codec here. It does not work without the quirk
either, so this is no regression, and it matches what the 8a06 entry
already does - hence I kept the shared fixup instead of adding a new one.

 sound/hda/codecs/realtek/alc269.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index b22564f..ec6724e 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -7160,6 +7160,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x103c, 0x89d3, "HP EliteBook 645 G9 (MB 89D2)", ALC236_FIXUP_HP_MUTE_LED_MICMUTE_VREF),
 	SND_PCI_QUIRK(0x103c, 0x89da, "HP Spectre x360 14t-ea100", ALC245_FIXUP_HP_SPECTRE_X360_EU0XXX),
 	SND_PCI_QUIRK(0x103c, 0x89e7, "HP Elite x2 G9", ALC245_FIXUP_CS35L41_SPI_2_HP_GPIO_LED),
+	SND_PCI_QUIRK(0x103c, 0x8a05, "HP Dragonfly Folio G3 2-in-1", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a06, "HP Dragonfly Folio G3 2-in-1", ALC245_FIXUP_CS35L41_SPI_4_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a0f, "HP Pavilion 14-ec1xxx", ALC287_FIXUP_HP_GPIO_LED),
 	SND_PCI_QUIRK(0x103c, 0x8a1b, "HP 255 15.6 inch G9 Notebook PC", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
-- 
2.54.0


  reply	other threads:[~2026-07-27  9:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-08 20:04 [PATCH] ALSA: hda/realtek: Add quirk for HP Elite Dragonfly Folio G3 speakers Michael Diesen
2026-07-09  9:18 ` Takashi Iwai
2026-07-27  9:19   ` Michael Diesen [this message]
2026-07-27 13:54     ` [PATCH v2] ALSA: hda/realtek: Add quirk for HP Dragonfly Folio G3 2-in-1 (103c:8a05) Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260727091920.4634-1-michael.diesen@posteo.de \
    --to=michael.diesen@posteo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.