Re: [PATCH V20 5/9] iio: imu: inv_icm42607: Add PM support for icm42607

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Comment references non-existent 'sleep_ms' parameter and 'temp sensor' logic.
--

--- Patch [5]: [PATCH V20 5/9] iio: imu: inv_icm42607: Add PM support for icm42607 ---
commit 51a71bae3d352abb116b3df6698478255e0fe9f7
Author: Chris Morgan <macromorgan@hotmail.com>

iio: imu: inv_icm42607: Add PM support for icm42607
    
This commit adds power management support for the ICM42607 device driver.

> diff --git a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> index 6ec1d730017e2..e6d2fc7c0a344 100644
> --- a/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
> +++ b/drivers/iio/imu/inv_icm42607/inv_icm42607_core.c
[ ... ]
> @@ -100,6 +104,93 @@ const struct inv_icm42607_hw inv_icm42607p_hw_data = {
[ ... ]
> +static int inv_icm42607_set_pwr_mgmt0(struct inv_icm42607_state *st,
> +				      enum inv_icm42607_sensor_mode gyro,
> +				      enum inv_icm42607_sensor_mode accel)
> +{
[ ... ]
> +	/*
> +	 * If a state change occurs from off to on, sleep for the startup
> +	 * time of the sensor, unless a sleep_ms is specified. Since more
> +	 * than one sensor can be transitioned from off to on, select the
> +	 * maximum time from each of the sensors changing from off to on.
> +	 * The startup time for the temp sensor is considerably smaller
> +	 * than the startup time for the other sensors and one or more are
> +	 * required to be on for the temp sensor to function, so any start
> +	 * delay should be enough.
> +	 */

[Severity: Low]
This isn't a bug, but this comment refers to a sleep_ms parameter and
temperature sensor logic that do not appear to exist in this function.
Is this an outdated comment copied from another driver?

> +	sleepval_us = 0;
> +	if (accel && !oldaccel)
> +		sleepval_us = max(sleepval_us, INV_ICM42607_ACCEL_STARTUP_TIME_US);
[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727164815.65190-1-macroalpha82@gmail.com?part=5