Re: [PATCH v4 2/3] drm/nouveau/gsp/r570: Set GcOff = 1 in fbsr

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The commit title states 'Set GcOff = 1' but the patch implementation sets it to 0.
--

--- Patch [2]: [PATCH v4 2/3] drm/nouveau/gsp/r570: Set GcOff = 1 in fbsr ---
commit d069cc762363e23906149f0e5723b3c8cac473a5
Author: Lyude Paul <lyude@redhat.com>

drm/nouveau/gsp/r570: Set GcOff = 1 in fbsr

This commit modifies the GcOff state setting during FBSR initialization.
It disables GcOff to prevent GSP from saving and restoring buffers that
need to be reinitialized on resume, working around runtime PM issues.

> drm/nouveau/gsp/r570: Set GcOff = 1 in fbsr

[Severity: Medium]
Is the commit title incorrect? The commit message explains that disabling
GcOff improves stability, and the code in r570_fbsr_init() explicitly sets
bEnteringGcoffState to 0 instead of 1.

> diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c
> --- a/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/gsp/rm/r570/fbsr.c
[ ... ]
> @@ -81,7 +81,7 @@ r570_fbsr_init(struct nvkm_gsp *gsp, struct sg_table *sgt, u64 size)
>  	ctrl->hClient = gsp->internal.client.object.handle;
>  	ctrl->hSysMem = memlist.handle;
>  	ctrl->sysmemAddrOfSuspendResumeData = gsp->sr.meta.addr;
> -	ctrl->bEnteringGcoffState = 1;
> +	ctrl->bEnteringGcoffState = 0;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260727175246.642071-1-lyude@redhat.com?part=2