From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 994B3C531D0 for ; Mon, 27 Jul 2026 18:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VA5TgeTjgEDam4L7AO3WD5rp/3s2kgSGzZt2T/izXpY=; b=wtX/5trBRDcDi4 ViquIFq8wPBR/kqvoOMi3GC3yFHSyjH7HQqW/DK7YsVcsM2J0aNKsnSTgr+W2WUJno4AaqF5erP8k JECLsphARH5JB/C84KkMj1nNW+3+ofZa5pTAHN84Th207JIdUgsoN5k2tz7uRuA5T7Ol3svGM2h3k TK2dAdf6JGP+yc06JhjEXBoZ4FMkfrCcaklXd9HIFOLXOA6Hl3198kbAd9PjxT2qcJmOwb0jBqWsL dPV0dgyTR+uJe0P+/lJiMGU5cn1UPhIDluqQAsRT16XMp507PtqB4xG9/Kfqhu/8XwA20Azqb78/u xXrziQ1nplBsBwEMXTqA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1woQ7Q-00000003fwt-14C1; Mon, 27 Jul 2026 18:32:04 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1woQ7O-00000003fvX-0ovi for linux-phy@lists.infradead.org; Mon, 27 Jul 2026 18:32:02 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 624F460008; Mon, 27 Jul 2026 18:32:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 916701F000E9; Mon, 27 Jul 2026 18:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785177121; bh=7Udjanb1H9DVNjKGgmxcH/tjWmgiPuzp3pwFGTaMhmU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V9G4Noc+EdYO6HXq/u9R/BuAP0uSG4ZBc/3n3gX4o5R3wJJpvc5TSnMTAe8fXULcS k7OX9b5EtBI95nurFYaG4A6VhmK+1UK3xifrZ3s0DI30GBiehwlC0NoUkpQ50pu8/m MM30UitdJqqW5hDGuQIBRY4xu0daTsVaOEW17MFt9a5azBWx83DgFllt2PKRB5T7vm wZ+FusNoBku8WXJMCvQ1tZKz2clcYFLxzxilrwTVJ74f1Dq+p/GveOiZpBL3S4vBhh SshkrHvaxXe3MZcqIOZOLFaeUEuzaD5rJkpcwFJLbZLvOWvVi9Yqdo2AXeDc71zKSv Br0nePmae/PzQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, mfd@lists.linux.dev, vkoul@kernel.org, conor+dt@kernel.org, lee@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260727-zx29clk-v8-1-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-1-7a107b00f1dd@gmail.com> Date: Mon, 27 Jul 2026 18:32:00 +0000 Message-Id: <20260727183200.916701F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gU2VsZi1yZWZlcmVu Y2luZyBjeWNsaWMgZGVwZW5kZW5jeSBlbmZvcmNlZCBieSByZXF1aXJlZCBgcmVzZXRzYCBwcm9w ZXJ0eSBvbiB0aGUgcmVzZXQgcHJvdmlkZXIgaXRzZWxmLgotLQoKLS0tIFBhdGNoIFsxXTogW1BB VENIIHY4IDAxLzEyXSBkdC1iaW5kaW5nczogY2xrOiB6dGU6IEFkZCB6eDI5NzUyMHYzIHRvcCBj bG9jayBhbmQgcmVzZXQgY29udHJvbGxlciAtLS0KY29tbWl0IGJkMTBlMGQyZWRlNGI3NTIzZTNh YTIwMWM5ZGM5NDhjY2VlMWUzNTIKQXV0aG9yOiBTdGVmYW4gRMO2c2luZ2VyIDxzdGVmYW5kb2Vz aW5nZXJAZ21haWwuY29tPgpTdWJqZWN0OiBkdC1iaW5kaW5nczogY2xrOiB6dGU6IEFkZCB6eDI5 NzUyMHYzIHRvcCBjbG9jayBhbmQgcmVzZXQgY29udHJvbGxlcgoKVGhpcyBjb21taXQgYWRkcyBh IG5ldyBkZXZpY2UgdHJlZSBiaW5kaW5nIGZvciB0aGUgWlRFIHp4Mjk3NTIwdjMgdG9wIGNsb2Nr CmFuZCByZXNldCBjb250cm9sbGVyLiBJdCBkZXNjcmliZXMgdGhlIGNsb2NrIGlucHV0cywgUExM IG91dHB1dHMsIGFuZCByZXNldApjb250cm9scyBmb3IgdmFyaW91cyBwZXJpcGhlcmFscy4gVGhl IGJpbmRpbmcgYWxzbyBleHBvc2VzIFVTQiBhbmQgSFNJQyBQSFlzLAphbmQgYSBzeXNjb24tcmVi b290IG1ldGhvZC4KCj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5k aW5ncy9jbG9jay96dGUsengyOTc1MjB2My10b3Bjcm0ueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy9jbG9jay96dGUsengyOTc1MjB2My10b3Bjcm0ueWFtbAo+IG5ldyBm aWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uOWRiY2E0OTg3MWEwZQo+IC0t LSAvZGV2L251bGwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2xv Y2svenRlLHp4Mjk3NTIwdjMtdG9wY3JtLnlhbWwKWyAuLi4gXQo+ICsgIGludGVycnVwdC1uYW1l czoKPiArICAgIGl0ZW1zOgo+ICsgICAgICAtIGNvbnN0OiB1c2ItdXAKPiArICAgICAgLSBjb25z dDogdXNiLWRvd24KPiArICAgICAgLSBjb25zdDogaHNpYy11cAo+ICsgICAgICAtIGNvbnN0OiBo c2ljLWRvd24KPiArCj4gKyAgcmVzZXRzOgo+ICsgICAgaXRlbXM6Cj4gKyAgICAgIC0gZGVzY3Jp cHRpb246IFVTQiBwaHkgcmVzZXQKPiArICAgICAgLSBkZXNjcmlwdGlvbjogSFNJQyBwaHkgcmVz ZXQKPiArCj4gKyAgcmVzZXQtbmFtZXM6Cj4gKyAgICBpdGVtczoKPiArICAgICAgLSBjb25zdDog dXNiCj4gKyAgICAgIC0gY29uc3Q6IGhzaWMKPiArCj4gKyAgIiNjbG9jay1jZWxscyI6Cj4gKyAg ICBjb25zdDogMQo+ICsKPiArICAiI3BoeS1jZWxscyI6Cj4gKyAgICBjb25zdDogMQo+ICsKPiAr ICAiI3Jlc2V0LWNlbGxzIjoKPiArICAgIGNvbnN0OiAxCj4gKwo+ICsgIHN5c2Nvbi1yZWJvb3Q6 Cj4gKyAgICB0eXBlOiBvYmplY3QKPiArICAgICRyZWY6IC9zY2hlbWFzL3Bvd2VyL3Jlc2V0L3N5 c2Nvbi1yZWJvb3QueWFtbCMKPiArICAgIGRlc2NyaXB0aW9uOgo+ICsgICAgICBSZWJvb3QgbWV0 aG9kIGZvciB0aGUgU29DLgo+ICsKPiArcmVxdWlyZWQ6Cj4gKyAgLSBjb21wYXRpYmxlCj4gKyAg LSByZWcKPiArICAtIGNsb2Nrcwo+ICsgIC0gY2xvY2stbmFtZXMKPiArICAtIGludGVycnVwdHMK PiArICAtIGludGVycnVwdC1uYW1lcwo+ICsgIC0gcmVzZXRzCj4gKyAgLSByZXNldC1uYW1lcwoK W1NldmVyaXR5OiBNZWRpdW1dCklzIGl0IG5lY2Vzc2FyeSB0byBtYWtlIHRoZSByZXNldHMgcHJv cGVydHkgcmVxdWlyZWQgaGVyZT8KClNpbmNlIHRoaXMgbm9kZSBpcyBhbHNvIHRoZSByZXNldCBw cm92aWRlciAoaW5kaWNhdGVkIGJ5ICNyZXNldC1jZWxscyksCnJlcXVpcmluZyBpdCB0byBjb25z dW1lIGl0cyBvd24gcmVzZXRzIGNyZWF0ZXMgYSBzZWxmLXJlZmVyZW5jaW5nIGN5Y2xpYwpkZXBl bmRlbmN5IGR1cmluZyBkZXZpY2UgdHJlZSBwcm9iaW5nLiAKCkNvdWxkIHRoZSBkcml2ZXIgaW50 ZXJhY3Qgd2l0aCBpdHMgb3duIHJlZ2lzdGVycyBkaXJlY3RseSB0byBoYW5kbGUgdGhlc2UKcmVz ZXRzLCByYXRoZXIgdGhhbiBhY3RpbmcgYXMgYSByZXNldCBjb25zdW1lciBvZiBpdHNlbGY/Cgo+ ICsgIC0gc3lzY29uLXJlYm9vdAo+ICsgIC0gIiNjbG9jay1jZWxscyIKPiArICAtICIjcGh5LWNl bGxzIgo+ICsgIC0gIiNyZXNldC1jZWxscyIKPiArCj4gK3VuZXZhbHVhdGVkUHJvcGVydGllczog ZmFsc2UKPiArCj4gK2V4YW1wbGVzOgo+ICsgIC0gfAo+ICsgICAgI2luY2x1ZGUgPGR0LWJpbmRp bmdzL2ludGVycnVwdC1jb250cm9sbGVyL2FybS1naWMuaD4KPiArICAgICNpbmNsdWRlIDxkdC1i aW5kaW5ncy9yZXNldC96dGUsengyOTc1MjB2My1yZXNldC5oPgo+ICsgICAgI2luY2x1ZGUgPGR0 LWJpbmRpbmdzL3BoeS96dGUsengyOTc1MjB2My10b3Bjcm0uaD4KPiArICAgICNpbmNsdWRlIDxk dC1iaW5kaW5ncy9jbG9jay96dGUsengyOTc1MjB2My1jbGsuaD4KPiArCj4gKyAgICB0b3Bjcm06 IGNsb2NrLWNvbnRyb2xsZXJAMTNiMDAwIHsKPiArICAgICAgICBjb21wYXRpYmxlID0gInp0ZSx6 eDI5NzUyMHYzLXRvcGNybSIsICJzeXNjb24iOwo+ICsgICAgICAgIHJlZyA9IDwweDAwMTNiMDAw IDB4NDAwPjsKPiArICAgICAgICBjbG9ja3MgPSA8Jm9zYzI2bT4sIDwmb3NjMzJrPjsKPiArICAg ICAgICBjbG9jay1uYW1lcyA9ICJvc2MyNm0iLCAib3NjMzJrIjsKPiArICAgICAgICBpbnRlcnJ1 cHRzID0gPEdJQ19TUEkgNDIgSVJRX1RZUEVfRURHRV9SSVNJTkc+LAo+ICsgICAgICAgICAgICAg ICAgICAgICA8R0lDX1NQSSA0MyBJUlFfVFlQRV9FREdFX1JJU0lORz4sCj4gKyAgICAgICAgICAg ICAgICAgICAgIDxHSUNfU1BJIDQ1IElSUV9UWVBFX0VER0VfUklTSU5HPiwKPiArICAgICAgICAg ICAgICAgICAgICAgPEdJQ19TUEkgNDYgSVJRX1RZUEVfRURHRV9SSVNJTkc+Owo+ICsgICAgICAg IGludGVycnVwdC1uYW1lcyA9ICJ1c2ItdXAiLCAidXNiLWRvd24iLCAiaHNpYy11cCIsICJoc2lj LWRvd24iOwo+ICsgICAgICAgIHJlc2V0cyA9IDwmdG9wY3JtIFpYMjk3NTIwVjNfVVNCX1BIWV9S RVNFVD4sCj4gKyAgICAgICAgICAgICAgICAgPCZ0b3Bjcm0gWlgyOTc1MjBWM19IU0lDX1BIWV9S RVNFVD47CgpbU2V2ZXJpdHk6IE1lZGl1bV0KRG9lcyBtb2RlbGluZyB0aGUgaW50ZXJuYWwgcmVn aXN0ZXIgb3BlcmF0aW9ucyBhcyBleHRlcm5hbCBjb25zdW1lcgpkZXBlbmRlbmNpZXMgYXJ0aWZp Y2lhbGx5IGNyZWF0ZSB0aGUgZGVwZW5kZW5jeSBjeWNsZXMgbWVudGlvbmVkIGluIHRoZSBjb21t aXQKbWVzc2FnZT8KClRoZSBleGFtcGxlIGV4cGxpY2l0bHkgZGVtb25zdHJhdGVzIHRoZSBzZWxm LXJlZmVyZW5jaW5nIGN5Y2xpYyBkZXBlbmRlbmN5CmJhY2sgdG8gdGhlIHRvcGNybSBwaGFuZGxl LiBUeXBpY2FsbHksIGl0IGlzIGFuIGFudGktcGF0dGVybiBmb3IgYSByZXNldApwcm92aWRlciB0 byBtb2RlbCBpdHMgb3duIGludGVybmFsIHNpZ25hbCBsaW5lcyBhcyBleHRlcm5hbCBkZXBlbmRl bmNpZXMKcG9pbnRpbmcgYmFjayB0byBpdHNlbGYuCgpJZiB0aGUgZHJpdmVyIGhhbmRsZWQgaXRz IG93biBpbnRlcm5hbCByZXNldCBsb2dpYyBkaXJlY3RseSwgdGhpcyBjeWNsaWMKZGVwZW5kZW5j eSBjb3VsZCBiZSBhdm9pZGVkIHdpdGhvdXQgcmVseWluZyBvbiBmd19kZXZsaW5rIHRvIGZvcmNl ZnVsbHkgYnJlYWsKaXQuCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtv LmRldi8jL3BhdGNoc2V0LzIwMjYwNzI3LXp4MjljbGstdjgtMC03YTEwN2IwMGYxZGRAZ21haWwu Y29tP3BhcnQ9MQoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3RzLmlu ZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8v bGludXgtcGh5Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 859E0426693; Mon, 27 Jul 2026 18:32:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785177123; cv=none; b=niCqDhrPeSXvmNMRb+G0Rj2drSdjyb17DJcPWkBgm/SNGEhnN6fXD9Kav0Y4ODt+Tb1/JUcK3/cMLcBEdua0/p3AcM+c9DHKygLQQtXu6Y+L09mgHq5CR9l33xmrrG9q0ZGTaOfgrbiSMBYFRVboDhw8Gs1/yiTVNVeIDgzFhtk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785177123; c=relaxed/simple; bh=dlNlQLtQA7Eu1LpHNaYDErrnqTratFykeZk4pRryKf4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=rWGYaJlYpU9/apM1bxTXxspRC0Tnla8ud9uuIs7/HTvX5Wur98UsFkdtHzEK0XnQplehDVlbHAjN5HUou6jhV4BV5NXSIugTYnVyb2OAc5k9zhpxsicdy4vbHx7oNbmNPlevikNmHbJjkwxU2D4sWXTZcMr9lhwm3THL9t1CjiM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=V9G4Noc+; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="V9G4Noc+" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 916701F000E9; Mon, 27 Jul 2026 18:32:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785177121; bh=7Udjanb1H9DVNjKGgmxcH/tjWmgiPuzp3pwFGTaMhmU=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=V9G4Noc+EdYO6HXq/u9R/BuAP0uSG4ZBc/3n3gX4o5R3wJJpvc5TSnMTAe8fXULcS k7OX9b5EtBI95nurFYaG4A6VhmK+1UK3xifrZ3s0DI30GBiehwlC0NoUkpQ50pu8/m MM30UitdJqqW5hDGuQIBRY4xu0daTsVaOEW17MFt9a5azBWx83DgFllt2PKRB5T7vm wZ+FusNoBku8WXJMCvQ1tZKz2clcYFLxzxilrwTVJ74f1Dq+p/GveOiZpBL3S4vBhh SshkrHvaxXe3MZcqIOZOLFaeUEuzaD5rJkpcwFJLbZLvOWvVi9Yqdo2AXeDc71zKSv Br0nePmae/PzQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 01/12] dt-bindings: clk: zte: Add zx297520v3 top clock and reset controller Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, mfd@lists.linux.dev, vkoul@kernel.org, conor+dt@kernel.org, lee@kernel.org, olteanv@gmail.com, devicetree@vger.kernel.org In-Reply-To: <20260727-zx29clk-v8-1-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-1-7a107b00f1dd@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Jul 2026 18:32:00 +0000 Message-Id: <20260727183200.916701F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Self-referencing cyclic dependency enforced by required `resets`= property on the reset provider itself. -- --- Patch [1]: [PATCH v8 01/12] dt-bindings: clk: zte: Add zx297520v3 top c= lock and reset controller --- commit bd10e0d2ede4b7523e3aa201c9dc948ccee1e352 Author: Stefan D=C3=B6singer Subject: dt-bindings: clk: zte: Add zx297520v3 top clock and reset controll= er This commit adds a new device tree binding for the ZTE zx297520v3 top clock and reset controller. It describes the clock inputs, PLL outputs, and reset controls for various peripherals. The binding also exposes USB and HSIC PHY= s, and a syscon-reboot method. > diff --git a/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcr= m.yaml b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml > new file mode 100644 > index 0000000000000..9dbca49871a0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/zte,zx297520v3-topcrm.yaml [ ... ] > + interrupt-names: > + items: > + - const: usb-up > + - const: usb-down > + - const: hsic-up > + - const: hsic-down > + > + resets: > + items: > + - description: USB phy reset > + - description: HSIC phy reset > + > + reset-names: > + items: > + - const: usb > + - const: hsic > + > + "#clock-cells": > + const: 1 > + > + "#phy-cells": > + const: 1 > + > + "#reset-cells": > + const: 1 > + > + syscon-reboot: > + type: object > + $ref: /schemas/power/reset/syscon-reboot.yaml# > + description: > + Reboot method for the SoC. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - interrupt-names > + - resets > + - reset-names [Severity: Medium] Is it necessary to make the resets property required here? Since this node is also the reset provider (indicated by #reset-cells), requiring it to consume its own resets creates a self-referencing cyclic dependency during device tree probing.=20 Could the driver interact with its own registers directly to handle these resets, rather than acting as a reset consumer of itself? > + - syscon-reboot > + - "#clock-cells" > + - "#phy-cells" > + - "#reset-cells" > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + > + topcrm: clock-controller@13b000 { > + compatible =3D "zte,zx297520v3-topcrm", "syscon"; > + reg =3D <0x0013b000 0x400>; > + clocks =3D <&osc26m>, <&osc32k>; > + clock-names =3D "osc26m", "osc32k"; > + interrupts =3D , > + , > + , > + ; > + interrupt-names =3D "usb-up", "usb-down", "hsic-up", "hsic-down"; > + resets =3D <&topcrm ZX297520V3_USB_PHY_RESET>, > + <&topcrm ZX297520V3_HSIC_PHY_RESET>; [Severity: Medium] Does modeling the internal register operations as external consumer dependencies artificially create the dependency cycles mentioned in the com= mit message? The example explicitly demonstrates the self-referencing cyclic dependency back to the topcrm phandle. Typically, it is an anti-pattern for a reset provider to model its own internal signal lines as external dependencies pointing back to itself. If the driver handled its own internal reset logic directly, this cyclic dependency could be avoided without relying on fw_devlink to forcefully bre= ak it. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260727-zx29clk-v8= -0-7a107b00f1dd@gmail.com?part=3D1