From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE893C53209 for ; Mon, 27 Jul 2026 18:41:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9hQgnAAm24vpjwyDFbRD8GWTTr+RzufIPVLZkjpzhoM=; b=Xibn20/o+k3Glp uXizqyiwX9rO6Vud+WLVhmrLhveTjG8ooonOVw1ea+UzqHEn9dmRombEJJDWsteBt7QY9Z6EuTkky N79OeRcHIc1Z5a82N+oTWa8cBLP2ZN+EcsNiV56zlE6RS7NsRndNzQBYiN7+V24sYdqA8dcxx/TQD p8+Sdov3PAhN/sYm2N+89Hq9j5zVh1NkVLeElx0b+CjtKXwVVC5DNEyCJTw9xt20KDiDGINCrKgVd //rC+EFG5WDXAteQGXX+TZ5YUya38i+g0zKyMt6BCcjJm9fXz8COaPSj1UVssPEYSrXqmD4uqRUiM Znyck+NcB8eMKDs2mD3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1woQH0-00000003gj8-2Nwi; Mon, 27 Jul 2026 18:41:58 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1woQGz-00000003gj2-31qp for linux-phy@lists.infradead.org; Mon, 27 Jul 2026 18:41:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D5241418BB; Mon, 27 Jul 2026 18:41:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F0A61F000E9; Mon, 27 Jul 2026 18:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785177715; bh=TSVobNmrXXu+kac7ZH9ObOxx67WPbQQXF2FB/eSluCQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bxsBMgahd0Kr4buxlH0w4fb3Tetr+pDy2p9gwZgD/3pEIvy6xss5qY1XFPCxupI0O nWOuYiUyTXzz00DZCGJSMSNmLU1p06Lt8DGPWKcsqy9ImxHtLm6odTUwHxUlS62jr3 qt5JHkMLHyLn74XWh0o1ly5vsdQkKckJFElnChhfcr8bk6DzyLeHIhI7qHKeKIrVk8 8uAMi+rRMSbIJyN9JLJmicbvuTf40euklLQ5Ta1Bp81ZNhoRLAfOriY6A1qSf18Szg lzrYTXz/f95GN+Lvro+8atnof/f4s8Tfh5vA5jOA6hOizwKFpVzpvkIvMaaPw7Ye9e shFKn4xpjeybg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 04/12] mfd: zx297520v3: Add a clock and reset MFD driver To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: vkoul@kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, olteanv@gmail.com, conor+dt@kernel.org, lee@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260727-zx29clk-v8-4-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-4-7a107b00f1dd@gmail.com> Date: Mon, 27 Jul 2026 18:41:54 +0000 Message-Id: <20260727184155.2F0A61F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW01lZGl1bV0gUGxhdGZvcm0gZGF0 YSBmb3IgY2hpbGQgZGV2aWNlcyAoYG1mZF9jZWxsYCBhcnJheXMpIGlzIGltcHJvcGVybHkgcGFz c2VkIGFzIGNvbXBsZXggcG9pbnRlcnMgdmlhIHRoZSBgLmRhdGFgIGZpZWxkIG9mIHRoZSBgb2Zf ZGV2aWNlX2lkYCBtYXRjaCB0YWJsZS4KLS0KCi0tLSBQYXRjaCBbNF06IFtQQVRDSCB2OCAwNC8x Ml0gbWZkOiB6eDI5NzUyMHYzOiBBZGQgYSBjbG9jayBhbmQgcmVzZXQgTUZEIGRyaXZlciAtLS0K Y29tbWl0IDk5N2IzZWU0NGFiYzZlYzIzOWMzNjMyN2QxYzNmZDkwMzkzNTQyZGQKQXV0aG9yOiBT dGVmYW4gRMO2c2luZ2VyIDxzdGVmYW5kb2VzaW5nZXJAZ21haWwuY29tPgoKbWZkOiB6eDI5NzUy MHYzOiBBZGQgYSBjbG9jayBhbmQgcmVzZXQgTUZEIGRyaXZlcgoKVGhpcyBkcml2ZXIgcmVnaXN0 ZXJzIGNoaWxkIGRldmljZXMgZm9yIHRoZSB6eDI5NzUyMHYzIGNsb2NrIGFuZCByZXNldApjb250 cm9sbGVycy4gVGhlIGNsay16eDI5NzUyMHYzIGFuZCByZXNldC16dGUtengyOTc1MjB2MyBzdWJt aXR0ZWQgaW4KdGhlIG5leHQgcGF0Y2hlcyB3aWxsIGRyaXZlIHRoZSByZXNwZWN0aXZlIGZ1bmN0 aW9uYWxpdGllcy4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3p0ZS16eDI5NzUyMHYzLWNy bS5jIGIvZHJpdmVycy9tZmQvenRlLXp4Mjk3NTIwdjMtY3JtLmMKPiBuZXcgZmlsZSBtb2RlIDEw MDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLjNhNGY2Y2QwNzU2ZTMKPiAtLS0gL2Rldi9udWxs Cj4gKysrIGIvZHJpdmVycy9tZmQvenRlLXp4Mjk3NTIwdjMtY3JtLmMKClsgLi4uIF0KCj4gK3N0 YXRpYyBpbnQgengyOTc1MjB2M19jcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKPiArewo+ICsJY29uc3Qgc3RydWN0IHp4Mjk3NTIwdjNfY3JtX2RhdGEgKmRhdGE7Cj4gKwo+ ICsJZGF0YSA9IG9mX2RldmljZV9nZXRfbWF0Y2hfZGF0YSgmcGRldi0+ZGV2KTsKPiArCWlmICgh ZGF0YSkKPiArCQlyZXR1cm4gLUVOT0RFVjsKPiArCj4gKwlyZXR1cm4gZGV2bV9tZmRfYWRkX2Rl dmljZXMoJnBkZXYtPmRldiwgUExBVEZPUk1fREVWSURfQVVUTywgZGF0YS0+Y2VsbHMsCj4gKwkJ CQkgICAgZGF0YS0+bnVtX2NlbGxzLCBOVUxMLCAwLCBOVUxMKTsKPiArfQo+ICsKPiArc3RhdGlj IGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgb2ZfbWF0Y2hfengyOTc1MjB2M19jcm1bXSA9IHsK PiArCXsgLmNvbXBhdGlibGUgPSAienRlLHp4Mjk3NTIwdjMtdG9wY3JtIiwgLmRhdGEgPSAmengy OTc1MjB2M190b3Bjcm1fZGF0YSB9LAo+ICsJeyAuY29tcGF0aWJsZSA9ICJ6dGUsengyOTc1MjB2 My1tYXRyaXhjcm0iLCAuZGF0YSA9ICZ6eDI5NzUyMHYzX21hdHJpeGNybV9kYXRhIH0sCj4gKwl7 IC5jb21wYXRpYmxlID0gInp0ZSx6eDI5NzUyMHYzLWxzcGNybSIsIC5kYXRhID0gJnp4Mjk3NTIw djNfbHNwY3JtX2RhdGEgfSwKCltTZXZlcml0eTogTWVkaXVtXQpEb2VzIHBhc3NpbmcgcGxhdGZv cm0gZGF0YSBmb3IgY2hpbGQgZGV2aWNlcyB2aWEgdGhlIC5kYXRhIGZpZWxkIGFzIGNvbXBsZXgK cG9pbnRlcnMgdmlvbGF0ZSBNRkQgc3Vic3lzdGVtIGFyY2hpdGVjdHVyZSBndWlkZWxpbmVzPwoK SW5zdGVhZCBvZiBtYXBwaW5nIGNvbXBhdGlibGUgc3RyaW5ncyBkaXJlY3RseSB0byB6eDI5NzUy MHYzX2NybV9kYXRhIHBvaW50ZXJzCnZpYSB0aGUgLmRhdGEgZmllbGQsIHNob3VsZCB0aGlzIHVz ZSBhbiBJRCBlbnVtIG9yIGludGVnZXIgSUQsIGFuZCBoYXZlCnp4Mjk3NTIwdjNfY3JtX3Byb2Jl KCkgc3dpdGNoIG9uIHRoZSBJRCB0byBzZWxlY3QgdGhlIGNvcnJlY3Qgc3RhdGljIGNvbnN0Cm1m ZF9jZWxsIGFycmF5PwoKPiArCXsgfQo+ICt9OwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3IGh0 dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDcyNy16eDI5Y2xrLXY4LTAtN2ExMDdi MDBmMWRkQGdtYWlsLmNvbT9wYXJ0PTQKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4 LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 254A44322F5; Mon, 27 Jul 2026 18:41:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785177717; cv=none; b=Ybp2KUtEtLybVzt0l72gCgc3aGAIi1qFwM27zj4p5PmcGvlzlq4aJkK3sHLSTNSFr6uVjp/9cwSIDd4xssLo4GIm/PV6MwWdG6RZhdUaWLy6k8cG68BKhuilB99xyuLdZxVQn0dkEAXoyJ6jK5Bo249O6u9kF7tS1laTZ8WLIPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785177717; c=relaxed/simple; bh=0waXHSCkdc6qGkQn0Rfbge2g3yHCPz5zX/LnQCiCMu4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=WFbZ9ItJKkSbHg/Gm60ygZZUmDx/74xxr2wZzIC6mpARfHn6lKNGc+4v0Dj5lY/qbl6u1GW8rr8E9pbtmaLv1VLHJ0e7olRCXj7N58bUToDNGaD1pGD8H8r/IYefK/GXaxDmeLMcr6Lz/h2wK806S+4lsg4iIPwzAQAf7cphvNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bxsBMgah; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bxsBMgah" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F0A61F000E9; Mon, 27 Jul 2026 18:41:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1785177715; bh=TSVobNmrXXu+kac7ZH9ObOxx67WPbQQXF2FB/eSluCQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=bxsBMgahd0Kr4buxlH0w4fb3Tetr+pDy2p9gwZgD/3pEIvy6xss5qY1XFPCxupI0O nWOuYiUyTXzz00DZCGJSMSNmLU1p06Lt8DGPWKcsqy9ImxHtLm6odTUwHxUlS62jr3 qt5JHkMLHyLn74XWh0o1ly5vsdQkKckJFElnChhfcr8bk6DzyLeHIhI7qHKeKIrVk8 8uAMi+rRMSbIJyN9JLJmicbvuTf40euklLQ5Ta1Bp81ZNhoRLAfOriY6A1qSf18Szg lzrYTXz/f95GN+Lvro+8atnof/f4s8Tfh5vA5jOA6hOizwKFpVzpvkIvMaaPw7Ye9e shFKn4xpjeybg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v8 04/12] mfd: zx297520v3: Add a clock and reset MFD driver Reply-To: sashiko-reviews@lists.linux.dev To: =?utf-8?b?U3RlZmFuIETDtnNpbmdlcg==?= Cc: vkoul@kernel.org, devicetree@vger.kernel.org, mfd@lists.linux.dev, olteanv@gmail.com, conor+dt@kernel.org, lee@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org In-Reply-To: <20260727-zx29clk-v8-4-7a107b00f1dd@gmail.com> References: <20260727-zx29clk-v8-0-7a107b00f1dd@gmail.com> <20260727-zx29clk-v8-4-7a107b00f1dd@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 27 Jul 2026 18:41:54 +0000 Message-Id: <20260727184155.2F0A61F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Medium] Platform data for child devices (`mfd_cell` arrays) is improperl= y passed as complex pointers via the `.data` field of the `of_device_id` ma= tch table. -- --- Patch [4]: [PATCH v8 04/12] mfd: zx297520v3: Add a clock and reset MFD = driver --- commit 997b3ee44abc6ec239c36327d1c3fd90393542dd Author: Stefan D=C3=B6singer mfd: zx297520v3: Add a clock and reset MFD driver This driver registers child devices for the zx297520v3 clock and reset controllers. The clk-zx297520v3 and reset-zte-zx297520v3 submitted in the next patches will drive the respective functionalities. > diff --git a/drivers/mfd/zte-zx297520v3-crm.c b/drivers/mfd/zte-zx297520v= 3-crm.c > new file mode 100644 > index 0000000000000..3a4f6cd0756e3 > --- /dev/null > +++ b/drivers/mfd/zte-zx297520v3-crm.c [ ... ] > +static int zx297520v3_crm_probe(struct platform_device *pdev) > +{ > + const struct zx297520v3_crm_data *data; > + > + data =3D of_device_get_match_data(&pdev->dev); > + if (!data) > + return -ENODEV; > + > + return devm_mfd_add_devices(&pdev->dev, PLATFORM_DEVID_AUTO, data->cell= s, > + data->num_cells, NULL, 0, NULL); > +} > + > +static const struct of_device_id of_match_zx297520v3_crm[] =3D { > + { .compatible =3D "zte,zx297520v3-topcrm", .data =3D &zx297520v3_topcrm= _data }, > + { .compatible =3D "zte,zx297520v3-matrixcrm", .data =3D &zx297520v3_mat= rixcrm_data }, > + { .compatible =3D "zte,zx297520v3-lspcrm", .data =3D &zx297520v3_lspcrm= _data }, [Severity: Medium] Does passing platform data for child devices via the .data field as complex pointers violate MFD subsystem architecture guidelines? Instead of mapping compatible strings directly to zx297520v3_crm_data point= ers via the .data field, should this use an ID enum or integer ID, and have zx297520v3_crm_probe() switch on the ID to select the correct static const mfd_cell array? > + { } > +}; --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260727-zx29clk-v8= -0-7a107b00f1dd@gmail.com?part=3D4